automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [dpdk-test-report] |WARNING| pw97448 [PATCH 30/38] common/sfc_efx/base: add a means to read MAE mport journal
Date: Fri, 27 Aug 2021 09:01:16 +0200 (CEST)	[thread overview]
Message-ID: <20210827070116.870BB1226B3@dpdk.org> (raw)
In-Reply-To: <20210827065717.1838258-31-andrew.rybchenko@oktetlabs.ru>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97448

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#140: FILE: drivers/common/sfc_efx/base/efx.h:4691:
+	__in				efx_mae_read_mport_journal_cb *cbp,
 	    				                              ^

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#162: FILE: drivers/common/sfc_efx/base/efx_mae.c:3303:
+	memset(desc, 0, sizeof (*desc));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#234: FILE: drivers/common/sfc_efx/base/efx_mae.c:3375:
+	return (rc);

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#240: FILE: drivers/common/sfc_efx/base/efx_mae.c:3381:
+	__in				efx_mae_read_mport_journal_cb *cbp,
 	    				                              ^

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#326: FILE: drivers/common/sfc_efx/base/efx_mae.c:3467:
+		(*cbp)(cb_datap, &desc, sizeof (desc));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#344: FILE: drivers/common/sfc_efx/base/efx_mae.c:3485:
+	return (rc);

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#350: FILE: drivers/common/sfc_efx/base/efx_mae.c:3491:
+	__in				efx_mae_read_mport_journal_cb *cbp,
 	    				                              ^

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#369: FILE: drivers/common/sfc_efx/base/efx_mae.c:3510:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#375: FILE: drivers/common/sfc_efx/base/efx_mae.c:3516:
+	return (rc);

total: 7 errors, 2 warnings, 363 lines checked

           reply	other threads:[~2021-08-27  7:01 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210827065717.1838258-31-andrew.rybchenko@oktetlabs.ru>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210827070116.870BB1226B3@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).