From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 025C6A0C41
	for <public@inbox.dpdk.org>; Fri, 27 Aug 2021 09:01:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 033F041258;
	Fri, 27 Aug 2021 09:01:21 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8ADD5411D3
 for <test-report@dpdk.org>; Fri, 27 Aug 2021 09:01:16 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 870BB1226B3; Fri, 27 Aug 2021 09:01:16 +0200 (CEST)
In-Reply-To: <20210827065717.1838258-31-andrew.rybchenko@oktetlabs.ru>
References: <20210827065717.1838258-31-andrew.rybchenko@oktetlabs.ru>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-Id: <20210827070116.870BB1226B3@dpdk.org>
Date: Fri, 27 Aug 2021 09:01:16 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw97448 [PATCH 30/38]
 common/sfc_efx/base: add a means to read MAE mport journal
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97448

_coding style issues_


ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#140: FILE: drivers/common/sfc_efx/base/efx.h:4691:
+	__in				efx_mae_read_mport_journal_cb *cbp,
 	    				                              ^

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#162: FILE: drivers/common/sfc_efx/base/efx_mae.c:3303:
+	memset(desc, 0, sizeof (*desc));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#234: FILE: drivers/common/sfc_efx/base/efx_mae.c:3375:
+	return (rc);

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#240: FILE: drivers/common/sfc_efx/base/efx_mae.c:3381:
+	__in				efx_mae_read_mport_journal_cb *cbp,
 	    				                              ^

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#326: FILE: drivers/common/sfc_efx/base/efx_mae.c:3467:
+		(*cbp)(cb_datap, &desc, sizeof (desc));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#344: FILE: drivers/common/sfc_efx/base/efx_mae.c:3485:
+	return (rc);

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#350: FILE: drivers/common/sfc_efx/base/efx_mae.c:3491:
+	__in				efx_mae_read_mport_journal_cb *cbp,
 	    				                              ^

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#369: FILE: drivers/common/sfc_efx/base/efx_mae.c:3510:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#375: FILE: drivers/common/sfc_efx/base/efx_mae.c:3516:
+	return (rc);

total: 7 errors, 2 warnings, 363 lines checked