From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <gakhil@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw97514 [PATCH 3/8] cryptodev: add helper functions for new datapath interface
Date: Sun, 29 Aug 2021 14:52:35 +0200 (CEST) [thread overview]
Message-ID: <20210829125235.8306E1226B3@dpdk.org> (raw)
In-Reply-To: <20210829125139.2173235-4-gakhil@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97514
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#211: FILE: lib/cryptodev/cryptodev_pmd.h:632:
+#define _RTE_CRYPTO_DEQ_DEF(fn) \
+_RTE_CRYPTO_DEQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_dequeue_prolog(dev_id, qp_id); \
+ if (qp == NULL) \
+ return 0; \
+ nb_ops = fn(qp, ops, nb_ops); \
+ return _rte_cryptodev_dequeue_epilog(dev_id, qp_id, ops, nb_ops); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#211: FILE: lib/cryptodev/cryptodev_pmd.h:632:
+#define _RTE_CRYPTO_DEQ_DEF(fn) \
+_RTE_CRYPTO_DEQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_dequeue_prolog(dev_id, qp_id); \
+ if (qp == NULL) \
+ return 0; \
+ nb_ops = fn(qp, ops, nb_ops); \
+ return _rte_cryptodev_dequeue_epilog(dev_id, qp_id, ops, nb_ops); \
+}
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#289: FILE: lib/cryptodev/cryptodev_pmd.h:710:
+#define _RTE_CRYPTO_ENQ_DEF(fn) \
+_RTE_CRYPTO_ENQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_enqueue_prolog(dev_id, qp_id, ops, nb_ops); \
+ if (qp == NULL) \
+ return 0; \
+ return fn(qp, ops, nb_ops); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#289: FILE: lib/cryptodev/cryptodev_pmd.h:710:
+#define _RTE_CRYPTO_ENQ_DEF(fn) \
+_RTE_CRYPTO_ENQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_enqueue_prolog(dev_id, qp_id, ops, nb_ops); \
+ if (qp == NULL) \
+ return 0; \
+ return fn(qp, ops, nb_ops); \
+}
total: 2 errors, 2 warnings, 320 lines checked
parent reply other threads:[~2021-08-29 12:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210829125139.2173235-4-gakhil@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829125235.8306E1226B3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gakhil@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).