* [dpdk-test-report] |WARNING| pw97514 [PATCH 3/8] cryptodev: add helper functions for new datapath interface
[not found] <20210829125139.2173235-4-gakhil@marvell.com>
@ 2021-08-29 12:52 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-08-29 12:52 UTC (permalink / raw)
To: test-report; +Cc: Akhil Goyal
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97514
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#211: FILE: lib/cryptodev/cryptodev_pmd.h:632:
+#define _RTE_CRYPTO_DEQ_DEF(fn) \
+_RTE_CRYPTO_DEQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_dequeue_prolog(dev_id, qp_id); \
+ if (qp == NULL) \
+ return 0; \
+ nb_ops = fn(qp, ops, nb_ops); \
+ return _rte_cryptodev_dequeue_epilog(dev_id, qp_id, ops, nb_ops); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#211: FILE: lib/cryptodev/cryptodev_pmd.h:632:
+#define _RTE_CRYPTO_DEQ_DEF(fn) \
+_RTE_CRYPTO_DEQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_dequeue_prolog(dev_id, qp_id); \
+ if (qp == NULL) \
+ return 0; \
+ nb_ops = fn(qp, ops, nb_ops); \
+ return _rte_cryptodev_dequeue_epilog(dev_id, qp_id, ops, nb_ops); \
+}
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#289: FILE: lib/cryptodev/cryptodev_pmd.h:710:
+#define _RTE_CRYPTO_ENQ_DEF(fn) \
+_RTE_CRYPTO_ENQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_enqueue_prolog(dev_id, qp_id, ops, nb_ops); \
+ if (qp == NULL) \
+ return 0; \
+ return fn(qp, ops, nb_ops); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#289: FILE: lib/cryptodev/cryptodev_pmd.h:710:
+#define _RTE_CRYPTO_ENQ_DEF(fn) \
+_RTE_CRYPTO_ENQ_PROTO(fn) \
+{ \
+ void *qp = _rte_cryptodev_enqueue_prolog(dev_id, qp_id, ops, nb_ops); \
+ if (qp == NULL) \
+ return 0; \
+ return fn(qp, ops, nb_ops); \
+}
total: 2 errors, 2 warnings, 320 lines checked
^ permalink raw reply [flat|nested] only message in thread