From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shijith Thotton <sthotton@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw97786 [PATCH v2 2/8] event/cnxk: add macro to set eventdev ops
Date: Thu, 2 Sep 2021 14:21:29 +0200 (CEST) [thread overview]
Message-ID: <20210902122129.54686122E33@dpdk.org> (raw)
In-Reply-To: <61c10bd36641c9d241c8ce2ab7b2544437b714c5.1630584303.git.sthotton@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97786
_coding style issues_
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#97: FILE: drivers/event/cnxk/cn10k_eventdev.c:9:
+#define CN10K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops) \
+ do { \
+ deq_op = deq_ops \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)]; \
+ } while (0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#108: FILE: drivers/event/cnxk/cn10k_eventdev.c:20:
+#define CN10K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \
+ do { \
+ enq_op = enq_ops \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)]; \
+ } while (0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#295: FILE: drivers/event/cnxk/cn9k_eventdev.c:12:
+#define CN9K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops) \
+ do { \
+ deq_op = deq_ops \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)] \
+ [!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)]; \
+ } while (0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#306: FILE: drivers/event/cnxk/cn9k_eventdev.c:23:
+#define CN9K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops) \
+ do { \
+ enq_op = enq_ops \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \
+ [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)]; \
+ } while (0)
total: 0 errors, 4 warnings, 493 lines checked
parent reply other threads:[~2021-09-02 12:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <61c10bd36641c9d241c8ce2ab7b2544437b714c5.1630584303.git.sthotton@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902122129.54686122E33@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=sthotton@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).