automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw97853 [PATCH 3/5] app/dumpcap: add new packet capture application
Date: Fri,  3 Sep 2021 02:49:07 +0200 (CEST)	[thread overview]
Message-ID: <20210903004907.3FBB0122E33@dpdk.org> (raw)
In-Reply-To: <20210903004732.109023-4-stephen@networkplumber.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97853

_coding style issues_


WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'autostop', this function's name, in a string
#272: FILE: app/dumpcap/main.c:172:
+			 "Unknown autostop parameter \"%s\"
", opt);

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#598: FILE: app/dumpcap/main.c:498:
+	const char *args[] = {

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#623: FILE: app/dumpcap/main.c:523:
+	struct rte_ring *pring;

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#637: FILE: app/dumpcap/main.c:537:
+	pring = rte_ring_lookup(RING_NAME);

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#638: FILE: app/dumpcap/main.c:538:
+	if (pring == NULL) {

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#639: FILE: app/dumpcap/main.c:539:
+		pring = rte_ring_create(RING_NAME, ring_size,

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#641: FILE: app/dumpcap/main.c:541:
+		if (pring == NULL)

WARNING:TYPO_SPELLING: 'pring' may be misspelled - perhaps 'print'?
#645: FILE: app/dumpcap/main.c:545:
+	return pring;

WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#705: FILE: app/dumpcap/main.c:605:
+		fd = open(output_name, O_WRONLY | O_CREAT, mode);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#725: FILE: app/dumpcap/main.c:625:
+		return pcapng;
+	} else {

total: 0 errors, 10 warnings, 847 lines checked

           reply	other threads:[~2021-09-03  0:49 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210903004732.109023-4-stephen@networkplumber.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903004907.3FBB0122E33@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).