automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw98381 [PATCH v4 6/8] app/dumpcap: add new packet capture application
       [not found] <20210908171644.26571-7-stephen@networkplumber.org>
@ 2021-09-08 17:17 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-09-08 17:17 UTC (permalink / raw)
  To: test-report; +Cc: Stephen Hemminger

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98381

_coding style issues_


WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#606: FILE: app/dumpcap/main.c:505:
+	const char *args[] = {

WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#714: FILE: app/dumpcap/main.c:613:
+		fd = open(output_name, O_WRONLY | O_CREAT, mode);

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#734: FILE: app/dumpcap/main.c:633:
+		return pcapng;
+	} else {

total: 0 errors, 3 warnings, 850 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-08 17:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210908171644.26571-7-stephen@networkplumber.org>
2021-09-08 17:17 ` [dpdk-test-report] |WARNING| pw98381 [PATCH v4 6/8] app/dumpcap: add new packet capture application checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).