From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BDC25A0547
	for <public@inbox.dpdk.org>; Thu,  9 Sep 2021 13:16:39 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B9DC54013F;
	Thu,  9 Sep 2021 13:16:39 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id D50D640041
 for <test-report@dpdk.org>; Thu,  9 Sep 2021 13:16:37 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id CC25D122D56; Thu,  9 Sep 2021 13:16:37 +0200 (CEST)
In-Reply-To: <20210909111500.3901706-3-g.singh@nxp.com>
References: <20210909111500.3901706-3-g.singh@nxp.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Gagandeep Singh <g.singh@nxp.com>
Message-Id: <20210909111637.CC25D122D56@dpdk.org>
Date: Thu,  9 Sep 2021 13:16:37 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw98420 [PATCH 2/6] dma/dpaa: add
 device probe and remove functionality
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98420

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#350: FILE: drivers/dma/dpaa/dpaa_qdma.c:229:
+	if (ret) {
+		return ret;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#476: FILE: drivers/dma/dpaa/dpaa_qdma.c:355:
+	if (unlikely(ccsr_qdma_fd < 0)) {
+		goto err;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#487: FILE: drivers/dma/dpaa/dpaa_qdma.c:366:
+	if (fsl_qdma->ctrl_base == MAP_FAILED) {
+		goto err;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#533: FILE: drivers/dma/dpaa/dpaa_qdma.c:411:
+	if (!dmadev) {
+		return -EINVAL;
+	}

WARNING:TYPO_SPELLING: 'SER' may be misspelled - perhaps 'SET'?
#687: FILE: drivers/dma/dpaa/dpaa_qdma.h:103:
+#define QDMA_CCDF_SER			BIT(30)

WARNING:TYPO_SPELLING: 'ser' may be misspelled - perhaps 'set'?
#740: FILE: drivers/dma/dpaa/dpaa_qdma.h:156:
+	__le32 status; /* ser, status */

total: 0 errors, 6 warnings, 702 lines checked
Warning in drivers/dma/dpaa/dpaa_qdma.c:
Using rte_atomicNN_xxx