From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1AD3AA0547
	for <public@inbox.dpdk.org>; Thu,  9 Sep 2021 16:33:18 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1317140041;
	Thu,  9 Sep 2021 16:33:18 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 32BBB4003E
 for <test-report@dpdk.org>; Thu,  9 Sep 2021 16:33:17 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 25BEE122D56; Thu,  9 Sep 2021 16:33:17 +0200 (CEST)
In-Reply-To: <20210909142428.750634-3-radu.nicolau@intel.com>
References: <20210909142428.750634-3-radu.nicolau@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Radu Nicolau <radu.nicolau@intel.com>
Message-Id: <20210909143317.25BEE122D56@dpdk.org>
Date: Thu,  9 Sep 2021 16:33:17 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw98445 [PATCH 2/4] net/iavf: add iAVF
 IPsec inline crypto support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98445

_coding style issues_


WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?
#65: 
operations. IPsec Crypto requests receive an initial acknowledgement

WARNING:TYPO_SPELLING: 'metdata' may be misspelled - perhaps 'metadata'?
#3429: FILE: drivers/net/iavf/iavf_rxtx.c:2494:
+iavf_ipsec_crypto_get_pkt_metdata(const struct iavf_tx_queue *txq,

WARNING:TYPO_SPELLING: 'metdata' may be misspelled - perhaps 'metadata'?
#3533: FILE: drivers/net/iavf/iavf_rxtx.c:2548:
+		ipsec_md = iavf_ipsec_crypto_get_pkt_metdata(txq, mb);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#3580: FILE: drivers/net/iavf/iavf_rxtx.c:2581:
+						if (idx == 0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx16>
#3902: FILE: drivers/net/iavf/iavf_rxtx.h:317:
+		"QW0: 0x%04"PRIx16" %04"PRIx16" %04"PRIx16" %04"PRIx16", "

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#3902: FILE: drivers/net/iavf/iavf_rxtx.h:317:
+		"QW0: 0x%04"PRIx16" %04"PRIx16" %04"PRIx16" %04"PRIx16", "

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#3903: FILE: drivers/net/iavf/iavf_rxtx.h:318:
+		"QW1: 0x%04"PRIx16" %04"PRIx16" %04"PRIx16" %04"PRIx16"
",

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#4433: FILE: drivers/net/iavf/iavf_rxtx.h:1061:
+	printf("QW0: Buffer Address : 0x%016"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#4433: FILE: drivers/net/iavf/iavf_rxtx.h:1061:
+	printf("QW0: Buffer Address : 0x%016"PRIx64"
",

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4514: FILE: drivers/net/iavf/iavf_rxtx_vec_sse.c:366:
+	const __m128i ptype_mask = _mm_set_epi16(

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#4590: FILE: drivers/net/iavf/iavf_vchnl.c:349:
+				if (msg_opc == VIRTCHNL_OP_INLINE_IPSEC_CRYPTO
+					&& imsg->ipsec_opcode ==

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4612: FILE: drivers/net/iavf/iavf_vchnl.c:365:
+					if (rte_atomic32_read(

total: 0 errors, 4 warnings, 8 checks, 4771 lines checked
Warning in drivers/net/iavf/iavf.h:
Using rte_atomicNN_xxx