From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw98518 [PATCH v6 08/10] app/dumpcap: add new packet capture application
Date: Fri, 10 Sep 2021 01:35:42 +0200 (CEST) [thread overview]
Message-ID: <20210909233542.098A6122527@dpdk.org> (raw)
In-Reply-To: <20210909233329.190021-9-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98518
_coding style issues_
WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#606: FILE: app/dumpcap/main.c:505:
+ const char *args[] = {
WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#714: FILE: app/dumpcap/main.c:613:
+ fd = open(output_name, O_WRONLY | O_CREAT, mode);
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#734: FILE: app/dumpcap/main.c:633:
+ return pcapng;
+ } else {
total: 0 errors, 3 warnings, 850 lines checked
parent reply other threads:[~2021-09-09 23:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210909233329.190021-9-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909233542.098A6122527@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).