automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Radu Nicolau <radu.nicolau@intel.com>
Subject: [dpdk-test-report] |WARNING| pw98918 [PATCH v2 2/4] net/iavf: add iAVF IPsec inline crypto support
Date: Wed, 15 Sep 2021 15:41:27 +0200 (CEST)	[thread overview]
Message-ID: <20210915134127.284DD122EE7@dpdk.org> (raw)
In-Reply-To: <20210915133211.1310791-3-radu.nicolau@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98918

_coding style issues_


WARNING:TYPO_SPELLING: 'acknowledgement' may be misspelled - perhaps 'acknowledgment'?
#67: 
operations. IPsec Crypto requests receive an initial acknowledgement

ERROR:CODE_INDENT: code indent should use tabs where possible
#2046: FILE: drivers/net/iavf/iavf_ipsec_crypto.c:1687:
+^I                && actions[1].type == RTE_FLOW_ACTION_TYPE_END) {$

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#2046: FILE: drivers/net/iavf/iavf_ipsec_crypto.c:1687:
+	if (actions[0].type == RTE_FLOW_ACTION_TYPE_SECURITY
+	                && actions[1].type == RTE_FLOW_ACTION_TYPE_END) {

WARNING:TYPO_SPELLING: 'metdata' may be misspelled - perhaps 'metadata'?
#3350: FILE: drivers/net/iavf/iavf_rxtx.c:2419:
+iavf_ipsec_crypto_get_pkt_metdata(const struct iavf_tx_queue *txq,

WARNING:TYPO_SPELLING: 'metdata' may be misspelled - perhaps 'metadata'?
#3454: FILE: drivers/net/iavf/iavf_rxtx.c:2473:
+		ipsec_md = iavf_ipsec_crypto_get_pkt_metdata(txq, mb);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#3502: FILE: drivers/net/iavf/iavf_rxtx.c:2507:
+						if (idx == 0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx16>
#3824: FILE: drivers/net/iavf/iavf_rxtx.h:317:
+		"QW0: 0x%04"PRIx16" %04"PRIx16" %04"PRIx16" %04"PRIx16", "

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#3824: FILE: drivers/net/iavf/iavf_rxtx.h:317:
+		"QW0: 0x%04"PRIx16" %04"PRIx16" %04"PRIx16" %04"PRIx16", "

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#3825: FILE: drivers/net/iavf/iavf_rxtx.h:318:
+		"QW1: 0x%04"PRIx16" %04"PRIx16" %04"PRIx16" %04"PRIx16"
",

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#4355: FILE: drivers/net/iavf/iavf_rxtx.h:1061:
+	printf("QW0: Buffer Address : 0x%016"PRIx64"
",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#4355: FILE: drivers/net/iavf/iavf_rxtx.h:1061:
+	printf("QW0: Buffer Address : 0x%016"PRIx64"
",

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4436: FILE: drivers/net/iavf/iavf_rxtx_vec_sse.c:366:
+	const __m128i ptype_mask = _mm_set_epi16(

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#4512: FILE: drivers/net/iavf/iavf_vchnl.c:349:
+				if (msg_opc == VIRTCHNL_OP_INLINE_IPSEC_CRYPTO
+					&& imsg->ipsec_opcode ==

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#4534: FILE: drivers/net/iavf/iavf_vchnl.c:365:
+					if (rte_atomic32_read(

total: 1 errors, 4 warnings, 9 checks, 4698 lines checked
Warning in drivers/net/iavf/iavf.h:
Using rte_atomicNN_xxx

           reply	other threads:[~2021-09-15 13:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210915133211.1310791-3-radu.nicolau@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210915134127.284DD122EE7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=radu.nicolau@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).