[dpdk-test-report] |WARNING| pw98939 [PATCH v2] drivers: add external clock support for cnxk timer

automatic DPDK test reports
 help / color / mirror / Atom feed

* [dpdk-test-report] |WARNING| pw98939 [PATCH v2] drivers: add external clock support for cnxk timer
       [not found] <abba6d4e9e332734b767596ac5a8bc482b68d6ac.1631721608.git.sthotton@marvell.com>
@ 2021-09-15 16:07 ` checkpatch
  0 siblings, 0 replies; 2+ messages in thread
From: checkpatch @ 2021-09-15 16:07 UTC (permalink / raw)
  To: test-report; +Cc: Shijith Thotton

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/98939

_coding style issues_


WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#82: 
To configure tim with external clock, requested resolution should be

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#85: 
tim_ext_clk is the devarg used to pass external clock frequency.

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#87: 
E.g. -a 0002:0e:00.0,tim_ext_clk=122880000

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#113: FILE: doc/guides/eventdevs/cnxk.rst:167:
+- ``TIM external clock frequency``

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#115: FILE: doc/guides/eventdevs/cnxk.rst:169:
+  The ``tim_ext_clk`` devagrs can be used to pass external clock frequency when

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#120: FILE: doc/guides/eventdevs/cnxk.rst:174:
+    -a 0002:0e:00.0,tim_ext_clk=122880000

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#145: FILE: drivers/common/cnxk/roc_tim.h:13:
+	ROC_TIM_CLK_SRC_SYNCE,

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#146: FILE: drivers/common/cnxk/roc_tim.h:14:
+	ROC_TIM_CLK_SRC_BTS,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#219: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:152:
+		} while (ns[i] % cnxk_tim_min_resolution_ns(clk_freq));

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#227: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:160:
+tim_adjust_resolution(uint64_t *req_ns, uint64_t *req_tck, double tck_ns,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#235: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:168:
+	uint64_t m_tck = cnxk_tim_min_tmo_ticks(cnxk_tim_cntfrq());

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#235: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:168:
+	uint64_t m_tck = cnxk_tim_min_tmo_ticks(cnxk_tim_cntfrq());

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#249: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:182:
+			    (TIM_MAX_BUCKET_SIZE - TIM_MIN_BUCKET_SIZE)) {

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#249: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:182:
+			    (TIM_MAX_BUCKET_SIZE - TIM_MIN_BUCKET_SIZE)) {

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#254: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:187:
+			   (TIM_MAX_BUCKET_SIZE - TIM_MIN_BUCKET_SIZE)) {

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#254: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:187:
+			   (TIM_MAX_BUCKET_SIZE - TIM_MIN_BUCKET_SIZE)) {

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#285: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:240:
+			cnxk_tim_min_resolution_ns(cnxk_tim_cntfrq()));

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#285: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:240:
+			cnxk_tim_min_resolution_ns(cnxk_tim_cntfrq()));

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#292: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:247:
+			goto tim_hw_free;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#298: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:253:
+		tim_adjust_resolution(&req_ns, &req_tck, tck_ns,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#299: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:254:
+				      cnxk_tim_cntfrq(), rcfg->max_tmo_ns);

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#303: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:258:
+			goto tim_hw_free;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#307: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:262:
+	tim_ring->tck_nsec = rcfg->timer_tick_ns;

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#321: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:307:
+		interval = NSEC2TICK(tim_ring->tck_nsec, cnxk_tim_cntfrq());

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#321: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:307:
+		interval = NSEC2TICK(tim_ring->tck_nsec, cnxk_tim_cntfrq());

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#323: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:309:
+		interval = NSEC2TICK(tim_ring->tck_nsec, dev->ext_clk_frq);

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#325: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:311:
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#325: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:311:
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#325: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:311:
+	rc = roc_tim_lf_config(&dev->tim, tim_ring->ring_id,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#326: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:312:
+			       cnxk_tim_convert_clk_src(tim_ring->clk_src), 0,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#326: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:312:
+			       cnxk_tim_convert_clk_src(tim_ring->clk_src), 0,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#327: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:313:
+			       0, tim_ring->nb_bkts, tim_ring->chunk_sz,

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#327: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:313:
+			       0, tim_ring->nb_bkts, tim_ring->chunk_sz,

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#336: FILE: drivers/event/cnxk/cnxk_tim_evdev.c:589:
+	rte_kvargs_process(kvlist, CNXK_TIM_EXT_CLK, &parse_kvargs_long,

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#349: FILE: drivers/event/cnxk/cnxk_tim_evdev.h:43:
+#define CNXK_TIM_EXT_CLK     "tim_ext_clk"

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#349: FILE: drivers/event/cnxk/cnxk_tim_evdev.h:43:
+#define CNXK_TIM_EXT_CLK     "tim_ext_clk"

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#366: FILE: drivers/event/cnxk/cnxk_tim_evdev.h:193:
+						     ROC_TIM_CLK_SRC_GTI;

WARNING:TYPO_SPELLING: 'TIM' may be misspelled - perhaps 'TIME'?
#368: FILE: drivers/event/cnxk/cnxk_tim_evdev.h:195:
+		return ROC_TIM_CLK_SRC_GPIO;

total: 0 errors, 38 warnings, 231 lines checked

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dpdk-test-report] |WARNING| pw98939 [PATCH] [v2] drivers: add external clock support for cnxk timer
@ 2021-09-15 17:23 dpdklab
  0 siblings, 0 replies; 2+ messages in thread
From: dpdklab @ 2021-09-15 17:23 UTC (permalink / raw)
  To: test-report; +Cc: dpdk-test-reports

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/98939

_apply patch failure_

Submitter: Shijith Thotton <sthotton@marvell.com>
Date: Wednesday, September 15 2021 16:03:27 
Applied on: CommitID:1c91ed5cdde164ca319c2c3b0ba5b4643db8e614
Apply patch set 98939 failed:

Checking patch doc/guides/eventdevs/cnxk.rst...
Checking patch drivers/common/cnxk/roc_platform.h...
Checking patch drivers/common/cnxk/roc_tim.h...
Checking patch drivers/event/cnxk/cnxk_eventdev.h...
Hunk #1 succeeded at 211 (offset 11 lines).
Checking patch drivers/event/cnxk/cnxk_tim_evdev.c...
Checking patch drivers/event/cnxk/cnxk_tim_evdev.h...
Hunk #1 succeeded at 39 (offset -1 lines).
error: while searching for:
	uint32_t min_ring_cnt;
	uint8_t enable_stats;
	uint16_t ring_ctl_cnt;
	struct cnxk_tim_ctl *ring_ctl_data;
};


error: patch failed: drivers/event/cnxk/cnxk_tim_evdev.h:95
Hunk #3 succeeded at 188 (offset -2 lines).
Applied patch doc/guides/eventdevs/cnxk.rst cleanly.
Applied patch drivers/common/cnxk/roc_platform.h cleanly.
Applied patch drivers/common/cnxk/roc_tim.h cleanly.
Applied patch drivers/event/cnxk/cnxk_eventdev.h cleanly.
Applied patch drivers/event/cnxk/cnxk_tim_evdev.c cleanly.
Applying patch drivers/event/cnxk/cnxk_tim_evdev.h with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
diff a/drivers/event/cnxk/cnxk_tim_evdev.h b/drivers/event/cnxk/cnxk_tim_evdev.h	(rejected hunks)
@@ -95,6 +96,7 @@ struct cnxk_tim_evdev {
 	uint32_t min_ring_cnt;
 	uint8_t enable_stats;
 	uint16_t ring_ctl_cnt;
+	uint64_t ext_clk_frq;
 	struct cnxk_tim_ctl *ring_ctl_data;
 };
 

https://lab.dpdk.org/results/dashboard/patchsets/18773/

UNH-IOL DPDK Community Lab

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-15 17:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <abba6d4e9e332734b767596ac5a8bc482b68d6ac.1631721608.git.sthotton@marvell.com>
2021-09-15 16:07 ` [dpdk-test-report] |WARNING| pw98939 [PATCH v2] drivers: add external clock support for cnxk timer checkpatch
2021-09-15 17:23 [dpdk-test-report] |WARNING| pw98939 [PATCH] [v2] " dpdklab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).