[dpdk-test-report] |WARNING| pw99408-99409 [PATCH] [v3, 2/2] vhost: add thread-safe API for clearing in-flight packets in async vhost

[dpdklab@iol.unh.edu]

[-- Attachment #1: Type: text/plain, Size: 3795 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/99408

_apply patch failure_

Submitter: Yuan Wang <yuanx.wang@intel.com>
Date: Wednesday, September 22 2021 08:55:46 
Applied on: CommitID:ccf69617ce96e1b708c7644289ee8df4586f7556
Apply patch set 99408-99409 failed:

Checking patch doc/guides/prog_guide/vhost_lib.rst...
error: while searching for:

* ``rte_vhost_clear_queue_thread_unsafe(vid, queue_id, **pkts, count)``

  Clear inflight packets which are submitted to DMA engine in vhost async data
  path. Completed packets are returned to applications through ``pkts``.

* ``rte_vhost_async_try_dequeue_burst(vid, queue_id, mbuf_pool, pkts, count, nr_inflight)``

error: patch failed: doc/guides/prog_guide/vhost_lib.rst:300
Checking patch lib/vhost/rte_vhost_async.h...
error: while searching for:
__rte_experimental
uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, uint16_t queue_id,
		struct rte_mbuf **pkts, uint16_t count);
/**
 * This function tries to receive packets from the guest with offloading
 * copies to the async channel. The packets that are transfer completed

error: patch failed: lib/vhost/rte_vhost_async.h:261
Checking patch lib/vhost/version.map...
error: while searching for:

	# added in 21.11
	rte_vhost_async_try_dequeue_burst;
};

error: patch failed: lib/vhost/version.map:88
Checking patch lib/vhost/virtio_net.c...
Applying patch doc/guides/prog_guide/vhost_lib.rst with 1 reject...
Rejected hunk #1.
Applying patch lib/vhost/rte_vhost_async.h with 1 reject...
Rejected hunk #1.
Applying patch lib/vhost/version.map with 1 reject...
Rejected hunk #1.
Applied patch lib/vhost/virtio_net.c cleanly.
diff a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst	(rejected hunks)
@@ -300,7 +300,13 @@ The following is an overview of some key Vhost API functions:
 
 * ``rte_vhost_clear_queue_thread_unsafe(vid, queue_id, **pkts, count)``
 
-  Clear inflight packets which are submitted to DMA engine in vhost async data
+  Clear in-flight packets which are submitted to async channel in vhost
+  async data path without performing any locking. Completed packets are
+  returned to applications through ``pkts``.
+
+* ``rte_vhost_clear_queue(vid, queue_id, **pkts, count)``
+
+  Clear in-flight packets which are submitted to async channel in vhost async data
   path. Completed packets are returned to applications through ``pkts``.
 
 * ``rte_vhost_async_try_dequeue_burst(vid, queue_id, mbuf_pool, pkts, count, nr_inflight)``
diff a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h	(rejected hunks)
@@ -261,6 +261,27 @@ int rte_vhost_async_get_inflight(int vid, uint16_t queue_id);
 __rte_experimental
 uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, uint16_t queue_id,
 		struct rte_mbuf **pkts, uint16_t count);
+
+/**
+ * This function checks async completion status and clear packets for
+ * a specific vhost device queue. Packets which are inflight will be
+ * returned in an array.
+ *
+ * @param vid
+ *  ID of vhost device to clear data
+ * @param queue_id
+ *  Queue id to clear data
+ * @param pkts
+ *  Blank array to get return packet pointer
+ * @param count
+ *  Size of the packet array
+ * @return
+ *  Number of packets returned
+ */
+__rte_experimental
+uint16_t rte_vhost_clear_queue(int vid, uint16_t queue_id,
+		struct rte_mbuf **pkts, uint16_t count);
+
 /**
  * This function tries to receive packets from the guest with offloading
  * copies to the async channel. The packets that are transfer completed
diff a/lib/vhost/version.map b/lib/vhost/version.map	(rejected hunks)
@@ -88,4 +88,5 @@ EXPERIMENTAL {
 
 	# added in 21.11
 	rte_vhost_async_try_dequeue_burst;
+	rte_vhost_clear_queue;
 };

https://lab.dpdk.org/results/dashboard/patchsets/18890/

UNH-IOL DPDK Community Lab