[dpdk-test-report] |WARNING| pw99799 [PATCH 02/19] net/mlx5: stub for FreeBSD

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Srikanth Kaka <srikanth.k@oneconvergence.com>
Subject: [dpdk-test-report] |WARNING| pw99799 [PATCH 02/19] net/mlx5: stub for FreeBSD
Date: Mon, 27 Sep 2021 16:59:57 +0200 (CEST)	[thread overview]
Message-ID: <20210927145957.8250C1206FE@dpdk.org> (raw)
In-Reply-To: <20210927133450.10653-3-srikanth.k@oneconvergence.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/99799

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseKR4_Full>
#158: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:47:
+#ifndef HAVE_SUPPORTED_40000baseKR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseKR4_Full>
#159: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:48:
+#define SUPPORTED_40000baseKR4_Full (1 << 23)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseCR4_Full>
#161: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:50:
+#ifndef HAVE_SUPPORTED_40000baseCR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseCR4_Full>
#162: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:51:
+#define SUPPORTED_40000baseCR4_Full (1 << 24)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseSR4_Full>
#164: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:53:
+#ifndef HAVE_SUPPORTED_40000baseSR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseSR4_Full>
#165: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:54:
+#define SUPPORTED_40000baseSR4_Full (1 << 25)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_40000baseLR4_Full>
#167: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:56:
+#ifndef HAVE_SUPPORTED_40000baseLR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_40000baseLR4_Full>
#168: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:57:
+#define SUPPORTED_40000baseLR4_Full (1 << 26)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseKR4_Full>
#170: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:59:
+#ifndef HAVE_SUPPORTED_56000baseKR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseKR4_Full>
#171: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:60:
+#define SUPPORTED_56000baseKR4_Full (1 << 27)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseCR4_Full>
#173: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:62:
+#ifndef HAVE_SUPPORTED_56000baseCR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseCR4_Full>
#174: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:63:
+#define SUPPORTED_56000baseCR4_Full (1 << 28)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseSR4_Full>
#176: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:65:
+#ifndef HAVE_SUPPORTED_56000baseSR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseSR4_Full>
#177: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:66:
+#define SUPPORTED_56000baseSR4_Full (1 << 29)

CHECK:CAMELCASE: Avoid CamelCase: <HAVE_SUPPORTED_56000baseLR4_Full>
#179: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:68:
+#ifndef HAVE_SUPPORTED_56000baseLR4_Full

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_56000baseLR4_Full>
#180: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:69:
+#define SUPPORTED_56000baseLR4_Full (1 << 30)

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_1000baseT_Full_BIT>
#202: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:91:
+#define ETHTOOL_LINK_MODE_1000baseT_Full_BIT 5

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_Autoneg_BIT>
#203: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:92:
+#define ETHTOOL_LINK_MODE_Autoneg_BIT 6

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_1000baseKX_Full_BIT>
#204: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:93:
+#define ETHTOOL_LINK_MODE_1000baseKX_Full_BIT 17

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT>
#205: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:94:
+#define ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT 18

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseKR_Full_BIT>
#206: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:95:
+#define ETHTOOL_LINK_MODE_10000baseKR_Full_BIT 19

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_10000baseR_FEC_BIT>
#207: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:96:
+#define ETHTOOL_LINK_MODE_10000baseR_FEC_BIT 20

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT>
#208: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:97:
+#define ETHTOOL_LINK_MODE_20000baseMLD2_Full_BIT 21

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT>
#209: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:98:
+#define ETHTOOL_LINK_MODE_20000baseKR2_Full_BIT 22

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT>
#210: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:99:
+#define ETHTOOL_LINK_MODE_40000baseKR4_Full_BIT 23

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT>
#211: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:100:
+#define ETHTOOL_LINK_MODE_40000baseCR4_Full_BIT 24

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT>
#212: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:101:
+#define ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT 25

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT>
#213: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:102:
+#define ETHTOOL_LINK_MODE_40000baseLR4_Full_BIT 26

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT>
#214: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:103:
+#define ETHTOOL_LINK_MODE_56000baseKR4_Full_BIT 27

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT>
#215: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:104:
+#define ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT 28

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT>
#216: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:105:
+#define ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT 29

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT>
#217: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:106:
+#define ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT 30

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseCR_Full_BIT>
#220: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:109:
+#define ETHTOOL_LINK_MODE_25000baseCR_Full_BIT 31

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseKR_Full_BIT>
#221: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:110:
+#define ETHTOOL_LINK_MODE_25000baseKR_Full_BIT 32

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_25000baseSR_Full_BIT>
#222: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:111:
+#define ETHTOOL_LINK_MODE_25000baseSR_Full_BIT 33

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT>
#225: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:114:
+#define ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT 34

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT>
#226: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:115:
+#define ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT 35

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT>
#229: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:118:
+#define ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT 36

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT>
#230: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:119:
+#define ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT 37

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT>
#231: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:120:
+#define ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT 38

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT>
#232: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:121:
+#define ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT 39

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseKR4_Full_BIT>
#235: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:124:
+#define ETHTOOL_LINK_MODE_200000baseKR4_Full_BIT 62

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseSR4_Full_BIT>
#236: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:125:
+#define ETHTOOL_LINK_MODE_200000baseSR4_Full_BIT 63

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseLR4_ER4_FR4_Full_BIT>
#237: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:126:
+#define ETHTOOL_LINK_MODE_200000baseLR4_ER4_FR4_Full_BIT 0 /* 64 - 64 */

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT>
#238: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:127:
+#define ETHTOOL_LINK_MODE_200000baseDR4_Full_BIT 1 /* 65 - 64 */

CHECK:CAMELCASE: Avoid CamelCase: <ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT>
#239: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:128:
+#define ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT 2 /* 66 - 64 */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#275: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:164:
+	if (priv->master && priv->sh->bond.ifindex > 0) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#453: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:342:
+ * Retrieve the master device for representor in the same switch domain.

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#459: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:348:
+ *   Master device structure  on success, NULL otherwise.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#462: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:351:
+mlx5_find_master_dev(struct rte_eth_dev *dev)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#475: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:364:
+		    opriv->master &&

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#514: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:403:
+		.link_status = ((ifr.ifr_flags & IFF_UP) &&

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#515: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:404:
+				(ifr.ifr_flags & IFF_RUNNING)),

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#523: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:412:
+			struct rte_eth_dev *master;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#527: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:416:
+			 * settings from the master device. Actually

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#535: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:424:
+			master = mlx5_find_master_dev(dev);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#535: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:424:
+			master = mlx5_find_master_dev(dev);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#536: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:425:
+			if (master) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#540: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:429:
+				ret = mlx5_ifreq(master, SIOCETHTOOL, &ifr);

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseT_Full>
#557: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:446:
+	if (edata.supported & (SUPPORTED_1000baseT_Full |

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_1000baseKX_Full>
#558: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:447:
+			       SUPPORTED_1000baseKX_Full))

CHECK:CAMELCASE: Avoid CamelCase: <SUPPORTED_10000baseKR_Full>
#560: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:449:
+	if (edata.supported & SUPPORTED_10000baseKR_Full)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#595: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:484:
+	struct rte_eth_dev *master = NULL;

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#606: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:495:
+		.link_status = ((ifr.ifr_flags & IFF_UP) &&

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#607: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:496:
+				(ifr.ifr_flags & IFF_RUNNING)),

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#617: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:506:
+			 * settings from the master device. Actually

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#625: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:514:
+			master = mlx5_find_master_dev(dev);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#625: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:514:
+			master = mlx5_find_master_dev(dev);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#626: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:515:
+			if (master) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#630: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:519:
+				ret = mlx5_ifreq(master, SIOCETHTOOL, &ifr);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#650: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:539:
+	ret = mlx5_ifreq(master ? master : dev, SIOCETHTOOL, &ifr);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#650: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:539:
+	ret = mlx5_ifreq(master ? master : dev, SIOCETHTOOL, &ifr);

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#1071: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:960:
+	return mlx5_set_flags(dev, ~IFF_UP, ~IFF_UP);

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#1071: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:960:
+	return mlx5_set_flags(dev, ~IFF_UP, ~IFF_UP);

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#1086: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:975:
+	return mlx5_set_flags(dev, ~IFF_UP, IFF_UP);

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#1086: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:975:
+	return mlx5_set_flags(dev, ~IFF_UP, IFF_UP);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1110: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:999:
+ * Analyze gathered port parameters via sysfs to recognize master

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#1115: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1004:
+ * @param[inout] switch_info

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1120: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1009:
+ *   master and representor flags are set in switch_info according to

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1130: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1019:
+		 * Name is not recognized, assume the master,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1133: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1022:
+		switch_info->master = device_dir;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1138: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1027:
+		 * schema for master, just check if there is

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1141: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1030:
+		switch_info->master = device_dir;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1145: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1034:
+		switch_info->master = 1;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1160: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1049:
+		switch_info->master = device_dir;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1183: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1072:
+		.master = 0,

CHECK:CAMELCASE: Avoid CamelCase: <SCNx64>
#1220: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1109:
+		fscanf(file, "%" SCNx64 "%c", &data.switch_id, &c) == 2 &&

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1233: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1122:
+	MLX5_ASSERT(!(data.master && data.representor));

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1234: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1123:
+	if (data.master && data.representor) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1235: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1124:
+		DRV_LOG(ERR, "ifindex %u device is recognized as master"

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1247: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1136:
+ *   Network interface index of bond slave interface

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1269: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1158:
+	MKSTR(bond_if, "/sys/class/net/%s/master/ifindex", name);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1452: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1341:
+	if (priv->master && priv->pf_bond >= 0) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1497: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1386:
+	if (priv->master && priv->pf_bond >= 0)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1673: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1562:
+	if (priv->master && priv->pf_bond >= 0)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#1674: FILE: drivers/net/mlx5/freebsd/mlx5_ethdev_os.c:1563:
+		/* Bonding master. */

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2231: FILE: drivers/net/mlx5/freebsd/mlx5_flow_os.h:438:
+	*action = mlx5_glue->dr_create_flow_action_dest_array(

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#3438: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:844:
+						 .wq_state = IBV_WQS_RDY,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3667: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1073:
+		if (switch_info->master || switch_info->representor)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3799: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1205:
+	priv->master = !!switch_info->master;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3799: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1205:
+	priv->master = !!switch_info->master;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3806: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1212:
+		"dev_port=%u bus=%s pci=%s master=%d representor=%d pf_bond=%d
",

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3809: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1215:
+		priv->master, priv->representor, priv->pf_bond);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3817: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1223:
+	if (switch_info->representor || switch_info->master) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#3854: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1260:
+		   (switch_info->representor || switch_info->master)) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4361: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1767:
+	      (switch_info->representor || switch_info->master)))

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#4560: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1966:
+	/* Master device first. */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4561: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1967:
+	ret = si_b->master - si_a->master;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4561: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1967:
+	ret = si_b->master - si_a->master;

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#4576: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1982:
+ * Match PCI information for possible slaves of bonding device.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#4591: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:1997:
+ *   positive index of slave PF in bonding.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4607: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2013:
+	 * Try to get master device name. If something goes

WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'?
#4620: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2026:
+	 * The Master device might not be on the predefined

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4623: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2029:
+	 * find master.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#4632: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2038:
+		/* Try to read bonding slave names from sysfs. */

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#4633: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2039:
+		MKSTR(slaves,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4634: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2040:
+		      "/sys/class/net/%s/master/bonding/slaves", ifname);

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#4634: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2040:
+		      "/sys/class/net/%s/master/bonding/slaves", ifname);

WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#4635: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2041:
+		bond_file = fopen(slaves, "r");

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#4648: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2054:
+		/* Process slave interface names in the loop. */

WARNING:TYPO_SPELLING: 'Slave' may be misspelled - perhaps 'Secondary'?
#4656: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2062:
+		/* Slave interface PCI address match found. */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4764: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2170:
+	 * PCI device and we have representors and master.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#4782: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2188:
+	 *  >= 0 - bonding device (value is slave PF index)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#4836: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2242:
+				      " slave %d bonding device \"%s\"",

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#4840: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2246:
+			break;
+		} else {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4903: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2309:
+		 * it may be E-Switch master device and representors.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4939: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2345:
+				    !list[ns].info.master)) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4958: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2364:
+						list[ns].info.master = 0;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4978: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2384:
+				     list[ns].info.master))

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#4983: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2389:
+				"unable to recognize master/representors"

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5032: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2438:
+				 * master device only.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5038: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2444:
+					 * master/representor and retrieve

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5053: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2459:
+					 * nor master.

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5065: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2471:
+				    !list[ns].info.master)) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5076: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2482:
+				     list[ns].info.master)) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5080: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2486:
+				   !list[ns].info.master) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5095: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2501:
+				"unable to recognize master/representors"

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5104: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2510:
+		 * only device as master. Override this if there is the

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5110: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2516:
+			list[0].info.master = 0;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#5117: FILE: drivers/net/mlx5/freebsd/mlx5_os.c:2523:
+	 * (i.e. master first, then representors from lowest to highest ID).

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#6522: FILE: drivers/net/mlx5/freebsd/mlx5_verbs.c:429:
+	ret = mlx5_ibv_modify_wq(tmpl, IBV_WQS_RDY);

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#6525: FILE: drivers/net/mlx5/freebsd/mlx5_verbs.c:432:
+			"Port %u Rx queue %u WQ state to IBV_WQS_RDY failed.",

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#7128: FILE: drivers/net/mlx5/freebsd/mlx5_verbs.c:1035:
+		DRV_LOG(DEBUG, "Port %u: uar_mmap_offset 0x%" PRIx64 ".",

total: 0 errors, 91 warnings, 52 checks, 7166 lines checked

          parent reply	other threads:[~2021-09-27 14:59 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210927133450.10653-3-srikanth.k@oneconvergence.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927145957.8250C1206FE@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=srikanth.k@oneconvergence.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).