From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 799B4A0032
	for <public@inbox.dpdk.org>; Tue, 28 Sep 2021 10:52:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6986D410D7;
	Tue, 28 Sep 2021 10:52:40 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 074D240E3C
 for <test-report@dpdk.org>; Tue, 28 Sep 2021 10:52:39 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id E094A1206FE; Tue, 28 Sep 2021 10:52:38 +0200 (CEST)
In-Reply-To: <20210928085114.30737-1-david.marchand@redhat.com>
References: <20210928085114.30737-1-david.marchand@redhat.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Message-Id: <20210928085238.E094A1206FE@dpdk.org>
Date: Tue, 28 Sep 2021 10:52:38 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw99870 [PATCH v2] net/virtio: fix
 virtio-user init when using existing tap
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/99870

_coding style issues_


WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#172: FILE: drivers/net/virtio/virtio_user/vhost_kernel.c:143:
+	if (tap_flags & IFF_VNET_HDR) {

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#181: FILE: drivers/net/virtio/virtio_user/vhost_kernel.c:151:
+	if (tap_flags & IFF_MULTI_QUEUE)

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#201: FILE: drivers/net/virtio/virtio_user/vhost_kernel.c:393:
+	if ((tap_features & IFF_VNET_HDR) == 0) {

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#202: FILE: drivers/net/virtio/virtio_user/vhost_kernel.c:394:
+		PMD_INIT_LOG(ERR, "TAP does not support IFF_VNET_HDR");

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#217: FILE: drivers/net/virtio/virtio_user/vhost_kernel.c:432:
+	data->tapfds[0] = tap_open(ifname, (tap_features & IFF_MULTI_QUEUE) != 0);

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#228: FILE: drivers/net/virtio/virtio_user/vhost_kernel.c:443:
+	if ((tap_flags & IFF_MULTI_QUEUE) == 0 && dev->max_queue_pairs > 1) {

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#351: FILE: drivers/net/virtio/virtio_user/vhost_kernel_tap.c:64:
+	ifr.ifr_flags = IFF_TAP | IFF_NO_PI | IFF_VNET_HDR;

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#351: FILE: drivers/net/virtio/virtio_user/vhost_kernel_tap.c:64:
+	ifr.ifr_flags = IFF_TAP | IFF_NO_PI | IFF_VNET_HDR;

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#351: FILE: drivers/net/virtio/virtio_user/vhost_kernel_tap.c:64:
+	ifr.ifr_flags = IFF_TAP | IFF_NO_PI | IFF_VNET_HDR;

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#353: FILE: drivers/net/virtio/virtio_user/vhost_kernel_tap.c:66:
+		ifr.ifr_flags |= IFF_MULTI_QUEUE;

WARNING:TYPO_SPELLING: 'IFF' may be misspelled - perhaps 'IF'?
#357: FILE: drivers/net/virtio/virtio_user/vhost_kernel_tap.c:70:
+				"TUNSETIFF failed (will retry without IFF_MULTI_QUEUE): %s",

total: 0 errors, 11 warnings, 0 checks, 412 lines checked