automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [dpdk-test-report] |WARNING| pw100168 [RFC] mempool: implement index-based per core cache
Date: Thu, 30 Sep 2021 19:28:42 +0200 (CEST)	[thread overview]
Message-ID: <20210930172842.524031206FE@dpdk.org> (raw)
In-Reply-To: <20210930172735.2675627-1-dharmik.thakkar@arm.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100168

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#62: 
Future plan involves replacing global pool's pointer-based implementation with index-based implementation

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#92: FILE: lib/mempool/rte_mempool.c:483:
+	unsigned lcore_id;

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#201: FILE: lib/mempool/rte_mempool.h:1333:
+	for (i = 0; i < (n & ~0x1); i+=2) {
 	                             ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#206: FILE: lib/mempool/rte_mempool.h:1338:
+	if (n & 0x1) {
+		cache_objs[i] = (uint32_t) RTE_PTR_DIFF(obj_table[i], base_value);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#210: FILE: lib/mempool/rte_mempool.h:1342:
+	for (i = 0; i < n; i++) {
+		cache_objs[i] = (uint32_t) RTE_PTR_DIFF(obj_table[i], base_value);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#257: FILE: lib/mempool/rte_mempool.h:1482:
+		for (i = 0; i < req; ++i, ++len) {
+			cache_objs[len] = (uint32_t) RTE_PTR_DIFF(temp_objs[i], base_value);
+		}

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#270: FILE: lib/mempool/rte_mempool.h:1495:
+	for (index = 0, len = cache->len - 1; index < (n & ~0x1); index+=2,
 	                                                               ^

ERROR:SPACING: spaces required around that '-=' (ctx:VxV)
#271: FILE: lib/mempool/rte_mempool.h:1496:
+						len-=2, obj_table+=2) {
 						   ^

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#271: FILE: lib/mempool/rte_mempool.h:1496:
+						len-=2, obj_table+=2) {
 						                 ^

total: 4 errors, 5 warnings, 190 lines checked

           reply	other threads:[~2021-09-30 17:28 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210930172735.2675627-1-dharmik.thakkar@arm.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210930172842.524031206FE@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=dharmik.thakkar@arm.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).