From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F06D5A0C43
	for <public@inbox.dpdk.org>; Thu, 30 Sep 2021 19:28:43 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E6FF6410E5;
	Thu, 30 Sep 2021 19:28:43 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8210B4067E
 for <test-report@dpdk.org>; Thu, 30 Sep 2021 19:28:42 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 524031206FE; Thu, 30 Sep 2021 19:28:42 +0200 (CEST)
In-Reply-To: <20210930172735.2675627-1-dharmik.thakkar@arm.com>
References: <20210930172735.2675627-1-dharmik.thakkar@arm.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Dharmik Thakkar <dharmik.thakkar@arm.com>
Message-Id: <20210930172842.524031206FE@dpdk.org>
Date: Thu, 30 Sep 2021 19:28:42 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw100168 [RFC] mempool: implement
 index-based per core cache
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100168

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#62: 
Future plan involves replacing global pool's pointer-based implementation with index-based implementation

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#92: FILE: lib/mempool/rte_mempool.c:483:
+	unsigned lcore_id;

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#201: FILE: lib/mempool/rte_mempool.h:1333:
+	for (i = 0; i < (n & ~0x1); i+=2) {
 	                             ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#206: FILE: lib/mempool/rte_mempool.h:1338:
+	if (n & 0x1) {
+		cache_objs[i] = (uint32_t) RTE_PTR_DIFF(obj_table[i], base_value);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#210: FILE: lib/mempool/rte_mempool.h:1342:
+	for (i = 0; i < n; i++) {
+		cache_objs[i] = (uint32_t) RTE_PTR_DIFF(obj_table[i], base_value);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#257: FILE: lib/mempool/rte_mempool.h:1482:
+		for (i = 0; i < req; ++i, ++len) {
+			cache_objs[len] = (uint32_t) RTE_PTR_DIFF(temp_objs[i], base_value);
+		}

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#270: FILE: lib/mempool/rte_mempool.h:1495:
+	for (index = 0, len = cache->len - 1; index < (n & ~0x1); index+=2,
 	                                                               ^

ERROR:SPACING: spaces required around that '-=' (ctx:VxV)
#271: FILE: lib/mempool/rte_mempool.h:1496:
+						len-=2, obj_table+=2) {
 						   ^

ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#271: FILE: lib/mempool/rte_mempool.h:1496:
+						len-=2, obj_table+=2) {
 						                 ^

total: 4 errors, 5 warnings, 190 lines checked