* [dpdk-test-report] |WARNING| pw100168 [RFC] mempool: implement index-based per core cache
[not found] <20210930172735.2675627-1-dharmik.thakkar@arm.com>
@ 2021-09-30 17:28 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-09-30 17:28 UTC (permalink / raw)
To: test-report; +Cc: Dharmik Thakkar
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100168
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#62:
Future plan involves replacing global pool's pointer-based implementation with index-based implementation
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#92: FILE: lib/mempool/rte_mempool.c:483:
+ unsigned lcore_id;
ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#201: FILE: lib/mempool/rte_mempool.h:1333:
+ for (i = 0; i < (n & ~0x1); i+=2) {
^
WARNING:BRACES: braces {} are not necessary for single statement blocks
#206: FILE: lib/mempool/rte_mempool.h:1338:
+ if (n & 0x1) {
+ cache_objs[i] = (uint32_t) RTE_PTR_DIFF(obj_table[i], base_value);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#210: FILE: lib/mempool/rte_mempool.h:1342:
+ for (i = 0; i < n; i++) {
+ cache_objs[i] = (uint32_t) RTE_PTR_DIFF(obj_table[i], base_value);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#257: FILE: lib/mempool/rte_mempool.h:1482:
+ for (i = 0; i < req; ++i, ++len) {
+ cache_objs[len] = (uint32_t) RTE_PTR_DIFF(temp_objs[i], base_value);
+ }
ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#270: FILE: lib/mempool/rte_mempool.h:1495:
+ for (index = 0, len = cache->len - 1; index < (n & ~0x1); index+=2,
^
ERROR:SPACING: spaces required around that '-=' (ctx:VxV)
#271: FILE: lib/mempool/rte_mempool.h:1496:
+ len-=2, obj_table+=2) {
^
ERROR:SPACING: spaces required around that '+=' (ctx:VxV)
#271: FILE: lib/mempool/rte_mempool.h:1496:
+ len-=2, obj_table+=2) {
^
total: 4 errors, 5 warnings, 190 lines checked
^ permalink raw reply [flat|nested] only message in thread