automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <pbhagavatula@marvell.com>
Subject: [dpdk-test-report] |WARNING| pw100432 [PATCH v2] test: add reassembly perf test
Date: Mon,  4 Oct 2021 15:34:48 +0200 (CEST)	[thread overview]
Message-ID: <20211004133448.082B1120DFE@dpdk.org> (raw)
In-Reply-To: <20211004133356.14704-1-pbhagavatula@marvell.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100432

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:TYPO_SPELLING: 'vairable' may be misspelled - perhaps 'variable'?
#76: 
Each test is performed with vairable number of fragments per flow,

WARNING:TYPO_SPELLING: 'unorderd' may be misspelled - perhaps 'unordered'?
#77: 
either ordered or unorderd fragments and interleaved flows.

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#137: FILE: app/test/test_reassembly_perf.c:19:
+#define MAX_FLOWS	    1024 * 32

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#142: FILE: app/test/test_reassembly_perf.c:24:
+#define MAX_PKTS	    MAX_FLOWS *MAX_FRAGMENTS
                 	              ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#142: FILE: app/test/test_reassembly_perf.c:24:
+#define MAX_PKTS	    MAX_FLOWS *MAX_FRAGMENTS

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#145: FILE: app/test/test_reassembly_perf.c:27:
+#define MAX_TTL_MS  5 * MS_PER_S

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#152: FILE: app/test/test_reassembly_perf.c:34:
+#define IP_SRC_ADDR(x) (198U << 24) | (18 << 16) | (0 << 8) | x

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#153: FILE: app/test/test_reassembly_perf.c:35:
+#define IP_DST_ADDR(x) (198U << 24) | (18 << 16) | (1 << 8) | x

total: 6 errors, 2 warnings, 1005 lines checked

       reply	other threads:[~2021-10-04 13:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211004133356.14704-1-pbhagavatula@marvell.com>
2021-10-04 13:34 ` checkpatch [this message]
2021-10-04 14:01 ` [dpdk-test-report] |SUCCESS| pw100432 [dpdk-dev] " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004133448.082B1120DFE@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=pbhagavatula@marvell.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).