From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3D149A0C4D
	for <public@inbox.dpdk.org>; Mon,  4 Oct 2021 15:34:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2D9A54130A;
	Mon,  4 Oct 2021 15:34:49 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 34ABF412F7
 for <test-report@dpdk.org>; Mon,  4 Oct 2021 15:34:48 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 082B1120DFE; Mon,  4 Oct 2021 15:34:48 +0200 (CEST)
In-Reply-To: <20211004133356.14704-1-pbhagavatula@marvell.com>
References: <20211004133356.14704-1-pbhagavatula@marvell.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: <pbhagavatula@marvell.com>
Message-Id: <20211004133448.082B1120DFE@dpdk.org>
Date: Mon,  4 Oct 2021 15:34:48 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw100432 [PATCH v2] test: add
 reassembly perf test
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/100432

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:TYPO_SPELLING: 'vairable' may be misspelled - perhaps 'variable'?
#76: 
Each test is performed with vairable number of fragments per flow,

WARNING:TYPO_SPELLING: 'unorderd' may be misspelled - perhaps 'unordered'?
#77: 
either ordered or unorderd fragments and interleaved flows.

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#137: FILE: app/test/test_reassembly_perf.c:19:
+#define MAX_FLOWS	    1024 * 32

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#142: FILE: app/test/test_reassembly_perf.c:24:
+#define MAX_PKTS	    MAX_FLOWS *MAX_FRAGMENTS
                 	              ^

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#142: FILE: app/test/test_reassembly_perf.c:24:
+#define MAX_PKTS	    MAX_FLOWS *MAX_FRAGMENTS

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#145: FILE: app/test/test_reassembly_perf.c:27:
+#define MAX_TTL_MS  5 * MS_PER_S

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#152: FILE: app/test/test_reassembly_perf.c:34:
+#define IP_SRC_ADDR(x) (198U << 24) | (18 << 16) | (0 << 8) | x

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#153: FILE: app/test/test_reassembly_perf.c:35:
+#define IP_DST_ADDR(x) (198U << 24) | (18 << 16) | (1 << 8) | x

total: 6 errors, 2 warnings, 1005 lines checked