From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: [dpdk-test-report] |WARNING| pw99928 [PATCH] [v4] efd: change data type of parameter
Date: Tue, 5 Oct 2021 16:13:33 -0400 (EDT) [thread overview]
Message-ID: <20211005201333.51BC16D535@noxus.dpdklab.iol.unh.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 4205 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/99928
_apply patch failure_
Submitter: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
Date: Tuesday, September 28 2021 13:58:39
Applied on: CommitID:086d426406bd3f6fac96a15bbd871c7fe714bc2d
Apply patch set 99928 failed:
Checking patch app/test/test_efd.c...
error: while searching for:
/* Array to store the data */
static efd_value_t data[5];
static inline uint8_t efd_get_all_sockets_bitmask(void)
{
uint8_t all_cpu_sockets_bitmask = 0;
unsigned int i;
unsigned int next_lcore = rte_get_main_lcore();
const int val_true = 1, val_false = 0;
error: patch failed: app/test/test_efd.c:91
error: while searching for:
static int
test_efd(void)
{
/* Unit tests */
if (test_add_delete() < 0)
error: patch failed: app/test/test_efd.c:443
Checking patch app/test/test_efd_perf.c...
error: while searching for:
#endif
static unsigned int test_socket_id;
static inline uint8_t efd_get_all_sockets_bitmask(void)
{
uint8_t all_cpu_sockets_bitmask = 0;
unsigned int i;
unsigned int next_lcore = rte_get_main_lcore();
const int val_true = 1, val_false = 0;
error: patch failed: app/test/test_efd_perf.c:29
Checking patch lib/efd/rte_efd.c...
error: while searching for:
struct rte_efd_table *
rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)
{
struct rte_efd_table *table = NULL;
uint8_t *key_array = NULL;
error: patch failed: lib/efd/rte_efd.c:495
Checking patch lib/efd/rte_efd.h...
error: while searching for:
*/
struct rte_efd_table *
rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);
/**
* Releases the resources from an EFD table
error: patch failed: lib/efd/rte_efd.h:139
Applying patch app/test/test_efd.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
Applying patch app/test/test_efd_perf.c with 1 reject...
Rejected hunk #1.
Applying patch lib/efd/rte_efd.c with 1 reject...
Rejected hunk #1.
Applying patch lib/efd/rte_efd.h with 1 reject...
Rejected hunk #1.
diff a/app/test/test_efd.c b/app/test/test_efd.c (rejected hunks)
@@ -91,9 +91,9 @@ static struct flow_key keys[5] = {
/* Array to store the data */
static efd_value_t data[5];
-static inline uint8_t efd_get_all_sockets_bitmask(void)
+static inline uint64_t efd_get_all_sockets_bitmask(void)
{
- uint8_t all_cpu_sockets_bitmask = 0;
+ uint64_t all_cpu_sockets_bitmask = 0;
unsigned int i;
unsigned int next_lcore = rte_get_main_lcore();
const int val_true = 1, val_false = 0;
@@ -443,6 +443,7 @@ static int test_efd_creation_with_bad_parameters(void)
static int
test_efd(void)
{
+ test_socket_id = rte_socket_id();
/* Unit tests */
if (test_add_delete() < 0)
diff a/app/test/test_efd_perf.c b/app/test/test_efd_perf.c (rejected hunks)
@@ -29,9 +29,9 @@
#endif
static unsigned int test_socket_id;
-static inline uint8_t efd_get_all_sockets_bitmask(void)
+static inline uint64_t efd_get_all_sockets_bitmask(void)
{
- uint8_t all_cpu_sockets_bitmask = 0;
+ uint64_t all_cpu_sockets_bitmask = 0;
unsigned int i;
unsigned int next_lcore = rte_get_main_lcore();
const int val_true = 1, val_false = 0;
diff a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c (rejected hunks)
@@ -495,7 +495,7 @@ efd_search_hash(struct rte_efd_table * const table,
struct rte_efd_table *
rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
- uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)
+ uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)
{
struct rte_efd_table *table = NULL;
uint8_t *key_array = NULL;
diff a/lib/efd/rte_efd.h b/lib/efd/rte_efd.h (rejected hunks)
@@ -139,7 +139,7 @@ typedef uint16_t efd_hashfunc_t;
*/
struct rte_efd_table *
rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
- uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);
+ uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);
/**
* Releases the resources from an EFD table
https://lab.dpdk.org/results/dashboard/patchsets/19024/
UNH-IOL DPDK Community Lab
next reply other threads:[~2021-10-05 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 20:13 dpdklab [this message]
[not found] <20210928135839.3778960-1-pablo.de.lara.guarch@intel.com>
2021-09-28 14:00 ` [dpdk-test-report] |WARNING| pw99928 [PATCH v4] " checkpatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005201333.51BC16D535@noxus.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).