automatic DPDK test reports
 help / color / mirror / Atom feed
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: [dpdk-test-report] |WARNING| pw99836 [PATCH] bus/pci: fix unknown NUMA node value on Windows
Date: Wed,  6 Oct 2021 01:43:15 +0000 (UTC)	[thread overview]
Message-ID: <20211006014315.E513561CE7@dpdk-ubuntu.dpdklab.iol.unh.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/99836

_apply patch failure_

Submitter: Kadam, Pallavi <pallavi.kadam@intel.com>
Date: Monday, September 27 2021 18:43:22 
Applied on: CommitID:2700326085033fd13339a8de31f58a95d1ee9c3f
Apply patch set 99836 failed:

Checking patch drivers/bus/pci/windows/pci.c...
error: while searching for:
	}

	/* Get NUMA node using DEVPKEY_Device_Numa_Node */
	res = SetupDiGetDevicePropertyW(dev_info, dev_info_data,
		&DEVPKEY_Device_Numa_Node, &property_type,
		(BYTE *)&numa_node, sizeof(numa_node), NULL, 0);

error: patch failed: drivers/bus/pci/windows/pci.c:237
error: while searching for:
		DWORD error = GetLastError();
		if (error == ERROR_NOT_FOUND) {
			/* On older CPUs, NUMA is not bound to PCIe locality. */
			dev->device.numa_node = SOCKET_ID_ANY;
			return ERROR_SUCCESS;
		}
		RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"

error: patch failed: drivers/bus/pci/windows/pci.c:244
Applying patch drivers/bus/pci/windows/pci.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c	(rejected hunks)
@@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info,
 	}
 
 	/* Get NUMA node using DEVPKEY_Device_Numa_Node */
+	dev->device.numa_node = SOCKET_ID_ANY;
 	res = SetupDiGetDevicePropertyW(dev_info, dev_info_data,
 		&DEVPKEY_Device_Numa_Node, &property_type,
 		(BYTE *)&numa_node, sizeof(numa_node), NULL, 0);
@@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info,
 		DWORD error = GetLastError();
 		if (error == ERROR_NOT_FOUND) {
 			/* On older CPUs, NUMA is not bound to PCIe locality. */
-			dev->device.numa_node = SOCKET_ID_ANY;
+			dev->device.numa_node = 0;
 			return ERROR_SUCCESS;
 		}
 		RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"

https://lab.dpdk.org/results/dashboard/patchsets/18997/

UNH-IOL DPDK Community Lab

                 reply	other threads:[~2021-10-06  1:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006014315.E513561CE7@dpdk-ubuntu.dpdklab.iol.unh.edu \
    --to=dpdklab@iol.unh.edu \
    --cc=dpdk-test-reports@iol.unh.edu \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).