From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54716A0C43 for ; Fri, 8 Oct 2021 19:45:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 505884014F; Fri, 8 Oct 2021 19:45:27 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 3BB4B40143 for ; Fri, 8 Oct 2021 19:45:26 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 36CE0120E00; Fri, 8 Oct 2021 19:45:26 +0200 (CEST) In-Reply-To: <20211009015349.9694-6-eagostini@nvidia.com> References: <20211009015349.9694-6-eagostini@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Message-Id: <20211008174526.36CE0120E00@dpdk.org> Date: Fri, 8 Oct 2021 19:45:26 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw100832 [PATCH v3 5/9] gpudev: add memory API X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/100832 _coding style issues_ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #156: FILE: app/test-gpudev/main.c:68: + void * ptr_1 = NULL; ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #157: FILE: app/test-gpudev/main.c:69: + void * ptr_2 = NULL; ERROR:OPEN_BRACE: that open brace { should be on the previous line #165: FILE: app/test-gpudev/main.c:77: + if(ptr_1 == NULL) + { ERROR:SPACING: space required before the open parenthesis '(' #165: FILE: app/test-gpudev/main.c:77: + if(ptr_1 == NULL) ERROR:OPEN_BRACE: that open brace { should be on the previous line #173: FILE: app/test-gpudev/main.c:85: + if(ptr_2 == NULL) + { ERROR:SPACING: space required before the open parenthesis '(' #173: FILE: app/test-gpudev/main.c:85: + if(ptr_2 == NULL) ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #180: FILE: app/test-gpudev/main.c:92: + ret = rte_gpu_free(gpu_id, (uint8_t*)(ptr_1)+0x700); ERROR:OPEN_BRACE: that open brace { should be on the previous line #181: FILE: app/test-gpudev/main.c:93: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #181: FILE: app/test-gpudev/main.c:93: + if(ret < 0) WARNING:LONG_LINE: line length of 120 exceeds 100 columns #183: FILE: app/test-gpudev/main.c:95: + printf("GPU memory 0x%p + 0x700 NOT freed because of memory address not recognized by driver ", ptr_1); ERROR:OPEN_BRACE: that open brace { should be on the previous line #185: FILE: app/test-gpudev/main.c:97: + else + { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #185: FILE: app/test-gpudev/main.c:97: + } + else WARNING:TYPO_SPELLING: 'erroneusly' may be misspelled - perhaps 'erroneously'? #187: FILE: app/test-gpudev/main.c:99: + fprintf(stderr, "rte_gpu_free erroneusly freed GPU memory 0x%p + 0x700 ", ptr_1); ERROR:OPEN_BRACE: that open brace { should be on the previous line #192: FILE: app/test-gpudev/main.c:104: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #192: FILE: app/test-gpudev/main.c:104: + if(ret < 0) ERROR:OPEN_BRACE: that open brace { should be on the previous line #200: FILE: app/test-gpudev/main.c:112: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #200: FILE: app/test-gpudev/main.c:112: + if(ret < 0) ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #213: FILE: app/test-gpudev/main.c:125: + void * ptr = NULL; ERROR:OPEN_BRACE: that open brace { should be on the previous line #227: FILE: app/test-gpudev/main.c:139: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #227: FILE: app/test-gpudev/main.c:139: + if(ret < 0) ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #234: FILE: app/test-gpudev/main.c:146: + ret = rte_gpu_unregister(gpu_id, (uint8_t*)(ptr)+0x700); ERROR:OPEN_BRACE: that open brace { should be on the previous line #235: FILE: app/test-gpudev/main.c:147: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #235: FILE: app/test-gpudev/main.c:147: + if(ret < 0) WARNING:LONG_LINE: line length of 125 exceeds 100 columns #237: FILE: app/test-gpudev/main.c:149: + printf("CPU memory 0x%p + 0x700 NOT unregistered because of memory address not recognized by driver ", ptr); ERROR:OPEN_BRACE: that open brace { should be on the previous line #239: FILE: app/test-gpudev/main.c:151: + else + { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #239: FILE: app/test-gpudev/main.c:151: + } + else WARNING:TYPO_SPELLING: 'erroneusly' may be misspelled - perhaps 'erroneously'? #241: FILE: app/test-gpudev/main.c:153: + fprintf(stderr, "rte_gpu_free erroneusly freed GPU memory 0x%p + 0x700 ", ptr); ERROR:OPEN_BRACE: that open brace { should be on the previous line #247: FILE: app/test-gpudev/main.c:159: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #247: FILE: app/test-gpudev/main.c:159: + if(ret < 0) ERROR:OPEN_BRACE: that open brace { should be on the previous line #264: FILE: app/test-gpudev/main.c:206: + if(nb_gpus == 0) + { ERROR:SPACING: space required before the open parenthesis '(' #264: FILE: app/test-gpudev/main.c:206: + if(nb_gpus == 0) ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent #380: FILE: lib/gpudev/gpudev.c:553: + switch (ret) { + case 0: [...] + case -ENOMEM: + case -E2BIG: [...] + default: ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #394: FILE: lib/gpudev/gpudev.c:567: +rte_gpu_register(int16_t dev_id, size_t size, void * ptr) ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #418: FILE: lib/gpudev/gpudev.c:591: +rte_gpu_unregister(int16_t dev_id, void * ptr) ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #570: FILE: lib/gpudev/rte_gpudev.h:367: +int rte_gpu_register(int16_t dev_id, size_t size, void * ptr); total: 31 errors, 4 warnings, 425 lines checked