From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90C88A0C43 for ; Fri, 8 Oct 2021 19:45:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D0024014F; Fri, 8 Oct 2021 19:45:43 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 1511F40143 for ; Fri, 8 Oct 2021 19:45:42 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 0D03D120E00; Fri, 8 Oct 2021 19:45:42 +0200 (CEST) In-Reply-To: <20211009015349.9694-9-eagostini@nvidia.com> References: <20211009015349.9694-9-eagostini@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Message-Id: <20211008174542.0D03D120E00@dpdk.org> Date: Fri, 8 Oct 2021 19:45:42 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw100837 [PATCH v3 8/9] gpudev: add communication list X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/100837 _coding style issues_ ERROR:SPACING: space required before the open parenthesis '(' #187: FILE: app/test-gpudev/main.c:235: + if(comm_list_item == NULL) ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #205: FILE: app/test-gpudev/main.c:253: + struct rte_gpu_comm_list * comm_list; ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #207: FILE: app/test-gpudev/main.c:255: + struct rte_mbuf * mbufs[10]; ERROR:OPEN_BRACE: that open brace { should be on the previous line #212: FILE: app/test-gpudev/main.c:260: + if(comm_list == NULL) + { ERROR:SPACING: space required before the open parenthesis '(' #212: FILE: app/test-gpudev/main.c:260: + if(comm_list == NULL) ERROR:OPEN_BRACE: that open brace { should be on the previous line #221: FILE: app/test-gpudev/main.c:269: + for(i = 0; i < 10; i++) + { ERROR:SPACING: space required before the open parenthesis '(' #221: FILE: app/test-gpudev/main.c:269: + for(i = 0; i < 10; i++) ERROR:OPEN_BRACE: that open brace { should be on the previous line #236: FILE: app/test-gpudev/main.c:284: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #236: FILE: app/test-gpudev/main.c:284: + if(ret < 0) ERROR:OPEN_BRACE: that open brace { should be on the previous line #243: FILE: app/test-gpudev/main.c:291: + if(ret == 0) + { ERROR:SPACING: space required before the open parenthesis '(' #243: FILE: app/test-gpudev/main.c:291: + if(ret == 0) WARNING:TYPO_SPELLING: 'erroneusly' may be misspelled - perhaps 'erroneously'? #245: FILE: app/test-gpudev/main.c:293: + fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet "); WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'? #245: FILE: app/test-gpudev/main.c:293: + fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet "); ERROR:OPEN_BRACE: that open brace { should be on the previous line #248: FILE: app/test-gpudev/main.c:296: + else + { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #248: FILE: app/test-gpudev/main.c:296: + } + else WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'? #250: FILE: app/test-gpudev/main.c:298: + fprintf(stderr, "rte_gpu_comm_cleanup_list correctly didn't clean up the packets because they have not beeing consumed yet "); ERROR:OPEN_BRACE: that open brace { should be on the previous line #264: FILE: app/test-gpudev/main.c:312: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #264: FILE: app/test-gpudev/main.c:312: + if(ret < 0) ERROR:OPEN_BRACE: that open brace { should be on the previous line #271: FILE: app/test-gpudev/main.c:319: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #271: FILE: app/test-gpudev/main.c:319: + if(ret < 0) ERROR:SPACING: space required before the open parenthesis '(' #277: FILE: app/test-gpudev/main.c:325: + for(i = 0; i < 10; i++) WARNING:TYPO_SPELLING: 'expecially' may be misspelled - perhaps 'especially'? #308: FILE: doc/guides/prog_guide/gpudev.rst:94: +Best practice, expecially in a multithreaded application, WARNING:LONG_LINE: line length of 101 exceeds 100 columns #368: FILE: lib/gpudev/gpudev.c:768: + ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_list) * num_comm_items, comm_list); ERROR:OPEN_BRACE: that open brace { should be on the previous line #369: FILE: lib/gpudev/gpudev.c:769: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #369: FILE: lib/gpudev/gpudev.c:769: + if(ret < 0) WARNING:LONG_LINE: line length of 127 exceeds 100 columns #376: FILE: lib/gpudev/gpudev.c:776: + comm_list[idx_l].pkt_list = rte_zmalloc(NULL, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, 0); WARNING:LONG_LINE: line length of 136 exceeds 100 columns #382: FILE: lib/gpudev/gpudev.c:782: + ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, comm_list[idx_l].pkt_list); ERROR:OPEN_BRACE: that open brace { should be on the previous line #383: FILE: lib/gpudev/gpudev.c:783: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #383: FILE: lib/gpudev/gpudev.c:783: + if(ret < 0) ERROR:OPEN_BRACE: that open brace { should be on the previous line #412: FILE: lib/gpudev/gpudev.c:812: + for (idx_l = 0; idx_l < num_comm_items; idx_l++) + { ERROR:OPEN_BRACE: that open brace { should be on the previous line #415: FILE: lib/gpudev/gpudev.c:815: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #415: FILE: lib/gpudev/gpudev.c:815: + if(ret < 0) ERROR:OPEN_BRACE: that open brace { should be on the previous line #425: FILE: lib/gpudev/gpudev.c:825: + if(ret < 0) + { ERROR:SPACING: space required before the open parenthesis '(' #425: FILE: lib/gpudev/gpudev.c:825: + if(ret < 0) total: 27 errors, 7 warnings, 481 lines checked