From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6931A0C47 for ; Tue, 26 Oct 2021 07:07:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC7AE41169; Tue, 26 Oct 2021 07:07:28 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 42B4840E0F for ; Tue, 26 Oct 2021 07:07:13 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 35F77121E90; Tue, 26 Oct 2021 07:07:13 +0200 (CEST) In-Reply-To: <20211026050547.14692-3-venkatkumar.duvvuru@broadcom.com> References: <20211026050547.14692-3-venkatkumar.duvvuru@broadcom.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Venkat Duvvuru Message-Id: <20211026050713.35F77121E90@dpdk.org> Date: Tue, 26 Oct 2021 07:07:13 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw102838 [PATCH v2 02/19] net/bnxt: add support for multi root capability X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/102838 _coding style issues_ WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'? #63: capability is enabled in the hardware. DPDK HSI version updated WARNING:LONG_LINE: line length of 104 exceeds 100 columns #186: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10272: + #define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD \ WARNING:LONG_LINE: line length of 102 exceeds 100 columns #190: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10275: + HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD WARNING:LONG_LINE: line length of 104 exceeds 100 columns #339: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10557: + #define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_MASK \ WARNING:LONG_LINE: line length of 103 exceeds 100 columns #341: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10559: + #define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_SFT \ WARNING:LONG_LINE: line length of 123 exceeds 100 columns #348: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10566: + #define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD \ WARNING:LONG_LINE: line length of 104 exceeds 100 columns #350: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10568: + #define HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_LAST \ WARNING:LONG_LINE: line length of 121 exceeds 100 columns #351: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:10569: + HWRM_ASYNC_EVENT_CMPL_ERROR_REPORT_DOORBELL_DROP_THRESHOLD_EVENT_DATA1_ERROR_TYPE_DOORBELL_DROP_THRESHOLD WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1202: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19044: + /* PTM Master timestamp value. */ WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1204: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19046: + /* PTM Master propagation delay */ WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1254: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19096: + * This bit must be '1' for the phc_master_fid field to be WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #1257: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19099: + #define HWRM_FUNC_PTP_EXT_CFG_INPUT_ENABLES_PHC_MASTER_FID \ WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1278: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19120: + * This field is used to configure the Master function. Only this WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1283: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19125: + * the first function that makes the call to modify PHC as the Master. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1285: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19127: + uint16_t phc_master_fid; WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1288: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19130: + * function becomes the Master function in case of failover from WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1289: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19131: + * Master function. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1291: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19133: + * the last non-master function to make a call to condition PHC as WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1323: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19165: + * current master to secondary fid. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1328: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19170: + * at least 6 seconds, then secondary takes over as master to condition WARNING:TYPO_SPELLING: 'Master' may be misspelled - perhaps 'Primary'? #1332: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19174: + * happens. Admin or auto selected Master will always be used for WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1413: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19255: + * Firmware returns the current PHC master function. This function WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1416: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19258: + uint16_t phc_master_fid; WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1423: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19265: + * Firmware returns the last non-master/non-secondary function to WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1428: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19270: + * Firmware returns the second last non-master/non-secondary function WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1433: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19275: + * Timestamp indicating the last time a failover happened. The master WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #1439: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:19281: + * Last failover happened from this function. This was the master WARNING:TYPO_SPELLING: 'chooose' may be misspelled - perhaps 'choose'? #1764: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20316: + * The user must chooose a value that is not conflicting with WARNING:TYPO_SPELLING: 'chooose' may be misspelled - perhaps 'choose'? #1773: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:20575: + * The user must chooose a value that is not conflicting with WARNING:TYPO_SPELLING: 'seesion' may be misspelled - perhaps 'session'? #3021: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:45272: + * Indicates if the shared session has been created. Shared seesion WARNING:LONG_LINE_COMMENT: line length of 134 exceeds 100 columns #3259: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50307: + /* The Directory Entry Type (valid values are defined in the bnxnvm_directory_type enum defined in the file bnxnvm_defs.h). */ WARNING:LONG_LINE_COMMENT: line length of 118 exceeds 100 columns #3271: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50319: + * Length of data to write, in bytes. May be less than or equal to the allocated size for the directory entry. WARNING:LONG_LINE_COMMENT: line length of 122 exceeds 100 columns #3272: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50320: + * The data length stored in the directory entry will be updated to reflect this value once the write is complete. WARNING:LONG_LINE_COMMENT: line length of 164 exceeds 100 columns #3300: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50351: + * The requested length of the allocated NVM for the item, in bytes. This value may be greater than or equal to the specified data length (dir_data_length). WARNING:LONG_LINE_COMMENT: line length of 123 exceeds 100 columns #3308: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50353: + * The response will contain the actual allocated item length, which may be greater than the requested item length. WARNING:LONG_LINE_COMMENT: line length of 153 exceeds 100 columns #3309: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50354: + * The purpose for allocating more than the required number of bytes for an item's data is to pre-allocate extra storage (padding) to accommodate WARNING:LONG_LINE_COMMENT: line length of 137 exceeds 100 columns #3310: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50355: + * the potential future growth of an item (e.g. upgraded firmware with a size increase, log growth, expanded configuration data). WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #3315: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50360: + * Only valid for batch mode. For non-batch writes 'dont care'. WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #3320: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50365: + * Only valid for batch mode. For non-batch writes 'dont care'. WARNING:LONG_LINE_COMMENT: line length of 160 exceeds 100 columns #3334: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50382: + * Length of the allocated NVM for the item, in bytes. The value may be greater than or equal to the specified data length or the requested item length. WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns #3335: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50383: + * The actual item length used when creating a new directory entry will be a multiple of an NVM block size. WARNING:LONG_LINE_COMMENT: line length of 133 exceeds 100 columns #3347: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50727: + /* Available size that can be used, in bytes. Available size is the NVRAM size take away the used size and reserved size. */ WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns #3359: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:50869: + /* The Directory Entry Extension flags (see BNX_DIR_EXT_* for extension flag definitions). */ WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns #3371: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:51038: + * If set to 1, then unspecified images, images not in the package file, will be safely deleted. WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns #3408: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:51430: + /* When this bit is 1, flush internal cache after this write operation (see hwrm_nvm_flush command.) */ total: 0 errors, 45 warnings, 0 checks, 3354 lines checked