* [dpdk-test-report] |WARNING| pw103640 [PATCH v4 8/9] gpudev: add communication list
[not found] <20211103191554.16449-9-eagostini@nvidia.com>
@ 2021-11-03 11:07 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-11-03 11:07 UTC (permalink / raw)
To: test-report; +Cc: eagostini
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/103640
_coding style issues_
ERROR:SPACING: space required before the open parenthesis '('
#187: FILE: app/test-gpudev/main.c:235:
+ if(comm_list_item == NULL)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#205: FILE: app/test-gpudev/main.c:253:
+ struct rte_gpu_comm_list * comm_list;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#207: FILE: app/test-gpudev/main.c:255:
+ struct rte_mbuf * mbufs[10];
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#212: FILE: app/test-gpudev/main.c:260:
+ if(comm_list == NULL)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#212: FILE: app/test-gpudev/main.c:260:
+ if(comm_list == NULL)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#221: FILE: app/test-gpudev/main.c:269:
+ for(i = 0; i < 10; i++)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#221: FILE: app/test-gpudev/main.c:269:
+ for(i = 0; i < 10; i++)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#236: FILE: app/test-gpudev/main.c:284:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#236: FILE: app/test-gpudev/main.c:284:
+ if(ret < 0)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#243: FILE: app/test-gpudev/main.c:291:
+ if(ret == 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#243: FILE: app/test-gpudev/main.c:291:
+ if(ret == 0)
WARNING:TYPO_SPELLING: 'erroneusly' may be misspelled - perhaps 'erroneously'?
#245: FILE: app/test-gpudev/main.c:293:
+ fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet
");
WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'?
#245: FILE: app/test-gpudev/main.c:293:
+ fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet
");
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#248: FILE: app/test-gpudev/main.c:296:
+ else
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#248: FILE: app/test-gpudev/main.c:296:
+ }
+ else
WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'?
#250: FILE: app/test-gpudev/main.c:298:
+ fprintf(stderr, "rte_gpu_comm_cleanup_list correctly didn't clean up the packets because they have not beeing consumed yet
");
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#264: FILE: app/test-gpudev/main.c:312:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#264: FILE: app/test-gpudev/main.c:312:
+ if(ret < 0)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#271: FILE: app/test-gpudev/main.c:319:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#271: FILE: app/test-gpudev/main.c:319:
+ if(ret < 0)
ERROR:SPACING: space required before the open parenthesis '('
#277: FILE: app/test-gpudev/main.c:325:
+ for(i = 0; i < 10; i++)
WARNING:TYPO_SPELLING: 'expecially' may be misspelled - perhaps 'especially'?
#308: FILE: doc/guides/prog_guide/gpudev.rst:94:
+Best practice, expecially in a multithreaded application,
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#368: FILE: lib/gpudev/gpudev.c:768:
+ ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_list) * num_comm_items, comm_list);
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#369: FILE: lib/gpudev/gpudev.c:769:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#369: FILE: lib/gpudev/gpudev.c:769:
+ if(ret < 0)
WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#376: FILE: lib/gpudev/gpudev.c:776:
+ comm_list[idx_l].pkt_list = rte_zmalloc(NULL, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, 0);
WARNING:LONG_LINE: line length of 136 exceeds 100 columns
#382: FILE: lib/gpudev/gpudev.c:782:
+ ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, comm_list[idx_l].pkt_list);
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#383: FILE: lib/gpudev/gpudev.c:783:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#383: FILE: lib/gpudev/gpudev.c:783:
+ if(ret < 0)
WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#393: FILE: lib/gpudev/gpudev.c:793:
+ comm_list[idx_l].mbufs = rte_zmalloc(NULL, sizeof(struct rte_mbuf *) * RTE_GPU_COMM_LIST_PKTS_MAX, 0);
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#418: FILE: lib/gpudev/gpudev.c:818:
+ for (idx_l = 0; idx_l < num_comm_items; idx_l++)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#421: FILE: lib/gpudev/gpudev.c:821:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#421: FILE: lib/gpudev/gpudev.c:821:
+ if(ret < 0)
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#432: FILE: lib/gpudev/gpudev.c:832:
+ if(ret < 0)
+ {
ERROR:SPACING: space required before the open parenthesis '('
#432: FILE: lib/gpudev/gpudev.c:832:
+ if(ret < 0)
ERROR:POINTER_LOCATION: "foo ** bar" should be "foo **bar"
#573: FILE: lib/gpudev/rte_gpudev.h:122:
+ struct rte_mbuf ** mbufs;
total: 28 errors, 8 warnings, 485 lines checked
^ permalink raw reply [flat|nested] only message in thread