From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CCA8EA0C4D
	for <public@inbox.dpdk.org>; Mon,  8 Nov 2021 11:49:10 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C911541100;
	Mon,  8 Nov 2021 11:49:10 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 24F7640E28
 for <test-report@dpdk.org>; Mon,  8 Nov 2021 11:49:10 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 1A5DE123056; Mon,  8 Nov 2021 11:49:10 +0100 (CET)
In-Reply-To: <20211108185805.3887-9-eagostini@nvidia.com>
References: <20211108185805.3887-9-eagostini@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: <eagostini@nvidia.com>
Message-Id: <20211108104910.1A5DE123056@dpdk.org>
Date: Mon,  8 Nov 2021 11:49:10 +0100 (CET)
Subject: [dpdk-test-report] |WARNING| pw103978 [PATCH v5 8/9] gpudev: add
 communication list
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/103978

_coding style issues_


WARNING:TYPO_SPELLING: 'erroneusly' may be misspelled - perhaps 'erroneously'?
#241: FILE: app/test-gpudev/main.c:271:
+		fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet
");

WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'?
#241: FILE: app/test-gpudev/main.c:271:
+		fprintf(stderr, "rte_gpu_comm_cleanup_list erroneusly cleaned the list even if packets have not beeing consumed yet
");

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#243: FILE: app/test-gpudev/main.c:273:
+		return -1;
+	} else {

WARNING:TYPO_SPELLING: 'beeing' may be misspelled - perhaps 'being'?
#244: FILE: app/test-gpudev/main.c:274:
+		fprintf(stderr, "rte_gpu_comm_cleanup_list correctly didn't clean up the packets because they have not beeing consumed yet
");

WARNING:TYPO_SPELLING: 'expecially' may be misspelled - perhaps 'especially'?
#300: FILE: doc/guides/prog_guide/gpudev.rst:94:
+Best practice, expecially in a multithreaded application,

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#360: FILE: lib/gpudev/gpudev.c:766:
+	ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_list) * num_comm_items, comm_list);

WARNING:LONG_LINE: line length of 127 exceeds 100 columns
#367: FILE: lib/gpudev/gpudev.c:773:
+		comm_list[idx_l].pkt_list = rte_zmalloc(NULL, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, 0);

WARNING:LONG_LINE: line length of 136 exceeds 100 columns
#373: FILE: lib/gpudev/gpudev.c:779:
+		ret = rte_gpu_register(dev_id, sizeof(struct rte_gpu_comm_pkt) * RTE_GPU_COMM_LIST_PKTS_MAX, comm_list[idx_l].pkt_list);

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#383: FILE: lib/gpudev/gpudev.c:789:
+		comm_list[idx_l].mbufs = rte_zmalloc(NULL, sizeof(struct rte_mbuf *) * RTE_GPU_COMM_LIST_PKTS_MAX, 0);

total: 0 errors, 9 warnings, 472 lines checked