|WARNING| pw104414 [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104414

_coding style issues_


WARNING:TYPO_SPELLING: 'differents' may be misspelled - perhaps 'different'?
#198: FILE: app/test-pmd/cmdline.c:3676:
+	 * Then, check that all values in the list are differents.

WARNING:TYPO_SPELLING: 'optionaly' may be misspelled - perhaps 'optionally'?
#228: FILE: app/test-pmd/config.c:2968:
+ * Displays the RSS hash functions of a port, and, optionaly, the RSS hash

WARNING:TYPO_SPELLING: 'addressses' may be misspelled - perhaps 'addresses'?
#237: FILE: app/test-pmd/config.c:5253:
+		/* No need to recompact the set of multicast addressses. */

WARNING:TYPO_SPELLING: 'Unkwown' may be misspelled - perhaps 'Unknown'?
#250: FILE: app/test-pmd/icmpecho.c:57:
+	return "Unkwown ARP op";

ERROR:TRAILING_WHITESPACE: trailing whitespace
#299: FILE: app/test-pmd/parameters.c:1555:
+^I^I^ITESTPMD_LOG(ERR, $

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#331: FILE: app/test-pmd/testpmd.c:557:
+int gpu_id = 0;

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#390: FILE: app/test-pmd/testpmd.c:1169:
+	ret = rte_extmem_register(gpu_mem.buf_ptr, gpu_mem.buf_len, NULL, gpu_mem.buf_iova, gpu_page_size);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#392: FILE: app/test-pmd/testpmd.c:1171:
+		rte_exit(EXIT_FAILURE, "Unable to register addr 0x%p, ret %d
", gpu_mem.buf_ptr, ret);

WARNING:LONG_LINE: line length of 128 exceeds 100 columns
#405: FILE: app/test-pmd/testpmd.c:1184:
+	rte_mp = rte_pktmbuf_pool_create_extbuf(pool_name, nb_mbuf, mb_mempool_cache, 0, mbuf_seg_size, socket_id, &gpu_mem, 1);

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#430: FILE: app/test-pmd/testpmd.c:1790:
 			for (j = 0; j < mbuf_data_size_n; j++)
+			{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#453: FILE: app/test-pmd/testpmd.c:1809:
 		for (i = 0; i < mbuf_data_size_n; i++)
+		{

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#497: FILE: app/test-pmd/testpmd.c:3541:
+								(uint8_t *)mempools_ext_ptr[i], ret, rte_errno);

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#502: FILE: app/test-pmd/testpmd.c:3546:
+						if (ret != 0)

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#508: FILE: app/test-pmd/testpmd.c:3552:
+								(void *)mempools_ext_ptr[i], RTE_BAD_IOVA,

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#511: FILE: app/test-pmd/testpmd.c:3555:
+						if (ret)

WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#514: FILE: app/test-pmd/testpmd.c:3558:
+									(uint8_t *)mempools_ext_ptr[i], ret, rte_errno);

total: 4 errors, 12 warnings, 389 lines checked