From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 20385A0C41
	for <public@inbox.dpdk.org>; Thu, 18 Nov 2021 11:47:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1363B40687;
	Thu, 18 Nov 2021 11:47:28 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id EA34A40395
 for <test-report@dpdk.org>; Thu, 18 Nov 2021 11:47:26 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id D2A94121E65; Thu, 18 Nov 2021 11:47:26 +0100 (CET)
Subject: |WARNING| pw104509 [PATCH v2 1/1] app/test-gpudev: introduce ethdev
 to rx/tx packets using GPU memory
In-Reply-To: <20211118185613.3246-2-eagostini@nvidia.com>
References: <20211118185613.3246-2-eagostini@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: <eagostini@nvidia.com>
Message-Id: <20211118104726.D2A94121E65@dpdk.org>
Date: Thu, 18 Nov 2021 11:47:26 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104509

_coding style issues_


ERROR:C99_COMMENTS: do not use C99 // comments
#168: FILE: app/test-gpudev/main.c:39:
+// #define DEBUG_PRINT 1

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#188: FILE: app/test-gpudev/main.c:58:
+static uint16_t conf_gpu_id = 0;

ERROR:INITIALISED_STATIC: do not initialise statics to false
#192: FILE: app/test-gpudev/main.c:62:
+static bool conf_testapi = false;

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#197: FILE: app/test-gpudev/main.c:67:
+static uint16_t conf_port_id = 0;

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#367: FILE: app/test-gpudev/main.c:512:
+		RTE_GPU_VOLATILE(comm_list_fwd[queue_id][comm_list_item].status) = RTE_GPU_COMM_LIST_DONE;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#397: FILE: app/test-gpudev/main.c:542:
+		while (RTE_GPU_VOLATILE(comm_list_fwd[queue_id][comm_list_item].status) !=
+				RTE_GPU_COMM_LIST_DONE && force_quit == false);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#522: FILE: app/test-gpudev/main.c:668:
+					"rte_gpu_mem_register CPU memory returned error %d.
", ret);

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#537: FILE: app/test-gpudev/main.c:683:
+			fprintf(stderr, "Unable to register addr 0x%p, ret %d.
", ext_mem.buf_ptr, ret);

total: 5 errors, 3 warnings, 551 lines checked