|WARNING| pw105243 [PATCH v1 07/25] net/spnic: add interface handling cmdq message

|WARNING| pw105243 [PATCH v1 07/25] net/spnic: add interface handling cmdq message

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105243

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#209: FILE: drivers/net/spnic/base/spnic_cmdq.c:145:
+#define WQE_NUM_WQEBBS(wqe_size, wq)	\
+	((u16)(RTE_ALIGN((u32)(wqe_size), (wq)->wqebb_size) / (wq)->wqebb_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cmdq' - possible side-effects?
#212: FILE: drivers/net/spnic/base/spnic_cmdq.c:148:
+#define cmdq_to_cmdqs(cmdq)	container_of((cmdq) - (cmdq)->cmdq_type, \
+					     struct spnic_cmdqs, cmdq[0])

WARNING:TYPO_SPELLING: 'coverting' may be misspelled - perhaps 'converting'?
#317: FILE: drivers/net/spnic/base/spnic_cmdq.c:253:
+	/* Hardware will do endianness coverting */

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#707: FILE: drivers/net/spnic/base/spnic_cmdq.c:723:
+	size_t saved_wqs_size;

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#715: FILE: drivers/net/spnic/base/spnic_cmdq.c:734:
+	saved_wqs_size = SPNIC_MAX_CMDQ_TYPES * sizeof(struct spnic_wq);

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#716: FILE: drivers/net/spnic/base/spnic_cmdq.c:735:
+	cmdqs->saved_wqs = rte_zmalloc(NULL, saved_wqs_size, 0);

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#716: FILE: drivers/net/spnic/base/spnic_cmdq.c:735:
+	cmdqs->saved_wqs = rte_zmalloc(NULL, saved_wqs_size, 0);

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#717: FILE: drivers/net/spnic/base/spnic_cmdq.c:736:
+	if (!cmdqs->saved_wqs) {

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#718: FILE: drivers/net/spnic/base/spnic_cmdq.c:737:
+		PMD_DRV_LOG(ERR, "Allocate saved wqs failed");

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#720: FILE: drivers/net/spnic/base/spnic_cmdq.c:739:
+		goto alloc_wqs_err;

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#730: FILE: drivers/net/spnic/base/spnic_cmdq.c:755:
+	err = spnic_cmdq_alloc(cmdqs->saved_wqs, hwdev, SPNIC_MAX_CMDQ_TYPES,

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#755: FILE: drivers/net/spnic/base/spnic_cmdq.c:787:
+	spnic_cmdq_free(cmdqs->saved_wqs, SPNIC_MAX_CMDQ_TYPES);

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#761: FILE: drivers/net/spnic/base/spnic_cmdq.c:793:
+	rte_free(cmdqs->saved_wqs);

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#763: FILE: drivers/net/spnic/base/spnic_cmdq.c:795:
+alloc_wqs_err:

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#771: FILE: drivers/net/spnic/base/spnic_cmdq.c:811:
+	spnic_cmdq_free(cmdqs->saved_wqs, SPNIC_MAX_CMDQ_TYPES);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around wq[i].delta
#1094: FILE: drivers/net/spnic/base/spnic_wq.c:92:
+		__atomic_store_n(&(wq[i].delta), q_depth, __ATOMIC_RELAXED);

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#1150: FILE: drivers/net/spnic/base/spnic_wq.h:12:
+#define WQS_BLOCKS_PER_PAGE		4

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1152: FILE: drivers/net/spnic/base/spnic_wq.h:14:
+#define WQ_SIZE(wq)		((u32)((u64)(wq)->q_depth * (wq)->wqebb_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1154: FILE: drivers/net/spnic/base/spnic_wq.h:16:
+#define	WQE_PAGE_NUM(wq, idx)	(((idx) >> ((wq)->wqebbs_per_page_shift)) & \
+				((wq)->num_q_pages - 1))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1157: FILE: drivers/net/spnic/base/spnic_wq.h:19:
+#define	WQE_PAGE_OFF(wq, idx)	((u64)((wq)->wqebb_size) * \
+				((idx) & ((wq)->num_wqebbs_per_page - 1)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1162: FILE: drivers/net/spnic/base/spnic_wq.h:24:
+#define WQ_PAGE_ADDR(wq, idx)		\
+		((u8 *)(*(u64 *)((u64)((wq)->shadow_block_vaddr) + \
+		(WQE_PAGE_NUM(wq, idx) << WQ_PAGE_ADDR_SIZE_SHIFT))))

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#1167: FILE: drivers/net/spnic/base/spnic_wq.h:29:
+#define WQS_PAGE_SIZE		(WQS_BLOCKS_PER_PAGE * WQ_BLOCK_SIZE)

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#1167: FILE: drivers/net/spnic/base/spnic_wq.h:29:
+#define WQS_PAGE_SIZE		(WQS_BLOCKS_PER_PAGE * WQ_BLOCK_SIZE)

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1178: FILE: drivers/net/spnic/base/spnic_wq.h:40:
+#define WQ_BASE_VADDR(wqs, wq)		\

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1178: FILE: drivers/net/spnic/base/spnic_wq.h:40:
+#define WQ_BASE_VADDR(wqs, wq)		\
+		((u64 *)(((u64)((wqs)->page_vaddr[(wq)->page_idx])) \
+				+ (wq)->block_idx * WQ_BLOCK_SIZE))

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1179: FILE: drivers/net/spnic/base/spnic_wq.h:41:
+		((u64 *)(((u64)((wqs)->page_vaddr[(wq)->page_idx])) \

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1182: FILE: drivers/net/spnic/base/spnic_wq.h:44:
+#define WQ_BASE_PADDR(wqs, wq)	(((wqs)->page_paddr[(wq)->page_idx]) \

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1182: FILE: drivers/net/spnic/base/spnic_wq.h:44:
+#define WQ_BASE_PADDR(wqs, wq)	(((wqs)->page_paddr[(wq)->page_idx]) \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1182: FILE: drivers/net/spnic/base/spnic_wq.h:44:
+#define WQ_BASE_PADDR(wqs, wq)	(((wqs)->page_paddr[(wq)->page_idx]) \
+				+ (u64)(wq)->block_idx * WQ_BLOCK_SIZE)

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1185: FILE: drivers/net/spnic/base/spnic_wq.h:47:
+#define WQ_BASE_ADDR(wqs, wq)		\

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1185: FILE: drivers/net/spnic/base/spnic_wq.h:47:
+#define WQ_BASE_ADDR(wqs, wq)		\
+		((u64 *)(((u64)((wqs)->shadow_page_vaddr[(wq)->page_idx])) \
+				+ (wq)->block_idx * WQ_BLOCK_SIZE))

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1186: FILE: drivers/net/spnic/base/spnic_wq.h:48:
+		((u64 *)(((u64)((wqs)->shadow_page_vaddr[(wq)->page_idx])) \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wq' - possible side-effects?
#1196: FILE: drivers/net/spnic/base/spnic_wq.h:65:
+#define WQE_SHADOW_PAGE(wq, wqe)	\
+		((u16)(((unsigned long)(wqe) - (unsigned long)(wq)->shadow_wqe) \
+		/ (wq)->max_wqe_size))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'wqe' - possible side-effects?
#1200: FILE: drivers/net/spnic/base/spnic_wq.h:69:
+#define WQE_IN_RANGE(wqe, start, end)	\
+		(((unsigned long)(wqe) >= (unsigned long)(start)) && \
+		((unsigned long)(wqe) < (unsigned long)(end)))

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1204: FILE: drivers/net/spnic/base/spnic_wq.h:73:
+#define WQ_NUM_PAGES(num_wqs)	\

WARNING:TYPO_SPELLING: 'wqs' may be misspelled - perhaps 'was'?
#1205: FILE: drivers/net/spnic/base/spnic_wq.h:74:
+	(RTE_ALIGN((u32)(num_wqs), WQS_BLOCKS_PER_PAGE) / WQS_BLOCKS_PER_PAGE)

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#1205: FILE: drivers/net/spnic/base/spnic_wq.h:74:
+	(RTE_ALIGN((u32)(num_wqs), WQS_BLOCKS_PER_PAGE) / WQS_BLOCKS_PER_PAGE)

WARNING:TYPO_SPELLING: 'WQS' may be misspelled - perhaps 'WAS'?
#1205: FILE: drivers/net/spnic/base/spnic_wq.h:74:
+	(RTE_ALIGN((u32)(num_wqs), WQS_BLOCKS_PER_PAGE) / WQS_BLOCKS_PER_PAGE)

total: 0 errors, 26 warnings, 12 checks, 1116 lines checked