automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiayu Hu <jiayu.hu@intel.com>
Subject: |WARNING| pw105528 [PATCH v1 1/1] vhost: integrate dmadev in asynchronous datapath
Date: Thu, 30 Dec 2021 14:52:27 +0100 (CET)	[thread overview]
Message-ID: <20211230135227.AA02D120D7B@dpdk.org> (raw)
In-Reply-To: <20211230215505.329674-2-jiayu.hu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105528

_coding style issues_


WARNING:TYPO_SPELLING: 'applcations' may be misspelled - perhaps 'applications'?
#179: FILE: doc/guides/prog_guide/vhost_lib.rst:420:
+enables applcations, like OVS, to save CPU cycles and hide memory copy

WARNING:BRACES: braces {} are not necessary for single statement blocks
#551: FILE: examples/vhost/main.c:212:
+		if (dma_config[i].dev_id == dev_id) {
+			return true;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#812: FILE: examples/vhost/main.c:1600:
+		if (ret == 0) {
+			dma_bind[vid].dmas[VIRTIO_RXQ].async_enabled = true;
 		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#855: FILE: examples/vhost/main.c:1794:
+	for (i = 0; i < RTE_DMADEV_DEFAULT_MAX; i++) {
+		dma_config[i].dev_id = INVALID_DMA_ID;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1295: FILE: lib/vhost/vhost.c:1826:
+		if (dma->max_vchans == 0) {
+			continue;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1299: FILE: lib/vhost/vhost.c:1830:
+		for (j = 0; j < dma->max_vchans; j++) {
+			rte_free(dma->vchans[j].metadata);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1329: FILE: lib/vhost/vhost.c:1860:
+		if (!rte_is_power_of_2(max_desc)) {
+			max_desc = rte_align32pow2(max_desc);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1501: FILE: lib/vhost/virtio_net.c:67:
+		if (rte_dma_burst_capacity(dma_id, vchan) < nr_segs) {
+			goto out;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1560: FILE: lib/vhost/virtio_net.c:126:
+	if (nr_copies == 0) {
+		goto out;
+	}

total: 0 errors, 9 warnings, 1324 lines checked

       reply	other threads:[~2021-12-30 13:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211230215505.329674-2-jiayu.hu@intel.com>
2021-12-30 13:52 ` checkpatch [this message]
2021-12-30 15:19 ` |SUCCESS| " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211230135227.AA02D120D7B@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).