From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0CD3EA0352
	for <public@inbox.dpdk.org>; Thu, 30 Dec 2021 14:52:29 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F06384113F;
	Thu, 30 Dec 2021 14:52:28 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id C2DFD40F35
 for <test-report@dpdk.org>; Thu, 30 Dec 2021 14:52:27 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id AA02D120D7B; Thu, 30 Dec 2021 14:52:27 +0100 (CET)
Subject: |WARNING| pw105528 [PATCH v1 1/1] vhost: integrate dmadev in
 asynchronous datapath
In-Reply-To: <20211230215505.329674-2-jiayu.hu@intel.com>
References: <20211230215505.329674-2-jiayu.hu@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Jiayu Hu <jiayu.hu@intel.com>
Message-Id: <20211230135227.AA02D120D7B@dpdk.org>
Date: Thu, 30 Dec 2021 14:52:27 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/105528

_coding style issues_


WARNING:TYPO_SPELLING: 'applcations' may be misspelled - perhaps 'applications'?
#179: FILE: doc/guides/prog_guide/vhost_lib.rst:420:
+enables applcations, like OVS, to save CPU cycles and hide memory copy

WARNING:BRACES: braces {} are not necessary for single statement blocks
#551: FILE: examples/vhost/main.c:212:
+		if (dma_config[i].dev_id == dev_id) {
+			return true;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#812: FILE: examples/vhost/main.c:1600:
+		if (ret == 0) {
+			dma_bind[vid].dmas[VIRTIO_RXQ].async_enabled = true;
 		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#855: FILE: examples/vhost/main.c:1794:
+	for (i = 0; i < RTE_DMADEV_DEFAULT_MAX; i++) {
+		dma_config[i].dev_id = INVALID_DMA_ID;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1295: FILE: lib/vhost/vhost.c:1826:
+		if (dma->max_vchans == 0) {
+			continue;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1299: FILE: lib/vhost/vhost.c:1830:
+		for (j = 0; j < dma->max_vchans; j++) {
+			rte_free(dma->vchans[j].metadata);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1329: FILE: lib/vhost/vhost.c:1860:
+		if (!rte_is_power_of_2(max_desc)) {
+			max_desc = rte_align32pow2(max_desc);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1501: FILE: lib/vhost/virtio_net.c:67:
+		if (rte_dma_burst_capacity(dma_id, vchan) < nr_segs) {
+			goto out;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1560: FILE: lib/vhost/virtio_net.c:126:
+	if (nr_copies == 0) {
+		goto out;
+	}

total: 0 errors, 9 warnings, 1324 lines checked