From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61423A04A3 for ; Mon, 3 Jan 2022 17:03:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59C1241141; Mon, 3 Jan 2022 17:03:05 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 8C0C040E0F for ; Mon, 3 Jan 2022 17:03:03 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 854D2120DB4; Mon, 3 Jan 2022 17:03:03 +0100 (CET) Subject: |WARNING| pw105586 [PATCH 2/5] net/cnxk: reassembly support In-Reply-To: <20220103160149.1715058-3-gakhil@marvell.com> References: <20220103160149.1715058-3-gakhil@marvell.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Akhil Goyal Message-Id: <20220103160303.854D2120DB4@dpdk.org> Date: Mon, 3 Jan 2022 17:03:03 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/105586 _coding style issues_ WARNING:REPEATED_WORD: Possible repeated word: 'the' #3610: FILE: drivers/net/cnxk/cn10k_rx.h:205: + /* Update only the the upper 28-bits from meta pkt parse info */ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3624: FILE: drivers/net/cnxk/cn10k_rx.h:219: + struct rte_ipv4_hdr *hdr = (struct rte_ipv4_hdr *)RTE_PTR_ADD( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3629: FILE: drivers/net/cnxk/cn10k_rx.h:224: + struct rte_ipv6_hdr *hdr = (struct rte_ipv6_hdr *)RTE_PTR_ADD( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3685: FILE: drivers/net/cnxk/cn10k_rx.h:280: + struct rte_ipv4_hdr *hdr = (struct rte_ipv4_hdr *)RTE_PTR_ADD( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3696: FILE: drivers/net/cnxk/cn10k_rx.h:291: + struct rte_ipv6_hdr *hdr = (struct rte_ipv6_hdr *)RTE_PTR_ADD( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3699: FILE: drivers/net/cnxk/cn10k_rx.h:294: + hdr->payload_len = rte_cpu_to_be_16( CHECK:SPACING: spaces preferred around that '-' (ctx:WxV) #3706: FILE: drivers/net/cnxk/cn10k_rx.h:301: + inner_rx->pkt_lenm1 = pkt_hdr_len + fragx_sum -8 - 1; ^ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3753: FILE: drivers/net/cnxk/cn10k_rx.h:347: + *)(rte_be_to_cpu_64( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3777: FILE: drivers/net/cnxk/cn10k_rx.h:371: + *)(rte_be_to_cpu_64( CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #3829: FILE: drivers/net/cnxk/cn10k_rx.h:448: + if ((flags & NIX_RX_OFFLOAD_REASSEMBLY_F) && (cq_w1 & BIT(11))) { + CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #3849: FILE: drivers/net/cnxk/cn10k_rx.h:468: + } else { + CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3851: FILE: drivers/net/cnxk/cn10k_rx.h:470: + *)(rte_be_to_cpu_64( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #3887: FILE: drivers/net/cnxk/cn10k_rx.h:506: + *)(rte_be_to_cpu_64( ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4049: FILE: drivers/net/cnxk/cn10k_rx.h:1588: +#define NIX_RX_FASTPATH_MODES_128_143 \ + R(reas, R_REAS_F) \ + R(reas_rss, R_REAS_F | RSS_F) \ + R(reas_ptype, R_REAS_F | PTYPE_F) \ + R(reas_ptype_rss, R_REAS_F | PTYPE_F | RSS_F) \ + R(reas_cksum, R_REAS_F | CKSUM_F) \ + R(reas_cksum_rss, R_REAS_F | CKSUM_F | RSS_F) \ + R(reas_cksum_ptype, R_REAS_F | CKSUM_F | PTYPE_F) \ + R(reas_cksum_ptype_rss, R_REAS_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_mark, R_REAS_F | MARK_F) \ + R(reas_mark_rss, R_REAS_F | MARK_F | RSS_F) \ + R(reas_mark_ptype, R_REAS_F | MARK_F | PTYPE_F) \ + R(reas_mark_ptype_rss, R_REAS_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_mark_cksum, R_REAS_F | MARK_F | CKSUM_F) \ + R(reas_mark_cksum_rss, R_REAS_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_mark_cksum_ptype, R_REAS_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_mark_cksum_ptype_rss, \ + R_REAS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4068: FILE: drivers/net/cnxk/cn10k_rx.h:1607: +#define NIX_RX_FASTPATH_MODES_144_159 \ + R(reas_ts, R_REAS_F | TS_F) \ + R(reas_ts_rss, R_REAS_F | TS_F | RSS_F) \ + R(reas_ts_ptype, R_REAS_F | TS_F | PTYPE_F) \ + R(reas_ts_ptype_rss, R_REAS_F | TS_F | PTYPE_F | RSS_F) \ + R(reas_ts_cksum, R_REAS_F | TS_F | CKSUM_F) \ + R(reas_ts_cksum_rss, R_REAS_F | TS_F | CKSUM_F | RSS_F) \ + R(reas_ts_cksum_ptype, R_REAS_F | TS_F | CKSUM_F | PTYPE_F) \ + R(reas_ts_cksum_ptype_rss, R_REAS_F | TS_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_ts_mark, R_REAS_F | TS_F | MARK_F) \ + R(reas_ts_mark_rss, R_REAS_F | TS_F | MARK_F | RSS_F) \ + R(reas_ts_mark_ptype, R_REAS_F | TS_F | MARK_F | PTYPE_F) \ + R(reas_ts_mark_ptype_rss, R_REAS_F | TS_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_ts_mark_cksum, R_REAS_F | TS_F | MARK_F | CKSUM_F) \ + R(reas_ts_mark_cksum_rss, R_REAS_F | TS_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_ts_mark_cksum_ptype, \ + R_REAS_F | TS_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_ts_mark_cksum_ptype_rss, \ + R_REAS_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4088: FILE: drivers/net/cnxk/cn10k_rx.h:1627: +#define NIX_RX_FASTPATH_MODES_160_175 \ + R(reas_vlan, R_REAS_F | RX_VLAN_F) \ + R(reas_vlan_rss, R_REAS_F | RX_VLAN_F | RSS_F) \ + R(reas_vlan_ptype, R_REAS_F | RX_VLAN_F | PTYPE_F) \ + R(reas_vlan_ptype_rss, R_REAS_F | RX_VLAN_F | PTYPE_F | RSS_F) \ + R(reas_vlan_cksum, R_REAS_F | RX_VLAN_F | CKSUM_F) \ + R(reas_vlan_cksum_rss, R_REAS_F | RX_VLAN_F | CKSUM_F | RSS_F) \ + R(reas_vlan_cksum_ptype, R_REAS_F | RX_VLAN_F | CKSUM_F | PTYPE_F) \ + R(reas_vlan_cksum_ptype_rss, \ + R_REAS_F | RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_vlan_mark, R_REAS_F | RX_VLAN_F | MARK_F) \ + R(reas_vlan_mark_rss, R_REAS_F | RX_VLAN_F | MARK_F | RSS_F) \ + R(reas_vlan_mark_ptype, R_REAS_F | RX_VLAN_F | MARK_F | PTYPE_F) \ + R(reas_vlan_mark_ptype_rss, \ + R_REAS_F | RX_VLAN_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_vlan_mark_cksum, R_REAS_F | RX_VLAN_F | MARK_F | CKSUM_F) \ + R(reas_vlan_mark_cksum_rss, \ + R_REAS_F | RX_VLAN_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_vlan_mark_cksum_ptype, \ + R_REAS_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_vlan_mark_cksum_ptype_rss, \ + R_REAS_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4111: FILE: drivers/net/cnxk/cn10k_rx.h:1650: +#define NIX_RX_FASTPATH_MODES_176_191 \ + R(reas_vlan_ts, R_REAS_F | RX_VLAN_F | TS_F) \ + R(reas_vlan_ts_rss, R_REAS_F | RX_VLAN_F | TS_F | RSS_F) \ + R(reas_vlan_ts_ptype, R_REAS_F | RX_VLAN_F | TS_F | PTYPE_F) \ + R(reas_vlan_ts_ptype_rss, R_REAS_F | RX_VLAN_F | TS_F | PTYPE_F | RSS_F) \ + R(reas_vlan_ts_cksum, R_REAS_F | RX_VLAN_F | TS_F | CKSUM_F) \ + R(reas_vlan_ts_cksum_rss, R_REAS_F | RX_VLAN_F | TS_F | CKSUM_F | RSS_F) \ + R(reas_vlan_ts_cksum_ptype, \ + R_REAS_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F) \ + R(reas_vlan_ts_cksum_ptype_rss, \ + R_REAS_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_vlan_ts_mark, R_REAS_F | RX_VLAN_F | TS_F | MARK_F) \ + R(reas_vlan_ts_mark_rss, R_REAS_F | RX_VLAN_F | TS_F | MARK_F | RSS_F) \ + R(reas_vlan_ts_mark_ptype, \ + R_REAS_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F) \ + R(reas_vlan_ts_mark_ptype_rss, \ + R_REAS_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_vlan_ts_mark_cksum, \ + R_REAS_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F) \ + R(reas_vlan_ts_mark_cksum_rss, \ + R_REAS_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_vlan_ts_mark_cksum_ptype, \ + R_REAS_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_vlan_ts_mark_cksum_ptype_rss, \ + R_REAS_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4137: FILE: drivers/net/cnxk/cn10k_rx.h:1676: +#define NIX_RX_FASTPATH_MODES_192_207 \ + R(reas_sec, R_REAS_F | R_SEC_F) \ + R(reas_sec_rss, R_REAS_F | R_SEC_F | RSS_F) \ + R(reas_sec_ptype, R_REAS_F | R_SEC_F | PTYPE_F) \ + R(reas_sec_ptype_rss, R_REAS_F | R_SEC_F | PTYPE_F | RSS_F) \ + R(reas_sec_cksum, R_REAS_F | R_SEC_F | CKSUM_F) \ + R(reas_sec_cksum_rss, R_REAS_F | R_SEC_F | CKSUM_F | RSS_F) \ + R(reas_sec_cksum_ptype, R_REAS_F | R_SEC_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_cksum_ptype_rss, R_REAS_F | R_SEC_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_sec_mark, R_REAS_F | R_SEC_F | MARK_F) \ + R(reas_sec_mark_rss, R_REAS_F | R_SEC_F | MARK_F | RSS_F) \ + R(reas_sec_mark_ptype, R_REAS_F | R_SEC_F | MARK_F | PTYPE_F) \ + R(reas_sec_mark_ptype_rss, R_REAS_F | R_SEC_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_sec_mark_cksum, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F) \ + R(reas_sec_mark_cksum_rss, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_sec_mark_cksum_ptype, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_mark_cksum_ptype_rss, \ + R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4156: FILE: drivers/net/cnxk/cn10k_rx.h:1695: +#define NIX_RX_FASTPATH_MODES_208_223 \ + R(reas_sec_ts, R_REAS_F | R_SEC_F | TS_F) \ + R(reas_sec_ts_rss, R_REAS_F | R_SEC_F | TS_F | RSS_F) \ + R(reas_sec_ts_ptype, R_REAS_F | R_SEC_F | TS_F | PTYPE_F) \ + R(reas_sec_ts_ptype_rss, R_REAS_F | R_SEC_F | TS_F | PTYPE_F | RSS_F) \ + R(reas_sec_ts_cksum, R_REAS_F | R_SEC_F | TS_F | CKSUM_F) \ + R(reas_sec_ts_cksum_rss, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | RSS_F) \ + R(reas_sec_ts_cksum_ptype, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_ts_cksum_ptype_rss, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_sec_ts_mark, R_REAS_F | R_SEC_F | TS_F | MARK_F) \ + R(reas_sec_ts_mark_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | RSS_F) \ + R(reas_sec_ts_mark_ptype, R_REAS_F | R_SEC_F | TS_F | MARK_F | PTYPE_F) \ + R(reas_sec_ts_mark_ptype_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_sec_ts_mark_cksum, R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F) \ + R(reas_sec_ts_mark_cksum_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_sec_ts_mark_cksum_ptype, \ + R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_ts_mark_cksum_ptype_rss, \ + R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4176: FILE: drivers/net/cnxk/cn10k_rx.h:1715: +#define NIX_RX_FASTPATH_MODES_224_239 \ + R(reas_sec_vlan, R_REAS_F | R_SEC_F | RX_VLAN_F) \ + R(reas_sec_vlan_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | RSS_F) \ + R(reas_sec_vlan_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | PTYPE_F) \ + R(reas_sec_vlan_ptype_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | PTYPE_F | RSS_F) \ + R(reas_sec_vlan_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F) \ + R(reas_sec_vlan_cksum_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | RSS_F) \ + R(reas_sec_vlan_cksum_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_vlan_cksum_ptype_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_sec_vlan_mark, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F) \ + R(reas_sec_vlan_mark_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | RSS_F) \ + R(reas_sec_vlan_mark_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F) \ + R(reas_sec_vlan_mark_ptype_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_sec_vlan_mark_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F) \ + R(reas_sec_vlan_mark_cksum_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_sec_vlan_mark_cksum_ptype, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_vlan_mark_cksum_ptype_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4199: FILE: drivers/net/cnxk/cn10k_rx.h:1738: +#define NIX_RX_FASTPATH_MODES_240_255 \ + R(reas_sec_vlan_ts, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F) \ + R(reas_sec_vlan_ts_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | RSS_F) \ + R(reas_sec_vlan_ts_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F) \ + R(reas_sec_vlan_ts_ptype_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F | RSS_F) \ + R(reas_sec_vlan_ts_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F) \ + R(reas_sec_vlan_ts_cksum_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | RSS_F) \ + R(reas_sec_vlan_ts_cksum_ptype, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_vlan_ts_cksum_ptype_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F) \ + R(reas_sec_vlan_ts_mark, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F) \ + R(reas_sec_vlan_ts_mark_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | RSS_F) \ + R(reas_sec_vlan_ts_mark_ptype, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F) \ + R(reas_sec_vlan_ts_mark_ptype_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F) \ + R(reas_sec_vlan_ts_mark_cksum, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F) \ + R(reas_sec_vlan_ts_mark_cksum_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F) \ + R(reas_sec_vlan_ts_mark_cksum_ptype, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F) \ + R(reas_sec_vlan_ts_mark_cksum_ptype_rss, \ + R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F) ERROR:TRAILING_WHITESPACE: trailing whitespace #4242: FILE: drivers/net/cnxk/cn10k_rx.h:1781: +^INIX_RX_FASTPATH_MODES_240_255 $ total: 9 errors, 1 warnings, 12 checks, 3367 lines checked