From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw105720 [PATCH] vdpa/sfc: make MCDI memzone name unique
Date: Tue, 11 Jan 2022 00:48:48 -0500 (EST) [thread overview]
Message-ID: <20220111054848.80712314F@noxus.dpdklab.iol.unh.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 2805 bytes --]
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/105720
_apply patch failure_
Submitter: <abhimanyu.saini@xilinx.com>
Date: Tuesday, January 11 2022 05:33:03
Applied on: CommitID:042f5a355a57b31a9f87824173a9d427b21abdb8
Apply patch set 105720 failed:
Checking patch drivers/vdpa/sfc/sfc_vdpa_hw.c...
error: while searching for:
{
uint64_t mcdi_iova;
size_t mcdi_buff_size;
const struct rte_memzone *mz = NULL;
int numa_node = sva->pdev->device.numa_node;
int ret;
mcdi_buff_size = RTE_ALIGN_CEIL(len, PAGE_SIZE);
sfc_vdpa_log_init(sva, "name=%s, len=%zu", name, len);
mz = rte_memzone_reserve_aligned(name, mcdi_buff_size,
numa_node,
RTE_MEMZONE_IOVA_CONTIG,
PAGE_SIZE);
if (mz == NULL) {
sfc_vdpa_err(sva, "cannot reserve memory for %s: len=%#x: %s",
name, (unsigned int)len, rte_strerror(rte_errno));
return -ENOMEM;
}
error: patch failed: drivers/vdpa/sfc/sfc_vdpa_hw.c:25
Applying patch drivers/vdpa/sfc/sfc_vdpa_hw.c with 1 reject...
Rejected hunk #1.
diff a/drivers/vdpa/sfc/sfc_vdpa_hw.c b/drivers/vdpa/sfc/sfc_vdpa_hw.c (rejected hunks)
@@ -25,21 +25,30 @@
{
uint64_t mcdi_iova;
size_t mcdi_buff_size;
+ char mz_name[RTE_MEMZONE_NAMESIZE];
const struct rte_memzone *mz = NULL;
int numa_node = sva->pdev->device.numa_node;
int ret;
mcdi_buff_size = RTE_ALIGN_CEIL(len, PAGE_SIZE);
+ ret = snprintf(mz_name, RTE_MEMZONE_NAMESIZE, "%s_%s",
+ sva->pdev->name, name);
+ if (ret < 0 || ret >= RTE_MEMZONE_NAMESIZE) {
+ sfc_vdpa_err(sva, "%s_%s too long to fit in mz_name",
+ sva->pdev->name, name);
+ return -EINVAL;
+ }
- sfc_vdpa_log_init(sva, "name=%s, len=%zu", name, len);
+ sfc_vdpa_log_init(sva, "name=%s, len=%zu", mz_name, len);
- mz = rte_memzone_reserve_aligned(name, mcdi_buff_size,
+ mz = rte_memzone_reserve_aligned(mz_name, mcdi_buff_size,
numa_node,
RTE_MEMZONE_IOVA_CONTIG,
PAGE_SIZE);
if (mz == NULL) {
sfc_vdpa_err(sva, "cannot reserve memory for %s: len=%#x: %s",
- name, (unsigned int)len, rte_strerror(rte_errno));
+ mz_name, (unsigned int)len,
+ rte_strerror(rte_errno));
return -ENOMEM;
}
https://lab.dpdk.org/results/dashboard/patchsets/20631/
UNH-IOL DPDK Community Lab
next reply other threads:[~2022-01-11 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 5:48 dpdklab [this message]
[not found] <20220111053303.18162-1-asaini@xilinx.com>
2022-01-11 5:34 ` checkpatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111054848.80712314F@noxus.dpdklab.iol.unh.edu \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).