automatic DPDK test reports
 help / color / mirror / Atom feed
* |WARNING| pw106130 [PATCH v2 6/8] net/cnxk: add CN10K template Rx functions to build
       [not found] <20220120145136.7844-6-pbhagavatula@marvell.com>
@ 2022-01-20 14:54 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-01-20 14:54 UTC (permalink / raw)
  To: test-report; +Cc: pbhagavatula

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106130

_coding style issues_


ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#138: FILE: drivers/event/cnxk/cn10k_eventdev.c:289:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#147: FILE: drivers/event/cnxk/cn10k_eventdev.c:295:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#156: FILE: drivers/event/cnxk/cn10k_eventdev.c:301:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_##name,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#167: FILE: drivers/event/cnxk/cn10k_eventdev.c:307:
+	const event_dequeue_burst_t sso_hws_deq_tmo_burst[NIX_RX_OFFLOAD_MAX] =
+		{

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#168: FILE: drivers/event/cnxk/cn10k_eventdev.c:308:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#178: FILE: drivers/event/cnxk/cn10k_eventdev.c:314:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_ca_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#188: FILE: drivers/event/cnxk/cn10k_eventdev.c:320:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_ca_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#197: FILE: drivers/event/cnxk/cn10k_eventdev.c:326:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_ca_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#207: FILE: drivers/event/cnxk/cn10k_eventdev.c:333:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_ca_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#213: FILE: drivers/event/cnxk/cn10k_eventdev.c:339:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_seg_##name,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#223: FILE: drivers/event/cnxk/cn10k_eventdev.c:346:
+	const event_dequeue_burst_t sso_hws_deq_seg_burst[NIX_RX_OFFLOAD_MAX] =
+		{

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#224: FILE: drivers/event/cnxk/cn10k_eventdev.c:347:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#230: FILE: drivers/event/cnxk/cn10k_eventdev.c:353:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#240: FILE: drivers/event/cnxk/cn10k_eventdev.c:360:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#249: FILE: drivers/event/cnxk/cn10k_eventdev.c:366:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_ca_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#259: FILE: drivers/event/cnxk/cn10k_eventdev.c:373:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_ca_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#265: FILE: drivers/event/cnxk/cn10k_eventdev.c:379:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_ca_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#272: FILE: drivers/event/cnxk/cn10k_eventdev.c:386:
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_ca_seg_burst_##name,

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#346: FILE: drivers/event/cnxk/cn10k_worker.h:400:
+#define SSO_DEQ(fn, flags)                                                     \
+	uint16_t __rte_hot fn(void *port, struct rte_event *ev,                \
+			      uint64_t timeout_ticks)                          \
+	{                                                                      \
+		struct cn10k_sso_hws *ws = port;                               \
+                                                                               \
+		RTE_SET_USED(timeout_ticks);                                   \
+		if (ws->swtag_req) {                                           \
+			ws->swtag_req = 0;                                     \
+			cnxk_sso_hws_swtag_wait(ws->base + SSOW_LF_GWS_WQE0);  \
+			return 1;                                              \
+		}                                                              \
+		return cn10k_sso_hws_get_work(ws, ev, flags, ws->lookup_mem);  \
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#351: FILE: drivers/event/cnxk/cn10k_worker.h:405:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#351: FILE: drivers/event/cnxk/cn10k_worker.h:405:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#365: FILE: drivers/event/cnxk/cn10k_worker.h:419:
+#define SSO_DEQ_TMO(fn, flags)                                                 \
+	uint16_t __rte_hot fn(void *port, struct rte_event *ev,                \
+			      uint64_t timeout_ticks)                          \
+	{                                                                      \
+		struct cn10k_sso_hws *ws = port;                               \
+		uint16_t ret = 1;                                              \
+		uint64_t iter;                                                 \
+                                                                               \
+		if (ws->swtag_req) {                                           \
+			ws->swtag_req = 0;                                     \
+			cnxk_sso_hws_swtag_wait(ws->base + SSOW_LF_GWS_WQE0);  \
+			return ret;                                            \
+		}                                                              \
+		ret = cn10k_sso_hws_get_work(ws, ev, flags, ws->lookup_mem);   \
+		for (iter = 1; iter < timeout_ticks && (ret == 0); iter++)     \
+			ret = cn10k_sso_hws_get_work(ws, ev, flags,            \
+						     ws->lookup_mem);          \
+		return ret;                                                    \
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#372: FILE: drivers/event/cnxk/cn10k_worker.h:426:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#372: FILE: drivers/event/cnxk/cn10k_worker.h:426:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#389: FILE: drivers/event/cnxk/cn10k_worker.h:443:
+#define SSO_CMN_DEQ_BURST(fnb, fn, flags)                                      \
+	uint16_t __rte_hot fnb(void *port, struct rte_event ev[],              \
+			       uint16_t nb_events, uint64_t timeout_ticks)     \
+	{                                                                      \
+		RTE_SET_USED(nb_events);                                       \
+		return fn(port, ev, timeout_ticks);                            \
+	}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#397: FILE: drivers/event/cnxk/cn10k_worker.h:451:
+#define SSO_CMN_DEQ_SEG_BURST(fnb, fn, flags)                                  \
+	uint16_t __rte_hot fnb(void *port, struct rte_event ev[],              \
+			       uint16_t nb_events, uint64_t timeout_ticks)     \
+	{                                                                      \
+		RTE_SET_USED(nb_events);                                       \
+		return fn(port, ev, timeout_ticks);                            \
+	}

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1070: FILE: drivers/net/cnxk/cn10k_rx.h:991:
+#define NIX_RX_FASTPATH_MODES_0_15                                             \
+	R(no_offload, NIX_RX_OFFLOAD_NONE)                                     \
+	R(rss, RSS_F)                                                          \
+	R(ptype, PTYPE_F)                                                      \
+	R(ptype_rss, PTYPE_F | RSS_F)                                          \
+	R(cksum, CKSUM_F)                                                      \
+	R(cksum_rss, CKSUM_F | RSS_F)                                          \
+	R(cksum_ptype, CKSUM_F | PTYPE_F)                                      \
+	R(cksum_ptype_rss, CKSUM_F | PTYPE_F | RSS_F)                          \
+	R(mark, MARK_F)                                                        \
+	R(mark_rss, MARK_F | RSS_F)                                            \
+	R(mark_ptype, MARK_F | PTYPE_F)                                        \
+	R(mark_ptype_rss, MARK_F | PTYPE_F | RSS_F)                            \
+	R(mark_cksum, MARK_F | CKSUM_F)                                        \
+	R(mark_cksum_rss, MARK_F | CKSUM_F | RSS_F)                            \
+	R(mark_cksum_ptype, MARK_F | CKSUM_F | PTYPE_F)                        \
+	R(mark_cksum_ptype_rss, MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1088: FILE: drivers/net/cnxk/cn10k_rx.h:1009:
+#define NIX_RX_FASTPATH_MODES_16_31                                            \
+	R(ts, TS_F)                                                            \
+	R(ts_rss, TS_F | RSS_F)                                                \
+	R(ts_ptype, TS_F | PTYPE_F)                                            \
+	R(ts_ptype_rss, TS_F | PTYPE_F | RSS_F)                                \
+	R(ts_cksum, TS_F | CKSUM_F)                                            \
+	R(ts_cksum_rss, TS_F | CKSUM_F | RSS_F)                                \
+	R(ts_cksum_ptype, TS_F | CKSUM_F | PTYPE_F)                            \
+	R(ts_cksum_ptype_rss, TS_F | CKSUM_F | PTYPE_F | RSS_F)                \
+	R(ts_mark, TS_F | MARK_F)                                              \
+	R(ts_mark_rss, TS_F | MARK_F | RSS_F)                                  \
+	R(ts_mark_ptype, TS_F | MARK_F | PTYPE_F)                              \
+	R(ts_mark_ptype_rss, TS_F | MARK_F | PTYPE_F | RSS_F)                  \
+	R(ts_mark_cksum, TS_F | MARK_F | CKSUM_F)                              \
+	R(ts_mark_cksum_rss, TS_F | MARK_F | CKSUM_F | RSS_F)                  \
+	R(ts_mark_cksum_ptype, TS_F | MARK_F | CKSUM_F | PTYPE_F)              \
+	R(ts_mark_cksum_ptype_rss, TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1106: FILE: drivers/net/cnxk/cn10k_rx.h:1027:
+#define NIX_RX_FASTPATH_MODES_32_47                                            \
+	R(vlan, RX_VLAN_F)                                                     \
+	R(vlan_rss, RX_VLAN_F | RSS_F)                                         \
+	R(vlan_ptype, RX_VLAN_F | PTYPE_F)                                     \
+	R(vlan_ptype_rss, RX_VLAN_F | PTYPE_F | RSS_F)                         \
+	R(vlan_cksum, RX_VLAN_F | CKSUM_F)                                     \
+	R(vlan_cksum_rss, RX_VLAN_F | CKSUM_F | RSS_F)                         \
+	R(vlan_cksum_ptype, RX_VLAN_F | CKSUM_F | PTYPE_F)                     \
+	R(vlan_cksum_ptype_rss, RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F)         \
+	R(vlan_mark, RX_VLAN_F | MARK_F)                                       \
+	R(vlan_mark_rss, RX_VLAN_F | MARK_F | RSS_F)                           \
+	R(vlan_mark_ptype, RX_VLAN_F | MARK_F | PTYPE_F)                       \
+	R(vlan_mark_ptype_rss, RX_VLAN_F | MARK_F | PTYPE_F | RSS_F)           \
+	R(vlan_mark_cksum, RX_VLAN_F | MARK_F | CKSUM_F)                       \
+	R(vlan_mark_cksum_rss, RX_VLAN_F | MARK_F | CKSUM_F | RSS_F)           \
+	R(vlan_mark_cksum_ptype, RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F)       \
+	R(vlan_mark_cksum_ptype_rss,                                           \
+	  RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1125: FILE: drivers/net/cnxk/cn10k_rx.h:1046:
+#define NIX_RX_FASTPATH_MODES_48_63                                            \
+	R(vlan_ts, RX_VLAN_F | TS_F)                                           \
+	R(vlan_ts_rss, RX_VLAN_F | TS_F | RSS_F)                               \
+	R(vlan_ts_ptype, RX_VLAN_F | TS_F | PTYPE_F)                           \
+	R(vlan_ts_ptype_rss, RX_VLAN_F | TS_F | PTYPE_F | RSS_F)               \
+	R(vlan_ts_cksum, RX_VLAN_F | TS_F | CKSUM_F)                           \
+	R(vlan_ts_cksum_rss, RX_VLAN_F | TS_F | CKSUM_F | RSS_F)               \
+	R(vlan_ts_cksum_ptype, RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F)           \
+	R(vlan_ts_cksum_ptype_rss,                                             \
+	  RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)                        \
+	R(vlan_ts_mark, RX_VLAN_F | TS_F | MARK_F)                             \
+	R(vlan_ts_mark_rss, RX_VLAN_F | TS_F | MARK_F | RSS_F)                 \
+	R(vlan_ts_mark_ptype, RX_VLAN_F | TS_F | MARK_F | PTYPE_F)             \
+	R(vlan_ts_mark_ptype_rss, RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F) \
+	R(vlan_ts_mark_cksum, RX_VLAN_F | TS_F | MARK_F | CKSUM_F)             \
+	R(vlan_ts_mark_cksum_rss, RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F) \
+	R(vlan_ts_mark_cksum_ptype,                                            \
+	  RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)                       \
+	R(vlan_ts_mark_cksum_ptype_rss,                                        \
+	  RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1146: FILE: drivers/net/cnxk/cn10k_rx.h:1067:
+#define NIX_RX_FASTPATH_MODES_64_79                                            \
+	R(sec, R_SEC_F)                                                        \
+	R(sec_rss, R_SEC_F | RSS_F)                                            \
+	R(sec_ptype, R_SEC_F | PTYPE_F)                                        \
+	R(sec_ptype_rss, R_SEC_F | PTYPE_F | RSS_F)                            \
+	R(sec_cksum, R_SEC_F | CKSUM_F)                                        \
+	R(sec_cksum_rss, R_SEC_F | CKSUM_F | RSS_F)                            \
+	R(sec_cksum_ptype, R_SEC_F | CKSUM_F | PTYPE_F)                        \
+	R(sec_cksum_ptype_rss, R_SEC_F | CKSUM_F | PTYPE_F | RSS_F)            \
+	R(sec_mark, R_SEC_F | MARK_F)                                          \
+	R(sec_mark_rss, R_SEC_F | MARK_F | RSS_F)                              \
+	R(sec_mark_ptype, R_SEC_F | MARK_F | PTYPE_F)                          \
+	R(sec_mark_ptype_rss, R_SEC_F | MARK_F | PTYPE_F | RSS_F)              \
+	R(sec_mark_cksum, R_SEC_F | MARK_F | CKSUM_F)                          \
+	R(sec_mark_cksum_rss, R_SEC_F | MARK_F | CKSUM_F | RSS_F)              \
+	R(sec_mark_cksum_ptype, R_SEC_F | MARK_F | CKSUM_F | PTYPE_F)          \
+	R(sec_mark_cksum_ptype_rss,                                            \
+	  R_SEC_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1165: FILE: drivers/net/cnxk/cn10k_rx.h:1086:
+#define NIX_RX_FASTPATH_MODES_80_95                                            \
+	R(sec_ts, R_SEC_F | TS_F)                                              \
+	R(sec_ts_rss, R_SEC_F | TS_F | RSS_F)                                  \
+	R(sec_ts_ptype, R_SEC_F | TS_F | PTYPE_F)                              \
+	R(sec_ts_ptype_rss, R_SEC_F | TS_F | PTYPE_F | RSS_F)                  \
+	R(sec_ts_cksum, R_SEC_F | TS_F | CKSUM_F)                              \
+	R(sec_ts_cksum_rss, R_SEC_F | TS_F | CKSUM_F | RSS_F)                  \
+	R(sec_ts_cksum_ptype, R_SEC_F | TS_F | CKSUM_F | PTYPE_F)              \
+	R(sec_ts_cksum_ptype_rss, R_SEC_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)  \
+	R(sec_ts_mark, R_SEC_F | TS_F | MARK_F)                                \
+	R(sec_ts_mark_rss, R_SEC_F | TS_F | MARK_F | RSS_F)                    \
+	R(sec_ts_mark_ptype, R_SEC_F | TS_F | MARK_F | PTYPE_F)                \
+	R(sec_ts_mark_ptype_rss, R_SEC_F | TS_F | MARK_F | PTYPE_F | RSS_F)    \
+	R(sec_ts_mark_cksum, R_SEC_F | TS_F | MARK_F | CKSUM_F)                \
+	R(sec_ts_mark_cksum_rss, R_SEC_F | TS_F | MARK_F | CKSUM_F | RSS_F)    \
+	R(sec_ts_mark_cksum_ptype,                                             \
+	  R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)                         \
+	R(sec_ts_mark_cksum_ptype_rss,                                         \
+	  R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1185: FILE: drivers/net/cnxk/cn10k_rx.h:1106:
+#define NIX_RX_FASTPATH_MODES_96_111                                           \
+	R(sec_vlan, R_SEC_F | RX_VLAN_F)                                       \
+	R(sec_vlan_rss, R_SEC_F | RX_VLAN_F | RSS_F)                           \
+	R(sec_vlan_ptype, R_SEC_F | RX_VLAN_F | PTYPE_F)                       \
+	R(sec_vlan_ptype_rss, R_SEC_F | RX_VLAN_F | PTYPE_F | RSS_F)           \
+	R(sec_vlan_cksum, R_SEC_F | RX_VLAN_F | CKSUM_F)                       \
+	R(sec_vlan_cksum_rss, R_SEC_F | RX_VLAN_F | CKSUM_F | RSS_F)           \
+	R(sec_vlan_cksum_ptype, R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F)       \
+	R(sec_vlan_cksum_ptype_rss,                                            \
+	  R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F)                     \
+	R(sec_vlan_mark, R_SEC_F | RX_VLAN_F | MARK_F)                         \
+	R(sec_vlan_mark_rss, R_SEC_F | RX_VLAN_F | MARK_F | RSS_F)             \
+	R(sec_vlan_mark_ptype, R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F)         \
+	R(sec_vlan_mark_ptype_rss,                                             \
+	  R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F | RSS_F)                      \
+	R(sec_vlan_mark_cksum, R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F)         \
+	R(sec_vlan_mark_cksum_rss,                                             \
+	  R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | RSS_F)                      \
+	R(sec_vlan_mark_cksum_ptype,                                           \
+	  R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F)                    \
+	R(sec_vlan_mark_cksum_ptype_rss,                                       \
+	  R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1208: FILE: drivers/net/cnxk/cn10k_rx.h:1129:
+#define NIX_RX_FASTPATH_MODES_112_127                                          \
+	R(sec_vlan_ts, R_SEC_F | RX_VLAN_F | TS_F)                             \
+	R(sec_vlan_ts_rss, R_SEC_F | RX_VLAN_F | TS_F | RSS_F)                 \
+	R(sec_vlan_ts_ptype, R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F)             \
+	R(sec_vlan_ts_ptype_rss, R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F | RSS_F) \
+	R(sec_vlan_ts_cksum, R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F)             \
+	R(sec_vlan_ts_cksum_rss, R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | RSS_F) \
+	R(sec_vlan_ts_cksum_ptype,                                             \
+	  R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F)                      \
+	R(sec_vlan_ts_cksum_ptype_rss,                                         \
+	  R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)              \
+	R(sec_vlan_ts_mark, R_SEC_F | RX_VLAN_F | TS_F | MARK_F)               \
+	R(sec_vlan_ts_mark_rss, R_SEC_F | RX_VLAN_F | TS_F | MARK_F | RSS_F)   \
+	R(sec_vlan_ts_mark_ptype,                                              \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F)                       \
+	R(sec_vlan_ts_mark_ptype_rss,                                          \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F)               \
+	R(sec_vlan_ts_mark_cksum,                                              \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F)                       \
+	R(sec_vlan_ts_mark_cksum_rss,                                          \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F)               \
+	R(sec_vlan_ts_mark_cksum_ptype,                                        \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)             \
+	R(sec_vlan_ts_mark_cksum_ptype_rss,                                    \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1234: FILE: drivers/net/cnxk/cn10k_rx.h:1155:
+#define NIX_RX_FASTPATH_MODES                                                  \
+	NIX_RX_FASTPATH_MODES_0_15                                             \
+	NIX_RX_FASTPATH_MODES_16_31                                            \
+	NIX_RX_FASTPATH_MODES_32_47                                            \
+	NIX_RX_FASTPATH_MODES_48_63                                            \
+	NIX_RX_FASTPATH_MODES_64_79                                            \
+	NIX_RX_FASTPATH_MODES_80_95                                            \
+	NIX_RX_FASTPATH_MODES_96_111                                           \
+	NIX_RX_FASTPATH_MODES_112_127

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#1244: FILE: drivers/net/cnxk/cn10k_rx.h:1165:
+#define R(name, flags)                                                         \
 	uint16_t __rte_noinline __rte_hot cn10k_nix_recv_pkts_##name(          \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);     \
+                                                                               \
 	uint16_t __rte_noinline __rte_hot cn10k_nix_recv_pkts_mseg_##name(     \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);     \
+                                                                               \
 	uint16_t __rte_noinline __rte_hot cn10k_nix_recv_pkts_vec_##name(      \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);     \
+                                                                               \
 	uint16_t __rte_noinline __rte_hot cn10k_nix_recv_pkts_vec_mseg_##name( \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);

ERROR:CODE_INDENT: code indent should use tabs where possible
#1248: FILE: drivers/net/cnxk/cn10k_rx.h:1168:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1248: FILE: drivers/net/cnxk/cn10k_rx.h:1168:
+                                                                               \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1252: FILE: drivers/net/cnxk/cn10k_rx.h:1171:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1252: FILE: drivers/net/cnxk/cn10k_rx.h:1171:
+                                                                               \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1256: FILE: drivers/net/cnxk/cn10k_rx.h:1174:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1256: FILE: drivers/net/cnxk/cn10k_rx.h:1174:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1263: FILE: drivers/net/cnxk/cn10k_rx.h:1181:
+#define NIX_RX_RECV(fn, flags)                                                 \
+	uint16_t __rte_noinline __rte_hot fn(                                  \
+		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts)      \
+	{                                                                      \
+		return cn10k_nix_recv_pkts(rx_queue, rx_pkts, pkts, (flags));  \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'flags' may be better as '(flags)' to avoid precedence issues
#1270: FILE: drivers/net/cnxk/cn10k_rx.h:1188:
+#define NIX_RX_RECV_MSEG(fn, flags) NIX_RX_RECV(fn, flags | NIX_RX_MULTI_SEG_F)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1272: FILE: drivers/net/cnxk/cn10k_rx.h:1190:
+#define NIX_RX_RECV_VEC(fn, flags)                                             \
+	uint16_t __rte_noinline __rte_hot fn(                                  \
+		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts)      \
+	{                                                                      \
+		return cn10k_nix_recv_pkts_vector(rx_queue, rx_pkts, pkts,     \
+						  (flags), NULL, NULL, 0);     \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'flags' may be better as '(flags)' to avoid precedence issues
#1280: FILE: drivers/net/cnxk/cn10k_rx.h:1198:
+#define NIX_RX_RECV_VEC_MSEG(fn, flags)                                        \
+	NIX_RX_RECV_VEC(fn, flags | NIX_RX_MULTI_SEG_F)

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#1339: FILE: drivers/net/cnxk/cn10k_rx_select.c:27:
+#define R(name, flags) [flags] = cn10k_nix_recv_pkts_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#1346: FILE: drivers/net/cnxk/cn10k_rx_select.c:34:
+#define R(name, flags) [flags] = cn10k_nix_recv_pkts_mseg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#1353: FILE: drivers/net/cnxk/cn10k_rx_select.c:41:
+#define R(name, flags) [flags] = cn10k_nix_recv_pkts_vec_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#1360: FILE: drivers/net/cnxk/cn10k_rx_select.c:48:
+#define R(name, flags) [flags] = cn10k_nix_recv_pkts_vec_mseg_##name,

total: 36 errors, 12 warnings, 2 checks, 1029 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-20 14:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220120145136.7844-6-pbhagavatula@marvell.com>
2022-01-20 14:54 ` |WARNING| pw106130 [PATCH v2 6/8] net/cnxk: add CN10K template Rx functions to build checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).