automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: <pbhagavatula@marvell.com>
Subject: |WARNING| pw106126 [PATCH v2 2/8] net/cnxk: add CN9K template Rx functions to build
Date: Thu, 20 Jan 2022 15:55:18 +0100 (CET)	[thread overview]
Message-ID: <20220120145518.6414812091F@dpdk.org> (raw)
In-Reply-To: <20220120145136.7844-2-pbhagavatula@marvell.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106126

_coding style issues_


ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#146: FILE: drivers/event/cnxk/cn9k_eventdev.c:314:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#155: FILE: drivers/event/cnxk/cn9k_eventdev.c:320:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#164: FILE: drivers/event/cnxk/cn9k_eventdev.c:326:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_##name,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#175: FILE: drivers/event/cnxk/cn9k_eventdev.c:332:
+	const event_dequeue_burst_t sso_hws_deq_tmo_burst[NIX_RX_OFFLOAD_MAX] =
+		{

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#176: FILE: drivers/event/cnxk/cn9k_eventdev.c:333:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#186: FILE: drivers/event/cnxk/cn9k_eventdev.c:339:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_ca_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#196: FILE: drivers/event/cnxk/cn9k_eventdev.c:345:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_ca_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#205: FILE: drivers/event/cnxk/cn9k_eventdev.c:351:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_ca_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#215: FILE: drivers/event/cnxk/cn9k_eventdev.c:358:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_ca_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#221: FILE: drivers/event/cnxk/cn9k_eventdev.c:364:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_seg_##name,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#230: FILE: drivers/event/cnxk/cn9k_eventdev.c:370:
+	const event_dequeue_burst_t sso_hws_deq_seg_burst[NIX_RX_OFFLOAD_MAX] =
+		{

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#231: FILE: drivers/event/cnxk/cn9k_eventdev.c:371:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#237: FILE: drivers/event/cnxk/cn9k_eventdev.c:377:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#247: FILE: drivers/event/cnxk/cn9k_eventdev.c:384:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#257: FILE: drivers/event/cnxk/cn9k_eventdev.c:390:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_ca_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#267: FILE: drivers/event/cnxk/cn9k_eventdev.c:397:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_ca_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#278: FILE: drivers/event/cnxk/cn9k_eventdev.c:403:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_ca_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#288: FILE: drivers/event/cnxk/cn9k_eventdev.c:410:
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_ca_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#295: FILE: drivers/event/cnxk/cn9k_eventdev.c:417:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_##name,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#304: FILE: drivers/event/cnxk/cn9k_eventdev.c:423:
+	const event_dequeue_burst_t sso_hws_dual_deq_burst[NIX_RX_OFFLOAD_MAX] =
+		{

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#305: FILE: drivers/event/cnxk/cn9k_eventdev.c:424:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#311: FILE: drivers/event/cnxk/cn9k_eventdev.c:430:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#321: FILE: drivers/event/cnxk/cn9k_eventdev.c:437:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#331: FILE: drivers/event/cnxk/cn9k_eventdev.c:443:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_ca_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#341: FILE: drivers/event/cnxk/cn9k_eventdev.c:450:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_ca_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#351: FILE: drivers/event/cnxk/cn9k_eventdev.c:456:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_ca_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#361: FILE: drivers/event/cnxk/cn9k_eventdev.c:463:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_ca_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#370: FILE: drivers/event/cnxk/cn9k_eventdev.c:469:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#381: FILE: drivers/event/cnxk/cn9k_eventdev.c:476:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#390: FILE: drivers/event/cnxk/cn9k_eventdev.c:482:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#401: FILE: drivers/event/cnxk/cn9k_eventdev.c:489:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_seg_burst_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#407: FILE: drivers/event/cnxk/cn9k_eventdev.c:495:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_ca_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#414: FILE: drivers/event/cnxk/cn9k_eventdev.c:502:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_ca_seg_burst_##name,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#420: FILE: drivers/event/cnxk/cn9k_eventdev.c:508:
+	const event_dequeue_t sso_hws_dual_deq_tmo_ca_seg[NIX_RX_OFFLOAD_MAX] =
+		{

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#421: FILE: drivers/event/cnxk/cn9k_eventdev.c:509:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_ca_seg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#428: FILE: drivers/event/cnxk/cn9k_eventdev.c:516:
+#define R(name, flags) [flags] = cn9k_sso_hws_dual_deq_tmo_ca_seg_burst_##name,

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#534: FILE: drivers/event/cnxk/cn9k_worker.h:433:
+#define SSO_DEQ(fn, flags)                                                     \
+	uint16_t __rte_hot fn(void *port, struct rte_event *ev,                \
+			      uint64_t timeout_ticks)                          \
+	{                                                                      \
+		struct cn9k_sso_hws *ws = port;                                \
+                                                                               \
+		RTE_SET_USED(timeout_ticks);                                   \
+		if (ws->swtag_req) {                                           \
+			ws->swtag_req = 0;                                     \
+			cnxk_sso_hws_swtag_wait(ws->base + SSOW_LF_GWS_TAG);   \
+			return 1;                                              \
+		}                                                              \
+		return cn9k_sso_hws_get_work(ws, ev, flags, ws->lookup_mem);   \
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#539: FILE: drivers/event/cnxk/cn9k_worker.h:438:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#539: FILE: drivers/event/cnxk/cn9k_worker.h:438:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#553: FILE: drivers/event/cnxk/cn9k_worker.h:452:
+#define SSO_DEQ_TMO(fn, flags)                                                 \
+	uint16_t __rte_hot fn(void *port, struct rte_event *ev,                \
+			      uint64_t timeout_ticks)                          \
+	{                                                                      \
+		struct cn9k_sso_hws *ws = port;                                \
+		uint16_t ret = 1;                                              \
+		uint64_t iter;                                                 \
+                                                                               \
+		if (ws->swtag_req) {                                           \
+			ws->swtag_req = 0;                                     \
+			cnxk_sso_hws_swtag_wait(ws->base + SSOW_LF_GWS_TAG);   \
+			return ret;                                            \
+		}                                                              \
+		ret = cn9k_sso_hws_get_work(ws, ev, flags, ws->lookup_mem);    \
+		for (iter = 1; iter < timeout_ticks && (ret == 0); iter++)     \
+			ret = cn9k_sso_hws_get_work(ws, ev, flags,             \
+						    ws->lookup_mem);           \
+		return ret;                                                    \
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#560: FILE: drivers/event/cnxk/cn9k_worker.h:459:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#560: FILE: drivers/event/cnxk/cn9k_worker.h:459:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#608: FILE: drivers/event/cnxk/cn9k_worker.h:521:
+#define SSO_DUAL_DEQ(fn, flags)                                                \
+	uint16_t __rte_hot fn(void *port, struct rte_event *ev,                \
+			      uint64_t timeout_ticks)                          \
+	{                                                                      \
+		struct cn9k_sso_hws_dual *dws = port;                          \
+		uint16_t gw;                                                   \
+                                                                               \
+		RTE_SET_USED(timeout_ticks);                                   \
+		if (dws->swtag_req) {                                          \
+			dws->swtag_req = 0;                                    \
+			cnxk_sso_hws_swtag_wait(dws->base[!dws->vws] +         \
+						SSOW_LF_GWS_TAG);              \
+			return 1;                                              \
+		}                                                              \
+		gw = cn9k_sso_hws_dual_get_work(                               \
+			dws->base[dws->vws], dws->base[!dws->vws], ev, flags,  \
+			dws->lookup_mem, dws->tstamp);                         \
+		dws->vws = !dws->vws;                                          \
+		return gw;                                                     \
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#614: FILE: drivers/event/cnxk/cn9k_worker.h:527:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#614: FILE: drivers/event/cnxk/cn9k_worker.h:527:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#634: FILE: drivers/event/cnxk/cn9k_worker.h:547:
+#define SSO_DUAL_DEQ_TMO(fn, flags)                                            \
+	uint16_t __rte_hot fn(void *port, struct rte_event *ev,                \
+			      uint64_t timeout_ticks)                          \
+	{                                                                      \
+		struct cn9k_sso_hws_dual *dws = port;                          \
+		uint16_t ret = 1;                                              \
+		uint64_t iter;                                                 \
+                                                                               \
+		if (dws->swtag_req) {                                          \
+			dws->swtag_req = 0;                                    \
+			cnxk_sso_hws_swtag_wait(dws->base[!dws->vws] +         \
+						SSOW_LF_GWS_TAG);              \
+			return ret;                                            \
+		}                                                              \
+		ret = cn9k_sso_hws_dual_get_work(                              \
+			dws->base[dws->vws], dws->base[!dws->vws], ev, flags,  \
+			dws->lookup_mem, dws->tstamp);                         \
+		dws->vws = !dws->vws;                                          \
+		for (iter = 1; iter < timeout_ticks && (ret == 0); iter++) {   \
+			ret = cn9k_sso_hws_dual_get_work(                      \
+				dws->base[dws->vws], dws->base[!dws->vws], ev, \
+				flags, dws->lookup_mem, dws->tstamp);          \
+			dws->vws = !dws->vws;                                  \
+		}                                                              \
+		return ret;                                                    \
+	}

ERROR:CODE_INDENT: code indent should use tabs where possible
#641: FILE: drivers/event/cnxk/cn9k_worker.h:554:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#641: FILE: drivers/event/cnxk/cn9k_worker.h:554:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#668: FILE: drivers/event/cnxk/cn9k_worker.h:581:
+#define SSO_CMN_DEQ_BURST(fnb, fn, flags)                                      \
+	uint16_t __rte_hot fnb(void *port, struct rte_event ev[],              \
+			       uint16_t nb_events, uint64_t timeout_ticks)     \
+	{                                                                      \
+		RTE_SET_USED(nb_events);                                       \
+		return fn(port, ev, timeout_ticks);                            \
+	}

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#676: FILE: drivers/event/cnxk/cn9k_worker.h:589:
+#define SSO_CMN_DEQ_SEG_BURST(fnb, fn, flags)                                  \
+	uint16_t __rte_hot fnb(void *port, struct rte_event ev[],              \
+			       uint16_t nb_events, uint64_t timeout_ticks)     \
+	{                                                                      \
+		RTE_SET_USED(nb_events);                                       \
+		return fn(port, ev, timeout_ticks);                            \
+	}

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1752: FILE: drivers/net/cnxk/cn9k_rx.h:857:
+#define NIX_RX_FASTPATH_MODES_0_15                                             \
+	R(no_offload, NIX_RX_OFFLOAD_NONE)                                     \
+	R(rss, RSS_F)                                                          \
+	R(ptype, PTYPE_F)                                                      \
+	R(ptype_rss, PTYPE_F | RSS_F)                                          \
+	R(cksum, CKSUM_F)                                                      \
+	R(cksum_rss, CKSUM_F | RSS_F)                                          \
+	R(cksum_ptype, CKSUM_F | PTYPE_F)                                      \
+	R(cksum_ptype_rss, CKSUM_F | PTYPE_F | RSS_F)                          \
+	R(mark, MARK_F)                                                        \
+	R(mark_rss, MARK_F | RSS_F)                                            \
+	R(mark_ptype, MARK_F | PTYPE_F)                                        \
+	R(mark_ptype_rss, MARK_F | PTYPE_F | RSS_F)                            \
+	R(mark_cksum, MARK_F | CKSUM_F)                                        \
+	R(mark_cksum_rss, MARK_F | CKSUM_F | RSS_F)                            \
+	R(mark_cksum_ptype, MARK_F | CKSUM_F | PTYPE_F)                        \
+	R(mark_cksum_ptype_rss, MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1770: FILE: drivers/net/cnxk/cn9k_rx.h:875:
+#define NIX_RX_FASTPATH_MODES_16_31                                            \
+	R(ts, TS_F)                                                            \
+	R(ts_rss, TS_F | RSS_F)                                                \
+	R(ts_ptype, TS_F | PTYPE_F)                                            \
+	R(ts_ptype_rss, TS_F | PTYPE_F | RSS_F)                                \
+	R(ts_cksum, TS_F | CKSUM_F)                                            \
+	R(ts_cksum_rss, TS_F | CKSUM_F | RSS_F)                                \
+	R(ts_cksum_ptype, TS_F | CKSUM_F | PTYPE_F)                            \
+	R(ts_cksum_ptype_rss, TS_F | CKSUM_F | PTYPE_F | RSS_F)                \
+	R(ts_mark, TS_F | MARK_F)                                              \
+	R(ts_mark_rss, TS_F | MARK_F | RSS_F)                                  \
+	R(ts_mark_ptype, TS_F | MARK_F | PTYPE_F)                              \
+	R(ts_mark_ptype_rss, TS_F | MARK_F | PTYPE_F | RSS_F)                  \
+	R(ts_mark_cksum, TS_F | MARK_F | CKSUM_F)                              \
+	R(ts_mark_cksum_rss, TS_F | MARK_F | CKSUM_F | RSS_F)                  \
+	R(ts_mark_cksum_ptype, TS_F | MARK_F | CKSUM_F | PTYPE_F)              \
+	R(ts_mark_cksum_ptype_rss, TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1788: FILE: drivers/net/cnxk/cn9k_rx.h:893:
+#define NIX_RX_FASTPATH_MODES_32_47                                            \
+	R(vlan, RX_VLAN_F)                                                     \
+	R(vlan_rss, RX_VLAN_F | RSS_F)                                         \
+	R(vlan_ptype, RX_VLAN_F | PTYPE_F)                                     \
+	R(vlan_ptype_rss, RX_VLAN_F | PTYPE_F | RSS_F)                         \
+	R(vlan_cksum, RX_VLAN_F | CKSUM_F)                                     \
+	R(vlan_cksum_rss, RX_VLAN_F | CKSUM_F | RSS_F)                         \
+	R(vlan_cksum_ptype, RX_VLAN_F | CKSUM_F | PTYPE_F)                     \
+	R(vlan_cksum_ptype_rss, RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F)         \
+	R(vlan_mark, RX_VLAN_F | MARK_F)                                       \
+	R(vlan_mark_rss, RX_VLAN_F | MARK_F | RSS_F)                           \
+	R(vlan_mark_ptype, RX_VLAN_F | MARK_F | PTYPE_F)                       \
+	R(vlan_mark_ptype_rss, RX_VLAN_F | MARK_F | PTYPE_F | RSS_F)           \
+	R(vlan_mark_cksum, RX_VLAN_F | MARK_F | CKSUM_F)                       \
+	R(vlan_mark_cksum_rss, RX_VLAN_F | MARK_F | CKSUM_F | RSS_F)           \
+	R(vlan_mark_cksum_ptype, RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F)       \
+	R(vlan_mark_cksum_ptype_rss,                                           \
+	  RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1807: FILE: drivers/net/cnxk/cn9k_rx.h:912:
+#define NIX_RX_FASTPATH_MODES_48_63                                            \
+	R(vlan_ts, RX_VLAN_F | TS_F)                                           \
+	R(vlan_ts_rss, RX_VLAN_F | TS_F | RSS_F)                               \
+	R(vlan_ts_ptype, RX_VLAN_F | TS_F | PTYPE_F)                           \
+	R(vlan_ts_ptype_rss, RX_VLAN_F | TS_F | PTYPE_F | RSS_F)               \
+	R(vlan_ts_cksum, RX_VLAN_F | TS_F | CKSUM_F)                           \
+	R(vlan_ts_cksum_rss, RX_VLAN_F | TS_F | CKSUM_F | RSS_F)               \
+	R(vlan_ts_cksum_ptype, RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F)           \
+	R(vlan_ts_cksum_ptype_rss,                                             \
+	  RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)                        \
+	R(vlan_ts_mark, RX_VLAN_F | TS_F | MARK_F)                             \
+	R(vlan_ts_mark_rss, RX_VLAN_F | TS_F | MARK_F | RSS_F)                 \
+	R(vlan_ts_mark_ptype, RX_VLAN_F | TS_F | MARK_F | PTYPE_F)             \
+	R(vlan_ts_mark_ptype_rss, RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F) \
+	R(vlan_ts_mark_cksum, RX_VLAN_F | TS_F | MARK_F | CKSUM_F)             \
+	R(vlan_ts_mark_cksum_rss, RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F) \
+	R(vlan_ts_mark_cksum_ptype,                                            \
+	  RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)                       \
+	R(vlan_ts_mark_cksum_ptype_rss,                                        \
+	  RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1828: FILE: drivers/net/cnxk/cn9k_rx.h:933:
+#define NIX_RX_FASTPATH_MODES_64_79                                            \
+	R(sec, R_SEC_F)                                                        \
+	R(sec_rss, R_SEC_F | RSS_F)                                            \
+	R(sec_ptype, R_SEC_F | PTYPE_F)                                        \
+	R(sec_ptype_rss, R_SEC_F | PTYPE_F | RSS_F)                            \
+	R(sec_cksum, R_SEC_F | CKSUM_F)                                        \
+	R(sec_cksum_rss, R_SEC_F | CKSUM_F | RSS_F)                            \
+	R(sec_cksum_ptype, R_SEC_F | CKSUM_F | PTYPE_F)                        \
+	R(sec_cksum_ptype_rss, R_SEC_F | CKSUM_F | PTYPE_F | RSS_F)            \
+	R(sec_mark, R_SEC_F | MARK_F)                                          \
+	R(sec_mark_rss, R_SEC_F | MARK_F | RSS_F)                              \
+	R(sec_mark_ptype, R_SEC_F | MARK_F | PTYPE_F)                          \
+	R(sec_mark_ptype_rss, R_SEC_F | MARK_F | PTYPE_F | RSS_F)              \
+	R(sec_mark_cksum, R_SEC_F | MARK_F | CKSUM_F)                          \
+	R(sec_mark_cksum_rss, R_SEC_F | MARK_F | CKSUM_F | RSS_F)              \
+	R(sec_mark_cksum_ptype, R_SEC_F | MARK_F | CKSUM_F | PTYPE_F)          \
+	R(sec_mark_cksum_ptype_rss,                                            \
+	  R_SEC_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1847: FILE: drivers/net/cnxk/cn9k_rx.h:952:
+#define NIX_RX_FASTPATH_MODES_80_95                                            \
+	R(sec_ts, R_SEC_F | TS_F)                                              \
+	R(sec_ts_rss, R_SEC_F | TS_F | RSS_F)                                  \
+	R(sec_ts_ptype, R_SEC_F | TS_F | PTYPE_F)                              \
+	R(sec_ts_ptype_rss, R_SEC_F | TS_F | PTYPE_F | RSS_F)                  \
+	R(sec_ts_cksum, R_SEC_F | TS_F | CKSUM_F)                              \
+	R(sec_ts_cksum_rss, R_SEC_F | TS_F | CKSUM_F | RSS_F)                  \
+	R(sec_ts_cksum_ptype, R_SEC_F | TS_F | CKSUM_F | PTYPE_F)              \
+	R(sec_ts_cksum_ptype_rss, R_SEC_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)  \
+	R(sec_ts_mark, R_SEC_F | TS_F | MARK_F)                                \
+	R(sec_ts_mark_rss, R_SEC_F | TS_F | MARK_F | RSS_F)                    \
+	R(sec_ts_mark_ptype, R_SEC_F | TS_F | MARK_F | PTYPE_F)                \
+	R(sec_ts_mark_ptype_rss, R_SEC_F | TS_F | MARK_F | PTYPE_F | RSS_F)    \
+	R(sec_ts_mark_cksum, R_SEC_F | TS_F | MARK_F | CKSUM_F)                \
+	R(sec_ts_mark_cksum_rss, R_SEC_F | TS_F | MARK_F | CKSUM_F | RSS_F)    \
+	R(sec_ts_mark_cksum_ptype,                                             \
+	  R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)                         \
+	R(sec_ts_mark_cksum_ptype_rss,                                         \
+	  R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1867: FILE: drivers/net/cnxk/cn9k_rx.h:972:
+#define NIX_RX_FASTPATH_MODES_96_111                                           \
+	R(sec_vlan, R_SEC_F | RX_VLAN_F)                                       \
+	R(sec_vlan_rss, R_SEC_F | RX_VLAN_F | RSS_F)                           \
+	R(sec_vlan_ptype, R_SEC_F | RX_VLAN_F | PTYPE_F)                       \
+	R(sec_vlan_ptype_rss, R_SEC_F | RX_VLAN_F | PTYPE_F | RSS_F)           \
+	R(sec_vlan_cksum, R_SEC_F | RX_VLAN_F | CKSUM_F)                       \
+	R(sec_vlan_cksum_rss, R_SEC_F | RX_VLAN_F | CKSUM_F | RSS_F)           \
+	R(sec_vlan_cksum_ptype, R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F)       \
+	R(sec_vlan_cksum_ptype_rss,                                            \
+	  R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F)                     \
+	R(sec_vlan_mark, R_SEC_F | RX_VLAN_F | MARK_F)                         \
+	R(sec_vlan_mark_rss, R_SEC_F | RX_VLAN_F | MARK_F | RSS_F)             \
+	R(sec_vlan_mark_ptype, R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F)         \
+	R(sec_vlan_mark_ptype_rss,                                             \
+	  R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F | RSS_F)                      \
+	R(sec_vlan_mark_cksum, R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F)         \
+	R(sec_vlan_mark_cksum_rss,                                             \
+	  R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | RSS_F)                      \
+	R(sec_vlan_mark_cksum_ptype,                                           \
+	  R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F)                    \
+	R(sec_vlan_mark_cksum_ptype_rss,                                       \
+	  R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1890: FILE: drivers/net/cnxk/cn9k_rx.h:995:
+#define NIX_RX_FASTPATH_MODES_112_127                                          \
+	R(sec_vlan_ts, R_SEC_F | RX_VLAN_F | TS_F)                             \
+	R(sec_vlan_ts_rss, R_SEC_F | RX_VLAN_F | TS_F | RSS_F)                 \
+	R(sec_vlan_ts_ptype, R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F)             \
+	R(sec_vlan_ts_ptype_rss, R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F | RSS_F) \
+	R(sec_vlan_ts_cksum, R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F)             \
+	R(sec_vlan_ts_cksum_rss, R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | RSS_F) \
+	R(sec_vlan_ts_cksum_ptype,                                             \
+	  R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F)                      \
+	R(sec_vlan_ts_cksum_ptype_rss,                                         \
+	  R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)              \
+	R(sec_vlan_ts_mark, R_SEC_F | RX_VLAN_F | TS_F | MARK_F)               \
+	R(sec_vlan_ts_mark_rss, R_SEC_F | RX_VLAN_F | TS_F | MARK_F | RSS_F)   \
+	R(sec_vlan_ts_mark_ptype,                                              \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F)                       \
+	R(sec_vlan_ts_mark_ptype_rss,                                          \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F)               \
+	R(sec_vlan_ts_mark_cksum,                                              \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F)                       \
+	R(sec_vlan_ts_mark_cksum_rss,                                          \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F)               \
+	R(sec_vlan_ts_mark_cksum_ptype,                                        \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)             \
+	R(sec_vlan_ts_mark_cksum_ptype_rss,                                    \
+	  R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1916: FILE: drivers/net/cnxk/cn9k_rx.h:1021:
+#define NIX_RX_FASTPATH_MODES                                                  \
+	NIX_RX_FASTPATH_MODES_0_15                                             \
+	NIX_RX_FASTPATH_MODES_16_31                                            \
+	NIX_RX_FASTPATH_MODES_32_47                                            \
+	NIX_RX_FASTPATH_MODES_48_63                                            \
+	NIX_RX_FASTPATH_MODES_64_79                                            \
+	NIX_RX_FASTPATH_MODES_80_95                                            \
+	NIX_RX_FASTPATH_MODES_96_111                                           \
+	NIX_RX_FASTPATH_MODES_112_127

WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#1926: FILE: drivers/net/cnxk/cn9k_rx.h:1031:
+#define R(name, flags)                                                         \
 	uint16_t __rte_noinline __rte_hot cn9k_nix_recv_pkts_##name(           \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);     \
+                                                                               \
 	uint16_t __rte_noinline __rte_hot cn9k_nix_recv_pkts_mseg_##name(      \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);     \
+                                                                               \
 	uint16_t __rte_noinline __rte_hot cn9k_nix_recv_pkts_vec_##name(       \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);     \
+                                                                               \
 	uint16_t __rte_noinline __rte_hot cn9k_nix_recv_pkts_vec_mseg_##name(  \
 		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts);

ERROR:CODE_INDENT: code indent should use tabs where possible
#1930: FILE: drivers/net/cnxk/cn9k_rx.h:1034:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1930: FILE: drivers/net/cnxk/cn9k_rx.h:1034:
+                                                                               \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1934: FILE: drivers/net/cnxk/cn9k_rx.h:1037:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1934: FILE: drivers/net/cnxk/cn9k_rx.h:1037:
+                                                                               \$

ERROR:CODE_INDENT: code indent should use tabs where possible
#1938: FILE: drivers/net/cnxk/cn9k_rx.h:1040:
+                                                                               \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1938: FILE: drivers/net/cnxk/cn9k_rx.h:1040:
+                                                                               \$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1945: FILE: drivers/net/cnxk/cn9k_rx.h:1047:
+#define NIX_RX_RECV(fn, flags)                                                 \
+	uint16_t __rte_noinline __rte_hot fn(                                  \
+		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts)      \
+	{                                                                      \
+		return cn9k_nix_recv_pkts(rx_queue, rx_pkts, pkts, (flags));   \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'flags' may be better as '(flags)' to avoid precedence issues
#1952: FILE: drivers/net/cnxk/cn9k_rx.h:1054:
+#define NIX_RX_RECV_MSEG(fn, flags) NIX_RX_RECV(fn, flags | NIX_RX_MULTI_SEG_F)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1954: FILE: drivers/net/cnxk/cn9k_rx.h:1056:
+#define NIX_RX_RECV_VEC(fn, flags)                                             \
+	uint16_t __rte_noinline __rte_hot fn(                                  \
+		void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts)      \
+	{                                                                      \
+		return cn9k_nix_recv_pkts_vector(rx_queue, rx_pkts, pkts,      \
+						 (flags));                     \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'flags' may be better as '(flags)' to avoid precedence issues
#1962: FILE: drivers/net/cnxk/cn9k_rx.h:1064:
+#define NIX_RX_RECV_VEC_MSEG(fn, flags)                                        \
+	NIX_RX_RECV_VEC(fn, flags | NIX_RX_MULTI_SEG_F)

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#2021: FILE: drivers/net/cnxk/cn9k_rx_select.c:27:
+#define R(name, flags) [flags] = cn9k_nix_recv_pkts_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#2028: FILE: drivers/net/cnxk/cn9k_rx_select.c:34:
+#define R(name, flags) [flags] = cn9k_nix_recv_pkts_mseg_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#2035: FILE: drivers/net/cnxk/cn9k_rx_select.c:41:
+#define R(name, flags) [flags] = cn9k_nix_recv_pkts_vec_##name,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#2042: FILE: drivers/net/cnxk/cn9k_rx_select.c:48:
+#define R(name, flags) [flags] = cn9k_nix_recv_pkts_vec_mseg_##name,

total: 56 errors, 16 warnings, 2 checks, 1433 lines checked

           reply	other threads:[~2022-01-20 14:55 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220120145136.7844-2-pbhagavatula@marvell.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220120145518.6414812091F@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=pbhagavatula@marvell.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).