From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EDBC5A04A6
	for <public@inbox.dpdk.org>; Thu, 27 Jan 2022 15:52:39 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E9762427F3;
	Thu, 27 Jan 2022 15:52:39 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 649CF427FA
 for <test-report@dpdk.org>; Thu, 27 Jan 2022 15:52:38 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 52A3B120715; Thu, 27 Jan 2022 15:52:38 +0100 (CET)
Subject: |WARNING| pw106611 [PATCH 4/5] examples/fips_validation: allow json
 file as input
In-Reply-To: <20220127145142.86742-5-blo@iol.unh.edu>
References: <20220127145142.86742-5-blo@iol.unh.edu>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Brandon Lo <blo@iol.unh.edu>
Message-Id: <20220127145238.52A3B120715@dpdk.org>
Date: Thu, 27 Jan 2022 15:52:38 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106611

_coding style issues_


ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#138: FILE: examples/fips_validation/main.c:447:
+		if (use_json) json_decref(json_info.json_root);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#171: FILE: examples/fips_validation/main.c:1259:
+	if (info.file_type != FIPS_TYPE_JSON) fips_test_write_one_case();

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#188: FILE: examples/fips_validation/main.c:1294:
+	if (info.file_type != FIPS_TYPE_JSON) fprintf(info.fp_wr, "
");

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#257: FILE: examples/fips_validation/main.c:1951:
+	switch (info.algo) {
+		case FIPS_TEST_ALGO_AES_GCM:
[...]
+		default:

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#264: FILE: examples/fips_validation/main.c:1958:
+	if (ret < 0) return ret;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#267: FILE: examples/fips_validation/main.c:1961:
+	if (ret < 0) return ret;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#270: FILE: examples/fips_validation/main.c:1964:
+	if (ret < 0) return ret;

total: 7 errors, 0 warnings, 252 lines checked