* |WARNING| pw106610 [PATCH 3/5] examples/fips_validation: add json parsing
[not found] <20220127145142.86742-4-blo@iol.unh.edu>
@ 2022-01-27 14:52 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-01-27 14:52 UTC (permalink / raw)
To: test-report; +Cc: Brandon Lo
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106610
_coding style issues_
WARNING:TYPO_SPELLING: 'PERFIX' may be misspelled - perhaps 'PREFIX'?
#93: FILE: examples/fips_validation/fips_validation.c:279:
+ else if (strstr(path, JSON_FILE_PERFIX))
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#124: FILE: examples/fips_validation/fips_validation.c:349:
+ if (info.file_type == FIPS_TYPE_JSON) return 0;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#141: FILE: examples/fips_validation/fips_validation.c:459:
+ if (strstr(algo_str, "AES-GCM")) info.algo = FIPS_TEST_ALGO_AES_GCM;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#142: FILE: examples/fips_validation/fips_validation.c:460:
+ else return -EINVAL;
WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#155: FILE: examples/fips_validation/fips_validation.c:473:
+ json_t *param = json_object_get(json_info.json_test_group, info.interim_callbacks[i].key);
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#159: FILE: examples/fips_validation/fips_validation.c:477:
+ /* First argument is blank because the key
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#159: FILE: examples/fips_validation/fips_validation.c:477:
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#184: FILE: examples/fips_validation/fips_validation.c:502:
+ /* First argument is blank because the key
+ is not included in the string being parsed. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#184: FILE: examples/fips_validation/fips_validation.c:502:
+ is not included in the string being parsed. */
total: 3 errors, 6 warnings, 108 lines checked
Warning in examples/fips_validation/fips_validation.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t
Warning in examples/fips_validation/fips_validation.c:
Declaring a variable inside for()
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-01-27 14:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220127145142.86742-4-blo@iol.unh.edu>
2022-01-27 14:52 ` |WARNING| pw106610 [PATCH 3/5] examples/fips_validation: add json parsing checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).