From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A84FA04A6 for ; Thu, 27 Jan 2022 15:52:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06EB8427E1; Thu, 27 Jan 2022 15:52:43 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 7CC35427E1 for ; Thu, 27 Jan 2022 15:52:40 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 7026D120715; Thu, 27 Jan 2022 15:52:40 +0100 (CET) Subject: |WARNING| pw106610 [PATCH 3/5] examples/fips_validation: add json parsing In-Reply-To: <20220127145142.86742-4-blo@iol.unh.edu> References: <20220127145142.86742-4-blo@iol.unh.edu> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Brandon Lo Message-Id: <20220127145240.7026D120715@dpdk.org> Date: Thu, 27 Jan 2022 15:52:40 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/106610 _coding style issues_ WARNING:TYPO_SPELLING: 'PERFIX' may be misspelled - perhaps 'PREFIX'? #93: FILE: examples/fips_validation/fips_validation.c:279: + else if (strstr(path, JSON_FILE_PERFIX)) ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #124: FILE: examples/fips_validation/fips_validation.c:349: + if (info.file_type == FIPS_TYPE_JSON) return 0; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #141: FILE: examples/fips_validation/fips_validation.c:459: + if (strstr(algo_str, "AES-GCM")) info.algo = FIPS_TEST_ALGO_AES_GCM; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #142: FILE: examples/fips_validation/fips_validation.c:460: + else return -EINVAL; WARNING:LONG_LINE: line length of 114 exceeds 100 columns #155: FILE: examples/fips_validation/fips_validation.c:473: + json_t *param = json_object_get(json_info.json_test_group, info.interim_callbacks[i].key); WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #159: FILE: examples/fips_validation/fips_validation.c:477: + /* First argument is blank because the key + is not included in the string being parsed. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #159: FILE: examples/fips_validation/fips_validation.c:477: + is not included in the string being parsed. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #184: FILE: examples/fips_validation/fips_validation.c:502: + /* First argument is blank because the key + is not included in the string being parsed. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #184: FILE: examples/fips_validation/fips_validation.c:502: + is not included in the string being parsed. */ total: 3 errors, 6 warnings, 108 lines checked Warning in examples/fips_validation/fips_validation.c: Using %l format, prefer %PRI*64 if type is [u]int64_t Warning in examples/fips_validation/fips_validation.c: Declaring a variable inside for()