From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5666AA00C4
	for <public@inbox.dpdk.org>; Sat, 29 Jan 2022 18:04:25 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5370B40DDD;
	Sat, 29 Jan 2022 18:04:25 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id D5F8C40041
 for <test-report@dpdk.org>; Sat, 29 Jan 2022 18:04:21 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id D0D16120715; Sat, 29 Jan 2022 18:04:21 +0100 (CET)
Subject: |WARNING| pw106709 [PATCH v2 3/5] examples/fips_validation: add json
 parsing
In-Reply-To: <20220129170313.489986-4-blo@iol.unh.edu>
References: <20220129170313.489986-4-blo@iol.unh.edu>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Brandon Lo <blo@iol.unh.edu>
Message-Id: <20220129170421.D0D16120715@dpdk.org>
Date: Sat, 29 Jan 2022 18:04:21 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106709

_coding style issues_


ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#139: FILE: examples/fips_validation/fips_validation.c:349:
+	if (info.file_type == FIPS_TYPE_JSON) return 0;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#156: FILE: examples/fips_validation/fips_validation.c:459:
+	if (strstr(algo_str, "AES-GCM")) info.algo = FIPS_TEST_ALGO_AES_GCM;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#157: FILE: examples/fips_validation/fips_validation.c:460:
+	else return -EINVAL;

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#170: FILE: examples/fips_validation/fips_validation.c:473:
+			json_t *param = json_object_get(json_info.json_test_group, info.interim_callbacks[i].key);

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#174: FILE: examples/fips_validation/fips_validation.c:477:
+			/* First argument is blank because the key
+			   is not included in the string being parsed. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#174: FILE: examples/fips_validation/fips_validation.c:477:
+			   is not included in the string being parsed. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#199: FILE: examples/fips_validation/fips_validation.c:502:
+			/* First argument is blank because the key
+			   is not included in the string being parsed. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#199: FILE: examples/fips_validation/fips_validation.c:502:
+			   is not included in the string being parsed. */

total: 3 errors, 5 warnings, 117 lines checked
Warning in examples/fips_validation/fips_validation.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t