* |WARNING| pw106850 [PATCH v5] eventdev/eth_rx: fix memory leak when token parsing finished
[not found] <tencent_E5A71311F53AF6DFEB237C22DE31E23C2008@qq.com>
@ 2022-02-04 7:49 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-02-04 7:49 UTC (permalink / raw)
To: test-report; +Cc: Weiguo Li
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106850
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#102: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:296:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(id, retval) do { \
+ if (!rxa_validate_id(id)) { \
+ RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+ ret = retval; \
+ goto error; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#110: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:304:
+#define RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, retval) do { \
+ if ((token) == NULL || strlen(token) == 0 || !isdigit(*token)) { \
+ RTE_EDEV_LOG_ERR("Invalid eth Rx adapter token
"); \
+ ret = retval; \
+ goto error; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#118: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:312:
+#define RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(port_id, retval) do { \
+ if (!rte_eth_dev_is_valid_port(port_id)) { \
+ RTE_ETHDEV_LOG(ERR, "Invalid port_id=%u
", port_id); \
+ ret = retval; \
+ goto error; \
+ } \
+} while (0)
total: 0 errors, 3 warnings, 235 lines checked
^ permalink raw reply [flat|nested] only message in thread