From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Weiguo Li <liwg06@foxmail.com>
Subject: |WARNING| pw106851 [PATCH v6] eventdev/eth_rx: fix memory leak when token parsing finished
Date: Fri, 4 Feb 2022 09:23:21 +0100 (CET) [thread overview]
Message-ID: <20220204082321.3650A120715@dpdk.org> (raw)
In-Reply-To: <tencent_9F23668EE7F9D43C625FA7E73B61E4506405@qq.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/106851
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#105: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:296:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(id, retval) do { \
+ if (!rxa_validate_id(id)) { \
+ RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+ ret = retval; \
+ goto error; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#113: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:304:
+#define RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, retval) do { \
+ if ((token) == NULL || strlen(token) == 0 || !isdigit(*token)) { \
+ RTE_EDEV_LOG_ERR("Invalid eth Rx adapter token
"); \
+ ret = retval; \
+ goto error; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#121: FILE: lib/eventdev/rte_event_eth_rx_adapter.c:312:
+#define RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(port_id, retval) do { \
+ if (!rte_eth_dev_is_valid_port(port_id)) { \
+ RTE_ETHDEV_LOG(ERR, "Invalid port_id=%u
", port_id); \
+ ret = retval; \
+ goto error; \
+ } \
+} while (0)
total: 0 errors, 3 warnings, 216 lines checked
next parent reply other threads:[~2022-02-04 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_9F23668EE7F9D43C625FA7E73B61E4506405@qq.com>
2022-02-04 8:23 ` checkpatch [this message]
2022-02-04 10:19 ` |SUCCESS| " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204082321.3650A120715@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=liwg06@foxmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).