From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: |WARNING| pw107112 [PATCH v2 03/12] net/ngbe: fix Tx pending
Date: Wed, 9 Feb 2022 11:37:06 +0100 (CET) [thread overview]
Message-ID: <20220209103706.6167B120715@dpdk.org> (raw)
In-Reply-To: <20220209104213.602728-4-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/107112
_coding style issues_
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#58:
Add commands requesting firmware to enable or disable PCIe bus master.
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#59:
Disable PCIe master access to clear BME when stop hardware, and verify
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#62:
Move disabling Tx queue after disabling PCIe bus master, to ensure that
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#116: FILE: drivers/net/ngbe/base/ngbe_hw.c:386:
+ * Prevent the PCI-E bus from hanging by disabling PCI-E master
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#119: FILE: drivers/net/ngbe/base/ngbe_hw.c:389:
+ status = ngbe_set_pcie_master(hw, false);
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#134: FILE: drivers/net/ngbe/base/ngbe_hw.c:1091:
+ * ngbe_set_pcie_master - Disable or Enable PCI-express master access
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#134: FILE: drivers/net/ngbe/base/ngbe_hw.c:1091:
+ * ngbe_set_pcie_master - Disable or Enable PCI-express master access
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#137: FILE: drivers/net/ngbe/base/ngbe_hw.c:1094:
+ * Disables PCI-Express master access and verifies there are no pending
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#138: FILE: drivers/net/ngbe/base/ngbe_hw.c:1095:
+ * requests. NGBE_ERR_MASTER_REQUESTS_PENDING is returned if master disable
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#138: FILE: drivers/net/ngbe/base/ngbe_hw.c:1095:
+ * requests. NGBE_ERR_MASTER_REQUESTS_PENDING is returned if master disable
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#139: FILE: drivers/net/ngbe/base/ngbe_hw.c:1096:
+ * bit hasn't caused the master requests to be disabled, else 0
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#140: FILE: drivers/net/ngbe/base/ngbe_hw.c:1097:
+ * is returned signifying master requests disabled.
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#142: FILE: drivers/net/ngbe/base/ngbe_hw.c:1099:
+s32 ngbe_set_pcie_master(struct ngbe_hw *hw, bool enable)
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#148: FILE: drivers/net/ngbe/base/ngbe_hw.c:1105:
+ DEBUGFUNC("ngbe_set_pcie_master");
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#161: FILE: drivers/net/ngbe/base/ngbe_hw.c:1118:
+ /* Exit if master requests are blocked */
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#166: FILE: drivers/net/ngbe/base/ngbe_hw.c:1123:
+ /* Poll for master request bit to clear */
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#167: FILE: drivers/net/ngbe/base/ngbe_hw.c:1124:
+ for (i = 0; i < NGBE_PCI_MASTER_DISABLE_TIMEOUT; i++) {
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#174: FILE: drivers/net/ngbe/base/ngbe_hw.c:1131:
+ status = NGBE_ERR_MASTER_REQUESTS_PENDING;
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#191: FILE: drivers/net/ngbe/base/ngbe_hw.h:57:
+s32 ngbe_set_pcie_master(struct ngbe_hw *hw, bool enable);
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#326: FILE: drivers/net/ngbe/base/ngbe_type.h:20:
+#define NGBE_PCI_MASTER_DISABLE_TIMEOUT 800
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#348: FILE: drivers/net/ngbe/ngbe_ethdev.c:963:
+ ngbe_set_pcie_master(hw, true);
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#357: FILE: drivers/net/ngbe/ngbe_ethdev.c:1178:
+ ngbe_set_pcie_master(hw, true);
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#366: FILE: drivers/net/ngbe/ngbe_ethdev.c:1208:
+ ngbe_set_pcie_master(hw, false);
total: 0 errors, 23 warnings, 0 checks, 251 lines checked
parent reply other threads:[~2022-02-09 10:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220209104213.602728-4-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209103706.6167B120715@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).