From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6F886A034C
	for <public@inbox.dpdk.org>; Wed, 23 Feb 2022 13:30:14 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 69306426D5;
	Wed, 23 Feb 2022 13:30:14 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 351A741226
 for <test-report@dpdk.org>; Wed, 23 Feb 2022 13:30:14 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 1C9D712336A; Wed, 23 Feb 2022 13:30:14 +0100 (CET)
Subject: |WARNING| pw108168 [PATCH v3 2/2] net/cnxk: support IP reassembly
In-Reply-To: <20220223122834.2571860-3-gakhil@marvell.com>
References: <20220223122834.2571860-3-gakhil@marvell.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Akhil Goyal <gakhil@marvell.com>
Message-Id: <20220223123014.1C9D712336A@dpdk.org>
Date: Wed, 23 Feb 2022 13:30:14 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108168

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1895: FILE: drivers/net/cnxk/cn10k_ethdev_sec.c:341:
+		if (rte_eth_ip_reassembly_dynfield_register(

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2479: FILE: drivers/net/cnxk/cn10k_rx.h:565:
+			/* Clear checksum flags and update security flag
+			*/

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 20)
#2598: FILE: drivers/net/cnxk/cn10k_rx.h:810:
+	if ((!(flag & NIX_RX_SEC_REASSEMBLY_F) || !(w1 & BIT(11))) &&
[...]
+		    ol_flags |= nix_rx_olflags_get(lookup_mem, w1);

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2719: FILE: drivers/net/cnxk/cn10k_rx.h:1698:
+#define NIX_RX_FASTPATH_MODES_192_207                                          \
+	R(reas_sec, R_REAS_F | R_SEC_F)                                                        \
+	R(reas_sec_rss, R_REAS_F | R_SEC_F | RSS_F)                                            \
+	R(reas_sec_ptype, R_REAS_F | R_SEC_F | PTYPE_F)                                        \
+	R(reas_sec_ptype_rss, R_REAS_F | R_SEC_F | PTYPE_F | RSS_F)                            \
+	R(reas_sec_cksum, R_REAS_F | R_SEC_F | CKSUM_F)                                        \
+	R(reas_sec_cksum_rss, R_REAS_F | R_SEC_F | CKSUM_F | RSS_F)                            \
+	R(reas_sec_cksum_ptype, R_REAS_F | R_SEC_F | CKSUM_F | PTYPE_F)                        \
+	R(reas_sec_cksum_ptype_rss, R_REAS_F | R_SEC_F | CKSUM_F | PTYPE_F | RSS_F)            \
+	R(reas_sec_mark, R_REAS_F | R_SEC_F | MARK_F)                                          \
+	R(reas_sec_mark_rss, R_REAS_F | R_SEC_F | MARK_F | RSS_F)                              \
+	R(reas_sec_mark_ptype, R_REAS_F | R_SEC_F | MARK_F | PTYPE_F)                          \
+	R(reas_sec_mark_ptype_rss, R_REAS_F | R_SEC_F | MARK_F | PTYPE_F | RSS_F)              \
+	R(reas_sec_mark_cksum, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F)                          \
+	R(reas_sec_mark_cksum_rss, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | RSS_F)              \
+	R(reas_sec_mark_cksum_ptype, R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | PTYPE_F)          \
+	R(reas_sec_mark_cksum_ptype_rss,                                            \
+	  R_REAS_F | R_SEC_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2738: FILE: drivers/net/cnxk/cn10k_rx.h:1717:
+#define NIX_RX_FASTPATH_MODES_208_223                                          \
+	R(reas_sec_ts, R_REAS_F | R_SEC_F | TS_F)                                              \
+	R(reas_sec_ts_rss, R_REAS_F | R_SEC_F | TS_F | RSS_F)                                  \
+	R(reas_sec_ts_ptype, R_REAS_F | R_SEC_F | TS_F | PTYPE_F)                              \
+	R(reas_sec_ts_ptype_rss, R_REAS_F | R_SEC_F | TS_F | PTYPE_F | RSS_F)                  \
+	R(reas_sec_ts_cksum, R_REAS_F | R_SEC_F | TS_F | CKSUM_F)                              \
+	R(reas_sec_ts_cksum_rss, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | RSS_F)                  \
+	R(reas_sec_ts_cksum_ptype, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | PTYPE_F)              \
+	R(reas_sec_ts_cksum_ptype_rss, R_REAS_F | R_SEC_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)  \
+	R(reas_sec_ts_mark, R_REAS_F | R_SEC_F | TS_F | MARK_F)                                \
+	R(reas_sec_ts_mark_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | RSS_F)                    \
+	R(reas_sec_ts_mark_ptype, R_REAS_F | R_SEC_F | TS_F | MARK_F | PTYPE_F)                \
+	R(reas_sec_ts_mark_ptype_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | PTYPE_F | RSS_F)    \
+	R(reas_sec_ts_mark_cksum, R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F)                \
+	R(reas_sec_ts_mark_cksum_rss, R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | RSS_F)    \
+	R(reas_sec_ts_mark_cksum_ptype,                                             \
+	  R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)                         \
+	R(reas_sec_ts_mark_cksum_ptype_rss,                                         \
+	  R_REAS_F | R_SEC_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2758: FILE: drivers/net/cnxk/cn10k_rx.h:1737:
+#define NIX_RX_FASTPATH_MODES_224_239                                          \
+	R(reas_sec_vlan, R_REAS_F | R_SEC_F | RX_VLAN_F)                                       \
+	R(reas_sec_vlan_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | RSS_F)                           \
+	R(reas_sec_vlan_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | PTYPE_F)                       \
+	R(reas_sec_vlan_ptype_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | PTYPE_F | RSS_F)           \
+	R(reas_sec_vlan_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F)                       \
+	R(reas_sec_vlan_cksum_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | RSS_F)           \
+	R(reas_sec_vlan_cksum_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F)       \
+	R(reas_sec_vlan_cksum_ptype_rss,                                            \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | CKSUM_F | PTYPE_F | RSS_F)                     \
+	R(reas_sec_vlan_mark, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F)                         \
+	R(reas_sec_vlan_mark_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | RSS_F)             \
+	R(reas_sec_vlan_mark_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F)         \
+	R(reas_sec_vlan_mark_ptype_rss,                                             \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | PTYPE_F | RSS_F)                      \
+	R(reas_sec_vlan_mark_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F)         \
+	R(reas_sec_vlan_mark_cksum_rss,                                             \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | RSS_F)                      \
+	R(reas_sec_vlan_mark_cksum_ptype,                                           \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F)                    \
+	R(reas_sec_vlan_mark_cksum_ptype_rss,                                       \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#2781: FILE: drivers/net/cnxk/cn10k_rx.h:1760:
+#define NIX_RX_FASTPATH_MODES_240_255                                          \
+	R(reas_sec_vlan_ts, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F)                             \
+	R(reas_sec_vlan_ts_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | RSS_F)                 \
+	R(reas_sec_vlan_ts_ptype, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F)             \
+	R(reas_sec_vlan_ts_ptype_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | PTYPE_F | RSS_F) \
+	R(reas_sec_vlan_ts_cksum, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F)             \
+	R(reas_sec_vlan_ts_cksum_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | RSS_F) \
+	R(reas_sec_vlan_ts_cksum_ptype,                                             \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F)                      \
+	R(reas_sec_vlan_ts_cksum_ptype_rss,                                         \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | CKSUM_F | PTYPE_F | RSS_F)              \
+	R(reas_sec_vlan_ts_mark, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F)               \
+	R(reas_sec_vlan_ts_mark_rss, R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | RSS_F)   \
+	R(reas_sec_vlan_ts_mark_ptype,                                              \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F)                       \
+	R(reas_sec_vlan_ts_mark_ptype_rss,                                          \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | PTYPE_F | RSS_F)               \
+	R(reas_sec_vlan_ts_mark_cksum,                                              \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F)                       \
+	R(reas_sec_vlan_ts_mark_cksum_rss,                                          \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | RSS_F)               \
+	R(reas_sec_vlan_ts_mark_cksum_ptype,                                        \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F)             \
+	R(reas_sec_vlan_ts_mark_cksum_ptype_rss,                                    \
+	  R_REAS_F | R_SEC_F | RX_VLAN_F | TS_F | MARK_F | CKSUM_F | PTYPE_F | RSS_F)

total: 4 errors, 2 warnings, 1 checks, 2308 lines checked