From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jeff Daly <jeffd@silicom-usa.com>
Subject: |WARNING| pw108298 [PATCH v3 3/3] net/ixgbe: Fix SFP detection and linking on hotplug
Date: Thu, 24 Feb 2022 16:25:15 +0100 (CET) [thread overview]
Message-ID: <20220224152516.05AE512336A@dpdk.org> (raw)
In-Reply-To: <20220224152357.12277-4-jeffd@silicom-usa.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108298
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects?
#233: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:352:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ uint32_t latest = IXGBE_READ_REG(hw, reg); \
+ cur += (latest - last) & UINT_MAX; \
+ last = latest; \
+}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues
#233: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:352:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ uint32_t latest = IXGBE_READ_REG(hw, reg); \
+ cur += (latest - last) & UINT_MAX; \
+ last = latest; \
+}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues
#233: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:352:
+#define UPDATE_VF_STAT(reg, last, cur) \
+{ \
+ uint32_t latest = IXGBE_READ_REG(hw, reg); \
+ cur += (latest - last) & UINT_MAX; \
+ last = latest; \
+}
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects?
#240: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:359:
+#define UPDATE_VF_STAT_36BIT(lsb, msb, last, cur) \
+{ \
+ u64 new_lsb = IXGBE_READ_REG(hw, lsb); \
+ u64 new_msb = IXGBE_READ_REG(hw, msb); \
+ u64 latest = ((new_msb << 32) | new_lsb); \
cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \
+ last = latest; \
}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues
#240: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:359:
+#define UPDATE_VF_STAT_36BIT(lsb, msb, last, cur) \
+{ \
+ u64 new_lsb = IXGBE_READ_REG(hw, lsb); \
+ u64 new_msb = IXGBE_READ_REG(hw, msb); \
+ u64 latest = ((new_msb << 32) | new_lsb); \
cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \
+ last = latest; \
}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues
#240: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:359:
+#define UPDATE_VF_STAT_36BIT(lsb, msb, last, cur) \
+{ \
+ u64 new_lsb = IXGBE_READ_REG(hw, lsb); \
+ u64 new_msb = IXGBE_READ_REG(hw, msb); \
+ u64 latest = ((new_msb << 32) | new_lsb); \
cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \
+ last = latest; \
}
WARNING:TYPO_SPELLING: 'thead' may be misspelled - perhaps 'thread'?
#824: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3163:
+ PMD_DRV_LOG(ERR, "service_thead err");
total: 0 errors, 1 warnings, 6 checks, 1038 lines checked
next parent reply other threads:[~2022-02-24 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220224152357.12277-4-jeffd@silicom-usa.com>
2022-02-24 15:25 ` checkpatch [this message]
2022-02-24 17:19 ` |FAILURE| " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224152516.05AE512336A@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jeffd@silicom-usa.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).