From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27212A034E for ; Thu, 24 Feb 2022 16:25:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22B8841156; Thu, 24 Feb 2022 16:25:18 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 2C48D4114D for ; Thu, 24 Feb 2022 16:25:17 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 05AE512336A; Thu, 24 Feb 2022 16:25:15 +0100 (CET) Subject: |WARNING| pw108298 [PATCH v3 3/3] net/ixgbe: Fix SFP detection and linking on hotplug In-Reply-To: <20220224152357.12277-4-jeffd@silicom-usa.com> References: <20220224152357.12277-4-jeffd@silicom-usa.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Jeff Daly Message-Id: <20220224152516.05AE512336A@dpdk.org> Date: Thu, 24 Feb 2022 16:25:15 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/108298 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #233: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:352: +#define UPDATE_VF_STAT(reg, last, cur) \ +{ \ + uint32_t latest = IXGBE_READ_REG(hw, reg); \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues #233: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:352: +#define UPDATE_VF_STAT(reg, last, cur) \ +{ \ + uint32_t latest = IXGBE_READ_REG(hw, reg); \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #233: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:352: +#define UPDATE_VF_STAT(reg, last, cur) \ +{ \ + uint32_t latest = IXGBE_READ_REG(hw, reg); \ + cur += (latest - last) & UINT_MAX; \ + last = latest; \ +} CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects? #240: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:359: +#define UPDATE_VF_STAT_36BIT(lsb, msb, last, cur) \ +{ \ + u64 new_lsb = IXGBE_READ_REG(hw, lsb); \ + u64 new_msb = IXGBE_READ_REG(hw, msb); \ + u64 latest = ((new_msb << 32) | new_lsb); \ cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last' may be better as '(last)' to avoid precedence issues #240: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:359: +#define UPDATE_VF_STAT_36BIT(lsb, msb, last, cur) \ +{ \ + u64 new_lsb = IXGBE_READ_REG(hw, lsb); \ + u64 new_msb = IXGBE_READ_REG(hw, msb); \ + u64 latest = ((new_msb << 32) | new_lsb); \ cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues #240: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:359: +#define UPDATE_VF_STAT_36BIT(lsb, msb, last, cur) \ +{ \ + u64 new_lsb = IXGBE_READ_REG(hw, lsb); \ + u64 new_msb = IXGBE_READ_REG(hw, msb); \ + u64 latest = ((new_msb << 32) | new_lsb); \ cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \ + last = latest; \ } WARNING:TYPO_SPELLING: 'thead' may be misspelled - perhaps 'thread'? #824: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:3163: + PMD_DRV_LOG(ERR, "service_thead err"); total: 0 errors, 1 warnings, 6 checks, 1038 lines checked