From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7E14A034C for ; Thu, 24 Feb 2022 17:10:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C42A04114D; Thu, 24 Feb 2022 17:10:59 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id EB7FC40040 for ; Thu, 24 Feb 2022 17:10:57 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id D2E1412336A; Thu, 24 Feb 2022 17:10:57 +0100 (CET) Subject: |WARNING| pw108316 [PATCH v2 2/2] net/cnxk: align perfetchs to CN10K cache model In-Reply-To: <20220224161013.4566-2-pbhagavatula@marvell.com> References: <20220224161013.4566-2-pbhagavatula@marvell.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Message-Id: <20220224161057.D2E1412336A@dpdk.org> Date: Thu, 24 Feb 2022 17:10:57 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/108316 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects? #154: FILE: drivers/net/cnxk/cn10k_rx.h:39: +#define CQE_PTR_DIFF(b, i, o, f) \ + (((f) & NIX_RX_VWQE_F) ? \ + (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) : \ + (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #154: FILE: drivers/net/cnxk/cn10k_rx.h:39: +#define CQE_PTR_DIFF(b, i, o, f) \ + (((f) & NIX_RX_VWQE_F) ? \ + (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) : \ + (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'o' - possible side-effects? #154: FILE: drivers/net/cnxk/cn10k_rx.h:39: +#define CQE_PTR_DIFF(b, i, o, f) \ + (((f) & NIX_RX_VWQE_F) ? \ + (uint64_t *)(((uintptr_t)((uint64_t *)(b))[i]) - (o)) : \ + (uint64_t *)(((uintptr_t)(b)) + CQE_SZ(i) - (o))) ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects #160: FILE: drivers/net/cnxk/cn10k_rx.h:45: +#define NIX_MBUF_VALIDATE_NEXT(m) \ + if (m->nb_segs == 1 && mbuf->next) { \ + rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d", \ + m->next, m->nb_segs); \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects? #160: FILE: drivers/net/cnxk/cn10k_rx.h:45: +#define NIX_MBUF_VALIDATE_NEXT(m) \ + if (m->nb_segs == 1 && mbuf->next) { \ + rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d", \ + m->next, m->nb_segs); \ + } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'm' may be better as '(m)' to avoid precedence issues #160: FILE: drivers/net/cnxk/cn10k_rx.h:45: +#define NIX_MBUF_VALIDATE_NEXT(m) \ + if (m->nb_segs == 1 && mbuf->next) { \ + rte_panic("mbuf->next[%p] valid when mbuf->nb_segs is %d", \ + m->next, m->nb_segs); \ + } CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #190: FILE: drivers/net/cnxk/cn10k_rx.h:695: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #192: FILE: drivers/net/cnxk/cn10k_rx.h:697: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #194: FILE: drivers/net/cnxk/cn10k_rx.h:699: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #196: FILE: drivers/net/cnxk/cn10k_rx.h:701: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #200: FILE: drivers/net/cnxk/cn10k_rx.h:705: + rte_prefetch1( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #202: FILE: drivers/net/cnxk/cn10k_rx.h:707: + rte_prefetch1( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #204: FILE: drivers/net/cnxk/cn10k_rx.h:709: + rte_prefetch1( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #206: FILE: drivers/net/cnxk/cn10k_rx.h:711: + rte_prefetch1( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #209: FILE: drivers/net/cnxk/cn10k_rx.h:714: + rte_prefetch1(CQE_PTR_OFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #211: FILE: drivers/net/cnxk/cn10k_rx.h:716: + rte_prefetch1(CQE_PTR_OFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #213: FILE: drivers/net/cnxk/cn10k_rx.h:718: + rte_prefetch1(CQE_PTR_OFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #215: FILE: drivers/net/cnxk/cn10k_rx.h:720: + rte_prefetch1(CQE_PTR_OFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #220: FILE: drivers/net/cnxk/cn10k_rx.h:725: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #222: FILE: drivers/net/cnxk/cn10k_rx.h:727: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #224: FILE: drivers/net/cnxk/cn10k_rx.h:729: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #226: FILE: drivers/net/cnxk/cn10k_rx.h:731: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #229: FILE: drivers/net/cnxk/cn10k_rx.h:734: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #232: FILE: drivers/net/cnxk/cn10k_rx.h:737: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #235: FILE: drivers/net/cnxk/cn10k_rx.h:740: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #238: FILE: drivers/net/cnxk/cn10k_rx.h:743: + rte_prefetch0(CQE_PTR_DIFF( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #245: FILE: drivers/net/cnxk/cn10k_rx.h:750: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #247: FILE: drivers/net/cnxk/cn10k_rx.h:752: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #249: FILE: drivers/net/cnxk/cn10k_rx.h:754: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #251: FILE: drivers/net/cnxk/cn10k_rx.h:756: + rte_prefetch_non_temporal( total: 1 errors, 0 warnings, 29 checks, 191 lines checked Warning in drivers/net/cnxk/cn10k_rx.h: Using rte_panic/rte_exit