From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F92A04A2 for ; Fri, 4 Mar 2022 02:24:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32B294279A; Fri, 4 Mar 2022 02:24:54 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id E1EA642799 for ; Fri, 4 Mar 2022 02:24:53 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id DD0D71234A0; Fri, 4 Mar 2022 02:24:53 +0100 (CET) Subject: |WARNING| pw108524 [PATCH] dpdk: show dev basic info In-Reply-To: <20220304012257.39247-3-humin29@huawei.com> References: <20220304012257.39247-3-humin29@huawei.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: "Min Hu (Connor)" Message-Id: <20220304012453.DD0D71234A0@dpdk.org> Date: Fri, 4 Mar 2022 02:24:53 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/108524 _coding style issues_ ERROR:SPACING: space required after that close brace '}' #169: FILE: app/proc-info/main.c:173: +}eth_speed_table[] = { ERROR:SPACING: space prohibited after that open parenthesis '(' #220: FILE: app/proc-info/main.c:795: + printf( " -- maximum number of MAC addresses: %u " ERROR:SPACING: space prohibited after that open parenthesis '(' #272: FILE: app/proc-info/main.c:847: + printf( " -- RSS disabled"); WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(eth_speed_table) #291: FILE: app/proc-info/main.c:866: + int size = sizeof(eth_speed_table) / sizeof(eth_speed_table[0]); WARNING:BRACES: braces {} are not necessary for single statement blocks #299: FILE: app/proc-info/main.c:874: + if (!(speed_capa & ETH_LINK_SPEED_FIXED)) { + printf("auto"); + } ERROR:SPACING: space prohibited after that open parenthesis '(' #318: FILE: app/proc-info/main.c:893: + printf( " -- Rx burst mode: %s%s " WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #488: FILE: drivers/net/hns3/hns3_ethdev_dump.c:18: + static const char *state_name[] = { ERROR:TRAILING_WHITESPACE: trailing whitespace #566: FILE: drivers/net/hns3/hns3_ethdev_dump.c:96: +^I};^I$ WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #578: FILE: drivers/net/hns3/hns3_ethdev_dump.c:108: + static const char *tuple_name[] = { WARNING:TYPO_SPELLING: '2st' may be misspelled - perhaps '2nd'? #582: FILE: drivers/net/hns3/hns3_ethdev_dump.c:112: + "outer_vlan_2st_tag", ERROR:TRAILING_WHITESPACE: trailing whitespace #834: FILE: drivers/net/hns3/hns3_ethdev_dump.c:364: +}^I^I^I$ ERROR:SPACING: space required after that ',' (ctx:VxV) #900: FILE: drivers/net/hns3/hns3_ethdev_dump.c:430: + fprintf(file," - Rx/Tx Queue Info: "); ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1096: FILE: drivers/net/hns3/hns3_ethdev_dump.c:626: + fprintf(file," - VLAN Config Info: "); ^ ERROR:TRAILING_WHITESPACE: trailing whitespace #1109: FILE: drivers/net/hns3/hns3_ethdev_dump.c:639: +^Iget_port_pvid_info(file, hw);^I$ CHECK:CAMELCASE: Avoid CamelCase: #1125: FILE: drivers/net/hns3/hns3_ethdev_dump.c:655: + " id=%u reference_count=%u peak_rate=%"PRIu64"Bps ", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1125: FILE: drivers/net/hns3/hns3_ethdev_dump.c:655: + " id=%u reference_count=%u peak_rate=%"PRIu64"Bps ", WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #1139: FILE: drivers/net/hns3/hns3_ethdev_dump.c:669: + " port_node: " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #1157: FILE: drivers/net/hns3/hns3_ethdev_dump.c:687: + fprintf(file, " tc_node: "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #1224: FILE: drivers/net/hns3/hns3_ethdev_dump.c:754: + " queue_node: " ERROR:TRAILING_WHITESPACE: trailing whitespace #1377: FILE: drivers/net/hns3/hns3_ethdev_dump.c:907: +^I^Ireturn 0;^I$ ERROR:TRAILING_WHITESPACE: trailing whitespace #1382: FILE: drivers/net/hns3/hns3_ethdev_dump.c:912: +^Iget_fdir_basic_info(file, &hns->pf);^I$ total: 11 errors, 8 warnings, 1365 lines checked