From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: madhuker.mythri@oracle.com
Subject: |WARNING| pw108876 [PATCH] net/tap: Fixed RSS algorithm to support fragmented packets
Date: Fri, 25 Mar 2022 16:29:38 +0100 (CET) [thread overview]
Message-ID: <20220325152938.45670121D58@dpdk.org> (raw)
In-Reply-To: <20220325152809.2035-1-madhuker.mythri@oracle.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/108876
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#81:
As per analysis on DPDK Tap PMD, the existing RSS algorithm considering 4-tuple(Src-IP, Dst-IP, Src-port and Dst-port) and identification of fragment packets is not done, thus we are seeing all the fragmented chunks of single packet differs RSS hash value and distributed across multiple queues.
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mf == 0'
#3526: FILE: drivers/net/tap/tap_bpf_program.c:186:
+ if ((mf == 0) && (frag_off == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frag_off == 0'
#3526: FILE: drivers/net/tap/tap_bpf_program.c:186:
+ if ((mf == 0) && (frag_off == 0)) {
WARNING:TYPO_SPELLING: 'heaer' may be misspelled - perhaps 'header'?
#3555: FILE: drivers/net/tap/tap_bpf_program.c:218:
+ /** Fetch the L4 header port-numbers only if next-heaer
ERROR:TRAILING_WHITESPACE: trailing whitespace
#3555: FILE: drivers/net/tap/tap_bpf_program.c:218:
+^I^I/** Fetch the L4 header port-numbers only if next-heaer $
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#3563: FILE: drivers/net/tap/tap_bpf_program.c:226:
+ }
+ else {
CHECK:BRACES: Unbalanced braces around else statement
#3563: FILE: drivers/net/tap/tap_bpf_program.c:226:
+ else {
total: 2 errors, 2 warnings, 3 checks, 3460 lines checked
next parent reply other threads:[~2022-03-25 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220325152809.2035-1-madhuker.mythri@oracle.com>
2022-03-25 15:29 ` checkpatch [this message]
2022-03-25 17:39 ` |SUCCESS| " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325152938.45670121D58@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=madhuker.mythri@oracle.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).