From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1D9CBA0501
	for <public@inbox.dpdk.org>; Fri,  8 Apr 2022 12:28:26 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 17ED740689;
	Fri,  8 Apr 2022 12:28:26 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 44CC24003F
 for <test-report@dpdk.org>; Fri,  8 Apr 2022 12:28:25 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 3882B124163; Fri,  8 Apr 2022 12:28:25 +0200 (CEST)
Subject: |WARNING| pw109518 [PATCH v2] common/sff_module: add telemetry
 command to dump module EEPROM
In-Reply-To: <20220408102330.774749-1-robinx.zhang@intel.com>
References: <20220408102330.774749-1-robinx.zhang@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Robin Zhang <robinx.zhang@intel.com>
Message-Id: <20220408102825.3882B124163@dpdk.org>
Date: Fri,  8 Apr 2022 12:28:25 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109518

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#866: FILE: drivers/common/sff_module/sff_8472.c:33:
+ * This is the offset at which the A2 page is in the EEPROM $

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1592: FILE: drivers/common/sff_module/sff_8636.c:452:
+		printf("%s 40G OTN (OTU3B/OTU3C)
", pfx);

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1592: FILE: drivers/common/sff_module/sff_8636.c:452:
+		printf("%s 40G OTN (OTU3B/OTU3C)
", pfx);

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1593: FILE: drivers/common/sff_module/sff_8636.c:453:
+		add_item_string(items, name_string, "40G OTN (OTU3B/OTU3C)");

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1593: FILE: drivers/common/sff_module/sff_8636.c:453:
+		add_item_string(items, name_string, "40G OTN (OTU3B/OTU3C)");

WARNING:TYPO_SPELLING: 'gurantee' may be misspelled - perhaps 'guarantee'?
#2022: FILE: drivers/common/sff_module/sff_8636.c:882:
+	 * of page 3, will provide the gurantee for existence of alarms

WARNING:TYPO_SPELLING: 'Celcius' may be misspelled - perhaps ''?
#3336: FILE: drivers/common/sff_module/sff_common.h:167:
+	/* SFP Temp in 16-bit signed 1/256 Celcius */

ERROR:CODE_INDENT: code indent should use tabs where possible
#3534: FILE: drivers/common/sff_module/sff_telemetry.h:19:
+        char name[SFF_ITEM_NAME_SIZE];    /* The item name. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3534: FILE: drivers/common/sff_module/sff_telemetry.h:19:
+        char name[SFF_ITEM_NAME_SIZE];    /* The item name. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3535: FILE: drivers/common/sff_module/sff_telemetry.h:20:
+        char value[SFF_ITEM_VALUE_SIZE];  /* The item value. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3535: FILE: drivers/common/sff_module/sff_telemetry.h:20:
+        char value[SFF_ITEM_VALUE_SIZE];  /* The item value. */$

total: 3 errors, 8 warnings, 3389 lines checked